Received-SPF: pass (google.com: domain of linux-kernel+bounces-85736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 28 Feb 2024 21:38:35 +0000
From: Mark Brown <broonie@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <ajones@ventanamicro.com>,
	Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Aishwarya TCV <aishwarya.tcv@arm.com>
Subject: Re: [PATCH v3 3/8] KVM: selftests: Move setting a vCPU's entry point
 to a dedicated API
Message-ID: <f399a68a-ad9d-4734-b5da-25f5ce3b832e@sirena.org.uk>
References: <20240208204844.119326-1-thuth@redhat.com>
 <20240208204844.119326-4-thuth@redhat.com>
 <501ac94d-11ab-4765-a25d-75013c021be6@sirena.org.uk>
 <Zd-JjBNCpFG5iDul@google.com>
 <Zd-jdAtI_C_d_fp4@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SwDm9igrBxoRwCqa"
Content-Disposition: inline
In-Reply-To: <Zd-jdAtI_C_d_fp4@google.com>


--SwDm9igrBxoRwCqa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 28, 2024 at 01:19:48PM -0800, Sean Christopherson wrote:

> I'll squash the above and force push.

Thanks, I'll give that a spin (likely tomorrow at this point).

> And another question: is there any reason to not force -Werror for selftests?

Enabling it by default can cause a bunch of fragility when people are
running different compilers, there's things like all the different clang
versions, and it's especially common to run into issues when you've got
a shiny new compiler on a modern distro but need to go look at older
kernels for some reason.  You then get issues bisecting things since you
get regions where the build was broken due to -Werror which may or may
not be pointing at the runtime issue you were looking for (particularly
likely to be hiding things if the build issue is in a different test).

--SwDm9igrBxoRwCqa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXfp9oACgkQJNaLcl1U
h9A9bwf/VnSj06MmEyM0O1ewUOdPy7uhrvuT68nO1/lvDe+rtaLIid4t9pEV/dCX
xVWT2JLrSU0tExy5RiX74TepZl9YIuWvZF1ErGoBOsd1zkJP6hmR/wDlqFoIxa6D
AA35wfE1FFJgvg7xLwFu2ViM05ZGfRIkpsI5Xfa0fgU2fyLNP5g4M3DJffVXC0Bs
ydCFydnLPiyCGEFBfU7i1IzxwmkU4yu8FvbqD4OXZ/zbDWcRlKys7TrnyrHTgHRm
oObROPpcc4yYdEDkSa5llyja1965xEqVqLCPF50Si181hnvcE4jTnj0kPZEJSJsj
k6gIX3jR9mFJyOarI1WbSPZFBOOIKg==
=MB1e
-----END PGP SIGNATURE-----

--SwDm9igrBxoRwCqa--