Received-SPF: pass (google.com: domain of linux-kernel+bounces-85772-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Sebastian Reichel <sre@kernel.org>, 
 "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
 Nathan Chancellor <nathan@kernel.org>
In-Reply-To: <20240228-device_cleanup-power-v1-1-52c0321c48e1@marliere.net>
References: <20240228-device_cleanup-power-v1-1-52c0321c48e1@marliere.net>
Subject: Re: [PATCH] power: supply: move power_supply_attr_group into
 #ifdef block
Message-Id: <170915813338.50142.16479593478459212798.b4-ty@collabora.com>
Date: Wed, 28 Feb 2024 23:08:53 +0100
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Wed, 28 Feb 2024 10:46:28 -0300, Ricardo B. Marliere wrote:
> When building with CONFIG_SYSFS=n, the build error below is triggered:
> 
> ld: drivers/power/supply/power_supply_core.o:(.data+0x0): undefined
> reference to `power_supply_attr_group'
> 
> The problem is that power_supply_attr_group is needed in
> power_supply_core.c but defined in power_supply_sysfs.c, which is only
> targeted with CONFIG_SYSFS=y. Therefore, move the extern declaration into
> the #ifdef block that checks for CONFIG_SYSFS, and define an empty static
> const struct otherwise. This is safe because the macro __ATRIBUTE_GROUPS in
> power_supply_core.c will expand into an empty attribute_group array.
> 
> [...]

Applied, thanks!

[1/1] power: supply: move power_supply_attr_group into #ifdef block
      commit: ea4367c40c79a5f16cb0de8a94a6b72697d37f06

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>