Received-SPF: pass (google.com: domain of linux-kernel+bounces-85776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <24963d5f5a964f7620a4aa1cf5769d62.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240223202556.2194021-1-michael.j.ruhl@intel.com>
References: <20240223202556.2194021-1-michael.j.ruhl@intel.com>
Subject: Re: [PATCH v3] clkdev: Update clkdev id usage to allow for longer names
From: Stephen Boyd <sboyd@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>, Michael Turquette <mturquette@baylibre.com>, andriy.shevchenko@linux.intel.com, Michael J. Ruhl <michael.j.ruhl@intel.com>, Russell King <rmk+kernel@armlinux.org.uk>
To: Michael J. Ruhl <michael.j.ruhl@intel.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 28 Feb 2024 14:14:48 -0800
User-Agent: alot/0.10

Quoting Michael J. Ruhl (2024-02-23 12:25:56)
> clkdev DEV ID information is limited to an array of 20 bytes
> (MAX_DEV_ID).  It is possible that the ID could be longer than
> that.  If so, the lookup will fail because the "real ID" will
> not match the copied value.
>=20
> For instance, generating a device name for the I2C Designware
> module using the PCI ID can result in a name of:
>=20
> i2c_designware.39424
>=20
> clkdev_create() will store:
>=20
> i2c_designware.3942
>=20
> The stored name is one off and will not match correctly during probe.
>=20
> Increase the size of the ID to allow for a longer name.
>=20
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---

Applied to clk-next