Received-SPF: pass (google.com: domain of linux-kernel+bounces-85808-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <25bdda18-4e05-42a6-a0e1-3e35a81ca90f@gmx.de>
Date: Wed, 28 Feb 2024 23:54:10 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2
 Bios: A26
Content-Language: sv-SE
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>, =?UTF-8?Q?Pali_Roh=C3=A1r?=
 <pali@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>,
 linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240222215010.31456-1-hoehnp@gmx.de>
 <3s546clapu73llqqyhj7fhab5cwhchygrtq53juqcqoyttk2dx@47ylvwpqso5d>
From: =?UTF-8?Q?Patrick_H=C3=B6hn?= <hoehnp@gmx.de>
In-Reply-To: <3s546clapu73llqqyhj7fhab5cwhchygrtq53juqcqoyttk2dx@47ylvwpqso5d>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Kz83J+2lz6w=;jv6JANSlyKWaVCC9FVPAg8D1CQR
 059VGe9ltUT3Cum+n9mG2frt4F3vPzE09KlNP6iMF5odfTD0X+I8Z/GyZr+g+t6qvETXjNktL
 Cr9tXOvTJkekF/+WRUMFTMOGJMD8OyW+deR8oSNHtrt3xKuxgYF2BFvRFotPWyGcI7e5Th1Fy
 pkl3q6niqzKGxNYr7sQC7ewixa2aVd/qvimmlWF/vdKB37S0lTMDL4x32WgOG9vNvHqI3jocV
 CR9J2/lkhxyhRJTTPsOlaAZvNqKjklkI0egcEFqHsVtoQawN5uxYxFLwQerHxeJFhfCsm4FLI
 k8xBbIOzXr12m5Up0K4WSSXP6KmShj8NBuaOHHKupkw0yJtEmLYBjniBwgVIYANpl5SweiROh
 95ajlGsWHdyN8TlfaXEilTdk7jaITqRvP3GHLc8Udiqx1t+k/HWT8+whRlUDTQ7Ff1quYhvAE
 CBFlJCuTtn635AF4XJYHS+fwpRiUT23fh5gMPOnKlawsVROnuWsuOGqJRQy9XYMbZ4SKmfv15
 WcjqzcBZGn0SaWsOuqcIKdeSP84zFTg4xGHuoM19H+aAmo/0Jp0Pp+q0zWkXNROFMbLMRbYiM
 a9J0GHCxMm7IvPsd/PCbf3FcWJuBbkZVR5fbBzT5CbOoV+oMEgFuj7ZSO2EKXLLeEzGTKS3Yk
 fksOohVdUXO++XyzuZ0blZVFnNbjyXp3CMlSVJQfk9/yVU8KWH1a5iNGKyD3B17pbmsFd7731
 k4T+ZKQsxxwOK8e6xeFL0kD91cgs7o3icLeVLtfEKMMYZFw7nFyuqxYsr+gAQ37vHFBcjVIPD
 OA/KNB6uBC+6NASL7JnybIHJUSHW3rV+LP4yx4m2t/MWQ=

Hi Andi,

sorry for the late response. Since it is the first time I am
contributing, please excuse me, if my description still needs
improvement. I can simply describe what I did:

similiarly to what Paul did before, I identified that the M6800 has the
accelerometer installed and verified its address using my running Gentoo
System. Then I was applying the patch to latest kernel and confirmed
that it was booting successfully and the message about a successful
detection was present.

Is this along the lines you expect?

Best Regards,
Patrick
Den 2024-02-22 kl. 23:24, skrev Andi Shyti:
> Hi Patrick,
>
> On Thu, Feb 22, 2024 at 10:50:08PM +0100, Patrick H=C3=B6hn wrote:
>> Signed-off-by: Patrick H=C3=B6hn <hoehnp@gmx.de>
>
> I see that you've fixed almost everything that Paul has
> suggested, but please elaborate a bit more in the git commit.
>
> Spend some time adding a description. If you want, you can reply
> to this email with the commit log you have in mind, and I can add
> it for you, or you can send a v3.
>
> Thank you, Paul, for your excellent review.
>
> Andi
>
> PS: A small nitpick: there's no need to add 'v2' in the title.
>      '[PATCH v2]' is sufficient.
>
>> ---
>>   drivers/i2c/busses/i2c-i801.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i80=
1.c
>> index 2c36b36d7d51..c1fee2c61da1 100644
>> --- a/drivers/i2c/busses/i2c-i801.c
>> +++ b/drivers/i2c/busses/i2c-i801.c
>> @@ -1231,6 +1231,7 @@ static const struct {
>>   	 */
>>   	{ "Latitude 5480",      0x29 },
>>   	{ "Precision 3540",     0x29 },
>> +	{ "Precision M6800",    0x29 },
>>   	{ "Vostro V131",        0x1d },
>>   	{ "Vostro 5568",        0x29 },
>>   	{ "XPS 15 7590",        0x29 },
>> --
>> 2.43.0
>>