Received-SPF: pass (google.com: domain of linux-kernel+bounces-85802-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <2f6897c0-1b57-45b3-a1f1-9862b0e4c884@intel.com>
Date: Thu, 29 Feb 2024 11:49:13 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 008/130] x86/tdx: Warning with 32bit build
 shift-count-overflow
To: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, <chen.bo@intel.com>, <hang.yuan@intel.com>,
	<tina.zhang@intel.com>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <a50918ba3415be4186a91161fe3bbd839153d8b2.1708933498.git.isaku.yamahata@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <a50918ba3415be4186a91161fe3bbd839153d8b2.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amU0U2tUaGJQcDZ1YXpmeVF4K0N4VWd1c2FSZkt6QnpRZHFtc2NNRGUrT0Y0?=
 =?utf-8?B?Q3VxTkVNUnI2RjRoMWplbExOU2kwTmN2REZ3WjhNS2Z5bUtJNjg1YkJ0SERX?=
 =?utf-8?B?b1F1WkpuRDJ1Skx2RDk1WGZzS1pTL254N245Ui9qdVRQMlBVSTFNY3lNZWxV?=
 =?utf-8?B?b3pUczNJL3hxYURDNG5DOG1kcVRZOGZGUzFlWUJXT1EvQnRNcWdLS1JWWElF?=
 =?utf-8?B?NDZNa2orQk15c1VER2FOeDJmL0lOYS9xdDY4UWpRaFdPTGhOc0Mwc3BMT2cx?=
 =?utf-8?B?ZWplSjJ5OU1Za1RBcHpweHhnY1p1U1BuVTNsQmdJY1dueFRGOWFrMjdyY0pT?=
 =?utf-8?B?SVI5RFhiMXViQy9kRERHSlQyMDJnb0RlNVVnNG5uTXZhSWxLbzlnd25iWHVE?=
 =?utf-8?B?bUtxeHoyclZpVmppV3pDUUFUaE01dUwrazVBZDJtMzQ2aWI4MXhsL0RTYzYz?=
 =?utf-8?B?WDZBQUpNdnlKMFB2UEM2QmFmcnBhck5LSkkxVWF2S3VwVG1hdC95Q1VqOUFL?=
 =?utf-8?B?akRlM3prUm5JWHJ5ZnpRd1BBMnhxZVJ3SlQ1bjczeTFQYU5JZ0xMS01URGMr?=
 =?utf-8?B?eTkzSFpJQ2VFQTd2aDUwVXNlNFdPWCtVTmdYMXZlekQxU00zR1NkVmJ6MUtt?=
 =?utf-8?B?NTdONWVQcVp3MWxEeG1XemlabFlOOU9PTERvUlFWTzU1cldlcnFIeFpiL0lK?=
 =?utf-8?B?N1EyR2pFQzNyc2V2cUJ3Z0RmVDdycXNGWkEydjZIVnFIYVAzbm1hNFk3VStn?=
 =?utf-8?B?RS95ZytOeklRbWM5MnFsQktONFE0UUI3M1l3Mnp5Y2UvUmk0U0VnWmI4alB0?=
 =?utf-8?B?SFBJbmFKbXhwSHpmaXpLUHY1M3pLV3NjaDE3aTl0bW40UzdybmpVN0NEeXdj?=
 =?utf-8?B?UzdwNVRSN2ZiTE16OGM3TnhjZC9JMnhQaHhFTjRYc2NNYnhZWmtmVlZDWjJZ?=
 =?utf-8?B?anhmR2tnNk9tMmUxTkpFQy9Na1Q3bWRZNkdBd1NJdEJJNUcvVVJ3eW9TMGVn?=
 =?utf-8?B?dW5kUWtuZlc2VmtiZmFvYWszaUdjSHlleUF6bEFKZmNaZXFOR2UrY1hIdFV1?=
 =?utf-8?B?NGphTXpxQnBLVVhyWjhWY1BBNWdJUjdlcEZtVnc2YTlTeVZrMGNUUVF6TEgy?=
 =?utf-8?B?M2p4U3RKOXBTZjdVbk9LU0tzN3ROdzA0Y0NZNnYvb3BBTU9wcVRuOHJwSXRF?=
 =?utf-8?B?ZFdkcm9hOC82RWVLdEo2dmhpdHRUelp3TWlKYWRwUGt1UjVtM2EwdEZiby9O?=
 =?utf-8?B?cTRqRElnTFNZQzRTYUEzaCs5aTE0dFpYVjdpbGlTYVdZZEMyUlNQUGFVck5W?=
 =?utf-8?B?RkNxVnp2VEYzS2U3VEp3K1llb0QvdG43QUdvREhwTlRXVkhpRVVLaHpGYWx4?=
 =?utf-8?B?dk5EVGN4bGNKUHByU2RkTzBRT25lYXp0MmtFQmN4bnQwV3lQYW9sVitWQWNx?=
 =?utf-8?B?V09pSnZaMXQyaHRTVkdkalNJQWUxZzFueEkvMzBFaGxmNi9hNGNIbys0YWR1?=
 =?utf-8?B?WkhtYnF3N2l5bEE3RHFZUmJtdW9udXQ1ZnJjamF1bjZway9QQ1ZrRXYxeEVl?=
 =?utf-8?B?M2c0RVp2VHY1QVZaeXFXdFdrRmM4WVlxUG5RYnpzd0Q3R080V1crWHdKNFNx?=
 =?utf-8?B?YzlIUExBOUFHYloyTzBPbHovd1ZNNFdvcGhVOWIvN1p2RkhzWVhYYU5NUllo?=
 =?utf-8?B?RE12TUdpVnhyNUh1OGNOMUtFVnJmT2E0K3hzc201NGE5bGd3WmxJeTFPRzBj?=
 =?utf-8?B?emRmd21oeklxTGloa2prOEdGSzl0Y3NsTjdCTVpoRXlQeFBSaFU0U0hjUThL?=
 =?utf-8?B?NkNtcUM4c0VvRGtmeHF2Q0FQQTByay9yWWpMMGFoUDI3aFpFTVVCMklQRk4y?=
 =?utf-8?B?M3Zoa0F2WGdRY204TVFCWEs0Sk1MRm1VSjdYNmNwa0N1eE9pNUpOZGF5Y21F?=
 =?utf-8?B?b1VOaXVpN3JyWkJlV0xGdE1MQTE5TlBUd3dqaEZycEJYK3djVHVDVHl0cFcw?=
 =?utf-8?B?d1pxOVpRZHN4Und3ZGcxN0U4RVZ6a0JIYjI2R3BkMStndlRNd3V4bWp0Y3dM?=
 =?utf-8?B?M0E5NU5JZENJTmZsZUNXYUp1M3FuSU1qSUJrdXdXYm94dkJJb1RxWGd1WURn?=
 =?utf-8?Q?rTBFC1lvvnNlh/fO5ODyx2n9b?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a6b1a5ab-9a2e-47e2-fa47-08dc38af8185
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 22:49:22.4815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ozqLC87r0Xpr397db3i+ymD3K25qbZQajYId93LhVpgBKgQB8auxk1RhZu9CZNC7p0qK3MqVRuzuTCzLhLHew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8235
X-OriginatorOrg: intel.com


On 26/02/2024 9:25 pm, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
> 
> This patch fixes the following warnings.
> 
>     In file included from arch/x86/kernel/asm-offsets.c:22:
>     arch/x86/include/asm/tdx.h:92:87: warning: shift count >= width of type [-Wshift-count-overflow]
>     arch/x86/include/asm/tdx.h:20:21: note: expanded from macro 'TDX_ERROR'
>     #define TDX_ERROR                       _BITUL(63)
> 
>                                             ^~~~~~~~~~
> 
> Also consistently use ULL for TDX_SEAMCALL_VMFAILINVALID.
> 
> Fixes: 527a534c7326 ("x86/tdx: Provide common base for SEAMCALL and TDCALL C wrappers")

+Kirill.

This kinda fix should be sent out as a separate patch.

> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> ---
>   arch/x86/include/asm/tdx.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
> index 16be3a1e4916..1e9dcdf9912b 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -17,9 +17,9 @@
>    * Bits 47:40 == 0xFF indicate Reserved status code class that never used by
>    * TDX module.
>    */
> -#define TDX_ERROR			_BITUL(63)
> +#define TDX_ERROR			_BITULL(63)
>   #define TDX_SW_ERROR			(TDX_ERROR | GENMASK_ULL(47, 40))
> -#define TDX_SEAMCALL_VMFAILINVALID	(TDX_SW_ERROR | _UL(0xFFFF0000))
> +#define TDX_SEAMCALL_VMFAILINVALID	(TDX_SW_ERROR | _ULL(0xFFFF0000))
>   
>   #define TDX_SEAMCALL_GP			(TDX_SW_ERROR | X86_TRAP_GP)
>   #define TDX_SEAMCALL_UD			(TDX_SW_ERROR | X86_TRAP_UD)

Both TDX guest and TDX host code depends on X86_64 in the Kconfig.  This 
issue seems due to asm-offsets.c includes <asm/tdx.h> unconditionally.

It doesn't make sense to generate any TDX related code in asm-offsets.h 
so I am wondering whether it is better to just make the inclusion of 
<asm/tdx.h> conditionally or move it the asm-offsets_64.c?


Kirill what's your opinion?

Btw after quick try seems I cannot reproduce this (w/o this KVM TDX 
patchset).  Isaku, could you share your .config?