Received-SPF: pass (google.com: domain of linux-kernel+bounces-85830-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f0a90f14993aa0fddb87e658be43341b.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240214073318.82573-1-duoming@zju.edu.cn>
References: <20240214073318.82573-1-duoming@zju.edu.cn>
Subject: Re: [PATCH] clk: zynq: Prevent null pointer dereference caused by kmalloc failure
From: Stephen Boyd <sboyd@kernel.org>
Cc: mturquette@baylibre.com, michal.simek@amd.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Duoming Zhou <duoming@zju.edu.cn>
To: Duoming Zhou <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Date: Wed, 28 Feb 2024 15:07:05 -0800
User-Agent: alot/0.10

Quoting Duoming Zhou (2024-02-13 23:33:18)
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index 7bdeaff2bfd..7621c2f0046 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -427,7 +427,7 @@ static void __init zynq_clk_setup(struct device_node =
*np)
>                         SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock);
> =20
>         tmp =3D strlen("mio_clk_00x");
> -       clk_name =3D kmalloc(tmp, GFP_KERNEL);
> +       clk_name =3D kmalloc(tmp, GFP_KERNEL | __GFP_NOFAIL);

Just make a stack variable please. __GFP_NOFAIL is a bad code smell.

>         for (i =3D 0; i < NUM_MIO_PINS; i++) {
>                 int idx;
>