Received-SPF: pass (google.com: domain of linux-kernel+bounces-85834-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240228-tidss-dev-err-probe-v1-1-5482252326d3@redhat.com> <8734tcnt7y.fsf@minerva.mail-host-address-is-not-set>
In-Reply-To: <8734tcnt7y.fsf@minerva.mail-host-address-is-not-set>
From: Enric Balletbo i Serra <eballetb@redhat.com>
Date: Thu, 29 Feb 2024 00:11:59 +0100
Message-ID: <CALE0LRvUMQmMv57UQNncrDFZu=ucmOuSXZNCaJ-10VTFjvenvQ@mail.gmail.com>
Subject: Re: [PATCH] drm/tidss: Use dev_err_probe() over dev_dbg() when
 failing to probe the port
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Andrew Halaney <ahalaney@redhat.com>, Jyri Sarha <jyri.sarha@iki.fi>, 
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>, 
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, 
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Andrew,

Many thanks for proposing this.

On Wed, Feb 28, 2024 at 11:02=E2=80=AFPM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Andrew Halaney <ahalaney@redhat.com> writes:
>
> Hello Andrew,
>
> > This gets logged out to /sys/kernel/debug/devices_deferred in the
> > -EPROBE_DEFER case and as an error otherwise. The message here provides
> > useful information to the user when troubleshooting why their display i=
s
> > not working in either case, so let's make it output appropriately.
> >
> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> > ---
> > There's definitely more spots in this driver that could be upgraded fro=
m
> > dev_dbg() to something more appropriate, but this one burned me today s=
o
> > I thought I'd send a patch for it specifically before I forget.
> > ---
>
> Makes sense to me and I agree that's useful to have that information ther=
e.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>

Logging in  /sys/kernel/debug/devices_deferred was useful for me, so

Tested-by: Enric Balletbo i Serra <eballetbo@kernel.org>

Cheers,
  Enric

> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>