Received-SPF: pass (google.com: domain of linux-kernel+bounces-85845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v2] x86/mtrr: Check if fixed MTRRs exist before saving them
In-Reply-To: <20240110150806.22531-1-ak@linux.intel.com>
References: <20240110150806.22531-1-ak@linux.intel.com>
Date: Thu, 29 Feb 2024 00:26:26 +0100
Message-ID: <87edcw8925.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Jan 10 2024 at 07:08, Andi Kleen wrote:
> This one place forgot to check the fixed capability.

This one place forgot? And what the heck is a fixed capability? 

> Otherwise there will a harmless but ugly WARN_ON for the failed WRMSR
> when the MSR doesn't exist.

This is not a sentence as it lacks a verb,

Also it does not matter whether you think that the WARN_ON() is ugly or
not. Can you please write a changelog in technical terms?

> Noticed when testing X86S support.

Who cares?

> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")

This fixes tag is pointlessly truncated. The correct one is:

Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before booting an AP")

It's not rocket science to copy & pasta correctly.

Thanks,

        tglx