Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp165761rbe; Wed, 28 Feb 2024 16:12:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUtpb8ZM5UKS3Hb8OO2U5hpO9vfEdDs0FIaPKfkEArNGmW/4ZoY3us+t2NP18lpBUSj/wH5oypPNEI0Bmi/RyfRSrHS7mHkhxCj5be7mw== X-Google-Smtp-Source: AGHT+IG9wb4V0bq2KmQTRqMhQBG4ee5MmMgOhK+NQxIk8sKzDqm23WMoiw3+jwz7HzSPnx3Zkc5G X-Received: by 2002:a05:620a:24c7:b0:787:eb87:25e7 with SMTP id m7-20020a05620a24c700b00787eb8725e7mr498737qkn.30.1709165530887; Wed, 28 Feb 2024 16:12:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709165530; cv=pass; d=google.com; s=arc-20160816; b=IVAaP6NztOJ72MEuc6XaymG8y6HvmQOfAuezpohHkTwygk9Xvyy/JFQ1EENyehGGa+ h/mrUJldakMKiEmHLvl8VLqKdbLcOANs/Vb+MgXEc6NSwfOMtz/2nPFKvyle8WXA1bMM xw6cu/7GAU8HLn9Xil1s7fJk6Scds5vRgoU5GS1SNjS/rtWZ9rxO0SDXgquFlwQM5kUZ CFvcnxJb+x/gwo0v3YKUUpsnvTqKWzAimVhficPorbRi1BsxUkO4YjMb4bDSAxI5e0aB NRb3vqBGEbY9Pkbh82YqBaGDICirDTyst7Nk/wSu1s7GmHOt3GDLYuDG5i0zfl/3OT6/ kckQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=LDJCC42hu8Gmc7pu6OgIYhxkZ37iuyJ7s773J5Mvt8M=; fh=ta7HX2H218sANQBNTnTGD11KRcq3Cd2gLKTdqexirrc=; b=KWDWoxB2p6ynB6uK/wuczLkDrJuIrKZDAEpsHEPHMFlzO9f3tDfi/mO7Rz+LVIjz5i pvDBlv3iK47sOeTTEhRcekPuViGMpVRZgWaUfB8qPgBuxW45gkIWfFXaL/al7ap6RX1S goeMFsApKaSjBmfl5sdoxZYHBCYkYUkMnFhObWA2P9F70y/lq3At6cERfuAKKrrGKVZ4 kmMRhlyMr3dne2UPlndkd9vJB54XH66/4qrGNQ76q+3mldLYFLASQ0QyFjypzxOTbv7m ulQ1GJqnNyrXOzcWifryZYTRb9T1VZ9RT3lMeJ21z250hrLjqB+yFVBQyP+kdIbFTBID h3dA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-85871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85871-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g3-20020ac87d03000000b0042eb3c9133dsi331574qtb.98.2024.02.28.16.12.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 16:12:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-85871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85871-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A298B1C21051 for ; Thu, 29 Feb 2024 00:12:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78E1623CA; Thu, 29 Feb 2024 00:12:05 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BBE15C3 for ; Thu, 29 Feb 2024 00:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709165524; cv=none; b=qyFe86zvS6fiU2/YtKlBgzMaUzj9vl9ibuzIsO5D28fomhljgE20wyg2qM+Z48St7mbZ/15ZitaPyO5WHPDZWhXAa59if8bFzCFUZ2h5dfciLQNpWZ/SPUpPxXHn9gcF3Bn8fDqlD4lXjDnjswTgLO93kbkTzORRV6ubpUjY1LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709165524; c=relaxed/simple; bh=N6YGuaJ74E7TWcJgDpeFOe4+YYQa16bTIgjQ4usJsg8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kUQUX9FUmmV0VbkOmLoCO51SqGT/aqord5ryX7207KVpQzZJwzgzPsCm7+jAXJ9MYVQURghPlbvRiFr1TXE9UwnPZZhsiInsdI0NckeCC7tC+D8acgq4t13Y3Yu6d51v14KPq7d7jz5UEg8rkFn7WY5NohtTMP7ssBobKJ2H2UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B81C8C433F1; Thu, 29 Feb 2024 00:12:01 +0000 (UTC) Date: Wed, 28 Feb 2024 19:14:06 -0500 From: Steven Rostedt To: Josh Poimboeuf Cc: Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Vince Weaver , Dave Jones , Jann Horn , Miroslav Benes , Andy Lutomirski , Thomas Gleixner , Masami Hiramatsu , Nilay Vaish Subject: Re: [PATCH v2 06/11] x86/unwind/orc: Convert global variables to static Message-ID: <20240228191406.21e894b0@gandalf.local.home> In-Reply-To: <20240229000309.ibtuk7gr27d7cbxz@treble> References: <43ae310bf7822b9862e571f36ae3474cfde8f301.1587808742.git.jpoimboe@redhat.com> <20240228183507.78c5f130@gandalf.local.home> <20240229000309.ibtuk7gr27d7cbxz@treble> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 28 Feb 2024 16:03:09 -0800 Josh Poimboeuf wrote: > On Wed, Feb 28, 2024 at 06:35:07PM -0500, Steven Rostedt wrote: > > On Sat, 25 Apr 2020 05:03:05 -0500 > > Josh Poimboeuf wrote: > > > > > These variables aren't used outside of unwind_orc.c, make them static. > > > > > > Also annotate some of them with '__ro_after_init', as applicable. > > > > So it appears that crash uses "lookup_num_blocks" to be able to do > > back-traces with the ORC unwinder. But because it's now static, crash can no > > longer do that. > > Hm, but why? Even a static variable has a known address. > I'm guessing because we don't have the full dwarf info? -- Steve