Received-SPF: pass (google.com: domain of linux-kernel+bounces-85931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <72fc647f-b9e3-4839-9529-dffa2d0bf6a9@intel.com>
Date: Wed, 28 Feb 2024 16:39:40 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/mce: Dynamically size space for machine check records
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
CC: "Naik, Avadhut" <avadnaik@amd.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>, Avadhut Naik
	<avadhut.naik@amd.com>
References: <20240212093246.GBZcnlvkPKDC8C7rv5@fat_crate.local>
 <SJ1PR11MB6083B3511D18787BE823AB2CFC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20240212175408.GIZcpbQHVjEtwRKLS-@fat_crate.local>
 <SJ1PR11MB60830AF35FA89C7869B8C11EFC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20240212191401.GLZcpt-XHFqPg3cDw-@fat_crate.local>
 <SJ1PR11MB6083C60D7584B02E9CAF19D5FC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <ZcqPhVO_DtD2x5N7@agluck-desk3>
 <20240212220833.GQZcqW4WxKH34i-oBR@fat_crate.local>
 <20240212221913.GRZcqZYRd6EPTTnN97@fat_crate.local>
 <20240212224220.GSZcqezMhPojxvIcvO@fat_crate.local>
 <Zd--PJp-NbXGrb39@agluck-desk3>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <Zd--PJp-NbXGrb39@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUtNQTBmczR3Wm95OExtSGJQRDQ2UkNHdUkvd0xVUHpDS1FUWjRac3NHT0h0?=
 =?utf-8?B?UzlyMzEvd29uNjZqMFJqdEtLMDdDRkR4NUVvUFJvRlo3UUVWSTRtTEowUmpp?=
 =?utf-8?B?enJzaEdIUVBDRzFjV0xiNlhsUXFKTy8zaTRiVE1iUUx0bk5jaFh5T3Z1UXYv?=
 =?utf-8?B?RUVFaVJrRi9KUkFwMkt3SDJDZzBORW52eHBQRHBKR1kvaGluSTFpOHpIVERS?=
 =?utf-8?B?TWROQm1OWWd1WEsxc2JhOExrU2MxM0lraG5DTEk5L01uUTZiTVRyWStmaC96?=
 =?utf-8?B?K2JmTGtrQnFYZGltbldTSjhvR0Z1SHNrbkdsR1hGcjVlY0NxeW9ndlpQZ1RO?=
 =?utf-8?B?NkNPRUdOQzlneE9ocFNXRG1nYitkMmxyM01zd1JnOWlldkJzTXlzOExZZjFE?=
 =?utf-8?B?ejBGa1lHd2prek5MWnIyOWk2bHZmeDRvRzNoMG83aTQyNFpSUEJGaUFsRUtp?=
 =?utf-8?B?c2ZCODY3ditad1c5WHBwblQ1OWZPdU1LNjhVdXR3QzJBS3pOSnA4dXRWSW94?=
 =?utf-8?B?UnVXSjlVZ1F4OUdISGdVOWg4VW5hRFZndHBzTExXdENwTStLZDJFVC9OekJP?=
 =?utf-8?B?REMvcDhEN3JZcUpVVGFuUTR2RHhweVRUaXBVUVZiY0F3aXdLUFo4WThRUUNa?=
 =?utf-8?B?dExJdXFTR09kVXZpMkY0MWRKVDFUb3BRRmw1Rkcyd1VSV1gwTGRqVmt6c1l5?=
 =?utf-8?B?ODRRc1pkdkI1akNLNURiMGxYOWVDLzllbjZMcDBxc2dWRUxUWWw5cXJEM0tm?=
 =?utf-8?B?MmVBdElUUmVCQmlKZ1l3dU1ZM2M0UHFTQjdPWEVvYWlSN2RsdGRJTkRaQ3dT?=
 =?utf-8?B?WFBiSnBnL05CRjFvUDRWQ2I3QVZtbWJBTjZidklTL0ZVY0lDaXljLy82aXY2?=
 =?utf-8?B?MGRacGRvK04zbWZlSWZKUXVxaVN0cDg1Nk5VSitaU2QyNW16ZmZ0U01pT1lC?=
 =?utf-8?B?QUx6a3hRdW1uczJFNDhHdis2RDY4dFhQNU1EY1RtZUw2a3lFMHZKQTR6Sm1r?=
 =?utf-8?B?bllPQjJTVCtqN2NpaDQrTmFJSzlyZHRsT3pPaXZ5KzNzZGhuSkx6V3h3SGs0?=
 =?utf-8?B?Qm9TQ2xmU2FZWlNSd0hiNmloMGRkeStiRVgxbHRRdXhBaFhUN1VNaW5FMXFM?=
 =?utf-8?B?cVJsVE5zbVJtUHpyMW1nbm1EenI1Q05IdGlDYytiZzVjRldYVzZvVGlDMjUz?=
 =?utf-8?B?M08rSk8wZi9YYTJKRjlUK3NKN0Z4dnVSajZPb3lybFkvdmZEQk40OVdkS3Nx?=
 =?utf-8?B?MDBucGdtTFpTQUdDaGFjY0RvZmNDQ0xqYW9ST1ZUaE1IOTBIQ3FackR0aVBF?=
 =?utf-8?B?NDNyYm44NGsrVGg4Wis5eGtvZW9pTWt1WDZiTW1RcUJEdlc3aGdPMlZPODNS?=
 =?utf-8?B?V3NzQ0Z5MEZFLzNGMVY3VUF3YWNoWG13V2VyZExEMGlMZHpUUXQ4STVIa2hQ?=
 =?utf-8?B?aDFxUEljRmFCUzd3WkJ3MGNEYVcwb01oOHVhRXVsQXFhR0ZDeGUwL08wUU80?=
 =?utf-8?B?emkxUkdQOEZrSnhMdGxIMy9Zdy9mVnJFYm5wMjVoQk92WjhOYkE5YmVzakJM?=
 =?utf-8?B?MjlEVkcwMHNCWlFCaGpQZklMOENGc1RrT3hYZnpVWlJtbHprMlRjZnFjZnVI?=
 =?utf-8?B?ZG4wNEczdGNwQjlaOFVIZSsxRzRlRGVhTWZoYnRTcnlOU0Z0amZPeEhBcnVG?=
 =?utf-8?B?ZkRmNTlyS1RSeWdhMDFkSWpWVTFkMmtNS2NFV1RIQlR0K1hYUnVoaE81LzNW?=
 =?utf-8?B?MU84VVZ1bys1WXdkVCttTHI3V2lwTkdxMzVhOEtFd2J6UEdNY1RZakd3TlVv?=
 =?utf-8?B?WnRUVEhEdHNwMGRSWi9Cc2pwbElMVVJBMTNiYU1ib3d3TGwwUDdYY2tIZGcy?=
 =?utf-8?B?MFBDL0szamNGYXRDallXcUtEb3VyS0Z3MHNoZ0xVYkR0aExUOG85UGV4WnZy?=
 =?utf-8?B?cFdoeVJySG5uamUwcEliUGpoa05BUVlKU01zY1NlTWdaWUlrUnZnaHpFY0wx?=
 =?utf-8?B?Q0NLVXRLOXJpbUtUdGJpNk5nSm5pQndTNHBPUlJQMjFVaWF6MVYvcTVCTGF3?=
 =?utf-8?B?ZXJSS2U4aFVFSGk1N1dkWmlIaVFsd3E4QVFHcjdOU2xYMUlWVTYzUENDNWJ4?=
 =?utf-8?Q?fRynrTwqLhlBGtTcPWre/QDWC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 66fdf6af-3069-482d-5422-08dc38beeb4c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 00:39:42.4390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUgbglHpP3J2YP80ksFUEpVpwpA8qZei9zxiwPGILUz4LZYZR12OOr2VYa9YaKjTzdJijWc6gWp2y/cS38GxLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5699
X-OriginatorOrg: intel.com

On 2/28/2024 3:14 PM, Tony Luck wrote:

>  static int mce_gen_pool_create(void)
>  {
> +	int mce_numrecords, mce_poolsz;
>  	struct gen_pool *tmpp;
>  	int ret = -ENOMEM;
> +	void *mce_pool;
> +	int order;
>  
> -	tmpp = gen_pool_create(ilog2(sizeof(struct mce_evt_llist)), -1);
> +	order = ilog2(sizeof(struct mce_evt_llist)) + 1;
> +	tmpp = gen_pool_create(order, -1);
>  	if (!tmpp)
>  		goto out;
>  
> -	ret = gen_pool_add(tmpp, (unsigned long)gen_pool_buf, MCE_POOLSZ, -1);
> +	mce_numrecords = max(80, num_possible_cpus() * 4);
> +	mce_poolsz = mce_numrecords * (1 << order);
> +	mce_pool = kmalloc(mce_poolsz, GFP_KERNEL);
> +	if (!mce_pool) {
> +		gen_pool_destroy(tmpp);
> +		goto out;
> +	}
> +	ret = gen_pool_add(tmpp, (unsigned long)mce_pool, mce_poolsz, -1);
>  	if (ret) {
>  		gen_pool_destroy(tmpp);

Is this missing a kfree(mce_pool) here?

>  		goto out;