Received-SPF: pass (google.com: domain of linux-kernel+bounces-85933-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 28 Feb 2024 16:42:52 -0800
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, x86@kernel.org,
	linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Vince Weaver <vincent.weaver@maine.edu>, Dave Jones <dsj@fb.com>,
	Jann Horn <jannh@google.com>, Miroslav Benes <mbenes@suse.cz>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Nilay Vaish <nilayvaish@google.com>
Subject: Re: [PATCH v2 06/11] x86/unwind/orc: Convert global variables to
 static
Message-ID: <20240229004252.awmammhp63f5udyy@treble>
References: <cover.1587808742.git.jpoimboe@redhat.com>
 <43ae310bf7822b9862e571f36ae3474cfde8f301.1587808742.git.jpoimboe@redhat.com>
 <20240228183507.78c5f130@gandalf.local.home>
 <20240229000309.ibtuk7gr27d7cbxz@treble>
 <20240228191406.21e894b0@gandalf.local.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240228191406.21e894b0@gandalf.local.home>

On Wed, Feb 28, 2024 at 07:14:06PM -0500, Steven Rostedt wrote:
> On Wed, 28 Feb 2024 16:03:09 -0800
> Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> 
> > On Wed, Feb 28, 2024 at 06:35:07PM -0500, Steven Rostedt wrote:
> > > On Sat, 25 Apr 2020 05:03:05 -0500
> > > Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > >   
> > > > These variables aren't used outside of unwind_orc.c, make them static.
> > > > 
> > > > Also annotate some of them with '__ro_after_init', as applicable.  
> > > 
> > > So it appears that crash uses "lookup_num_blocks" to be able to do
> > > back-traces with the ORC unwinder. But because it's now static, crash can no
> > > longer do that.  
> > 
> > Hm, but why?  Even a static variable has a known address.
> > 
> 
> I'm guessing because we don't have the full dwarf info?

DWARF isn't needed for that.  Even the symbol table has it (as does
System.map).  For both globals and statics.

-- 
Josh