Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp189934rbe; Wed, 28 Feb 2024 17:15:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXkapIHEkCfrHgnztNtg9sMg6AWgKFxedkQCgdNZvCSn4zgZXhDlI1Spbc0e+eAVvDxUEXrEtXO3KbSGwWZrlHPpeXUUilGxo4S3SakJA== X-Google-Smtp-Source: AGHT+IGVncjonSryvxxoiCTxkw4quhUaH72pYZmo2fmMUQQoB0DhvWUzLhIzvDm5uogyacGyPtpu X-Received: by 2002:a19:c212:0:b0:513:22a2:4052 with SMTP id l18-20020a19c212000000b0051322a24052mr334052lfc.2.1709169324474; Wed, 28 Feb 2024 17:15:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709169324; cv=pass; d=google.com; s=arc-20160816; b=0AfUWs4IF5GbtwoJntIveM27uW5g+Uuf6apkKhn8PSPHXEf4Gq5935GouHBoA5hd3f y38423oUs5hOFawQ8dEfRJR2mGpBha4t79gA5VlcGC6JDsmU7hushgtkb0/+KRu5W2EZ Au1Bs+HoeukLPVdI+Qt/APs+Nk5tfuqhGn+I7Px6m3/UYBoFqrn/pGU5j+FQeThSLK4m bQySySKxIX9Xahl74vPu9rF6jJgV9brD5MEx6xcRysP/1dgZVKHAOlAd03JzGP3l0Lf6 EYtmuJSFKNjKF2UcuyFzTGd7u0TEoqGdYfktRo7TqTicp6oTGhcWj8rXnuex+lL3QwLy saNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=wLig2d2LSHF42w+1na7/0WteNrvql3l9fGL17gHJecY=; fh=3x8ZiP89S/kOM43N1p/VDOwd/9CeM6vZj15tFE5f/z0=; b=bE7wy0STKp2DifgfmEZLJwVryL7Dh6jWAoSxVHOaZbiOZeZDbjz3PdbRXVlVCG6k9M QtAnQ5Syp0Q9nR7B1EDV4+1VjaVjWWqB5tba6FWT0Y3CCQYxB1P6xOLgbe29qyN7G6ki DFvlQnTJAJL83Drkt2C+Ig5KEUSkaP5UmI6ooXglpLL+11RiMjKfZ3Nl4lmSkTZIp6dX /1anv3SD3dgbefomrFnMlPigm/s4sf3lsXFhH/Jw2UVD6OgZDozmEh6kxupehAUZF0qX myRVAr4uN/76dCgiW2cEHQi5bHWmInG+c88cy/rZB3xqQNCnyTvZ5tlSzmN6wTr/dEpX yvfQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F2Xeh2Ru; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qx6-20020a170906fcc600b00a43db2e1acbsi91569ejb.351.2024.02.28.17.15.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 17:15:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F2Xeh2Ru; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-85990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 17EB21F2BDE5 for ; Thu, 29 Feb 2024 01:15:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A8B8A2E62C; Thu, 29 Feb 2024 01:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F2Xeh2Ru" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B32E122612; Thu, 29 Feb 2024 01:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709169311; cv=none; b=NyEr9AqRXn/URPQHCHc+ZG2V5BMYyGbn73VdRPL10DpkN70hJRKTskxUgmNf5GGXrzazAuOEBKqQUo6s8Ym9ypgRR2hcc0xFiv+J19GFIRbNsS/LhuQSs+i/bt4DE+UVN+ST0Bbu6c5jxgLrR131r18nzBNGSumhUSxCkhZWgwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709169311; c=relaxed/simple; bh=z7f+Dbb4dDt0wPU1cnaBodq/Wil5VeJE1ycdq0aUaq8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pDkiRWivDVTSmDqoXvZxLqJQwLO77dMlNE2pGqA5fEpSzz4Efh54+SXM4U+79e4kmDFBAirwdN/urZLMuJ7qdJesczDLVVzXqRz4Rr2jiSo0K1xfjovhjhXrBVTwb62Bjiki9/gNugFZjt7bKmUBm/GLK87BEHJ4pNkJK+EiWtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F2Xeh2Ru; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55633C433F1; Thu, 29 Feb 2024 01:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709169311; bh=z7f+Dbb4dDt0wPU1cnaBodq/Wil5VeJE1ycdq0aUaq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F2Xeh2RubzK3AW7IcsJ8JguT0FCtBPq8dwfnSFWlufbMmVlY2g3+MfMfEM01Bh2MK z5ccVI4tykZjoiO95oQ0dYg7GIlCTWyTi1Up81i0EuRKMYHvTR5n3W7fN8QXupphte kmZSklRhuYvDXiSRo1BgmiYdzVRKbBrx4t+PIIvHBN+xtBaQAxt7uzmGk7tFXnlgbQ 052q7dyS0vKRTmZlh2lrVMMEfladfdH9F25NkO8VShL0ha5ZC7/vJ16RoBIsVmThjH YyDT8eVuI7JTTNXRsjZH4swfQGnpZIb+u7GFjMp/lsSh4GmDwDnJwY36VOmwmY+KzH ictO3oxeNV89g== Date: Wed, 28 Feb 2024 17:15:09 -0800 From: Jakub Kicinski To: "Gustavo A. R. Silva" Cc: Kees Cook , Andy Shevchenko , Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: <20240228171509.4eeb5519@kernel.org> In-Reply-To: <49f55b02-ce21-40ac-a4cc-02894cd5eb8f@embeddedor.com> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> <20240228144148.5c227487@kernel.org> <202402281554.C1CEEF744@keescook> <653bbfe8-1b35-4f5e-b89d-9e374c64e46b@embeddedor.com> <20240228165730.3171d76c@kernel.org> <49f55b02-ce21-40ac-a4cc-02894cd5eb8f@embeddedor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 28 Feb 2024 19:03:12 -0600 Gustavo A. R. Silva wrote: > On 2/28/24 18:57, Jakub Kicinski wrote: > > On Wed, 28 Feb 2024 18:49:25 -0600 Gustavo A. R. Silva wrote: > >> struct net_device { > >> struct_group_tagged(net_device_hdr, hdr, > >> ... > >> u32 priv_size; > >> ); > >> u8 priv_data[] __counted_by(priv_size) __aligned(NETDEV_ALIGN); > >> } > > > > No, no, that's not happening. > > Thanks, one less flex-struct to change. :) I like the flex struct. I don't like struct group around a 360LoC declaration just to avoid having to fix up a handful of users.