Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756814AbYACFrH (ORCPT ); Thu, 3 Jan 2008 00:47:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751720AbYACFqy (ORCPT ); Thu, 3 Jan 2008 00:46:54 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:34399 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbYACFqw (ORCPT ); Thu, 3 Jan 2008 00:46:52 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type:content-disposition:user-agent; b=xJgMA8iw6zRqWJVJZdoyAmgyWDHT8L4OsMYNyM1zB13UrG6yPGmhh/pL2JQfEXENGXHr6AiTdkkS12+PDD0VWxfhMd65R049YWRtStQg0ioE5OQxqJNKoo7YqHIJqnUMfFwASEO/rVKttHX7Cfo3gd4TSnrY/Yx9uvM/+/wUnF4= Date: Thu, 3 Jan 2008 13:50:20 +0800 From: Dave Young To: gregkh@suse.de Cc: stern@rowland.harvard.edu, peterz@infradead.org, david-b@pacbell.net, davem@davemloft.net, jarkao2@gmail.com, krh@redhat.com, stefanr@s5r6.in-berlin.de, dbrownell@users.sourceforge.net, James.Bottomley@HansenPartnership.com, a.zummo@towertech.it, cbou@mail.ru, dwmw2@infradead.org, khali@linux-fr.org, i2c@lm-sensors.org, linux1394-devel@lists.sourceforge.net, spi-devel-general@lists.sourceforge.net, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH 0/7] convert semaphore to mutex in struct class Message-ID: <20080103055019.GA4885@darkstar.te-china.tietoenator.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4059 Lines: 74 Convert semaphore to mutex in struct class. All the patches in this series should be applyed simultaneously toc: --- 1-driver-core-struct-class-convert-semaphore-to-mutex.patch 2-i2c-struct-class-convert-semaphore-to-mutex.patch 3-ieee1394-struct-class-convert-semaphore-to-mutex.patch 4-power-struct-class-convert-semaphore-to-mutex.patch 5-rtc-struct-class-convert-semaphore-to-mutex.patch 6-scsi-struct-class-convert-semaphore-to-mutex.patch 7-spi-struct-class-convert-semaphore-to-mutex.patch Summary diffstat: --- drivers/base/class.c | 22 ++++++++++---------- drivers/base/core.c | 13 +++++------- drivers/i2c/i2c-core.c | 9 +++----- drivers/ieee1394/nodemgr.c | 40 +++++++++++++++++++------------------- drivers/power/apm_power.c | 6 ++--- drivers/power/power_supply_core.c | 8 +++---- drivers/rtc/interface.c | 4 +-- drivers/scsi/hosts.c | 4 +-- drivers/spi/spi.c | 4 +-- include/linux/device.h | 3 +- 10 files changed, 56 insertions(+), 57 deletions(-) One lockdep warning detected as following, thus use mutex_lock_nested with SINGLE_DEPTH_NESTING in class_device_add Jan 3 10:45:15 darkstar kernel: ============================================= Jan 3 10:45:15 darkstar kernel: [ INFO: possible recursive locking detected ] Jan 3 10:45:15 darkstar kernel: 2.6.24-rc6-mm1-mutex #1 Jan 3 10:45:15 darkstar kernel: --------------------------------------------- Jan 3 10:45:15 darkstar kernel: modprobe/2130 is trying to acquire lock: Jan 3 10:45:15 darkstar kernel: (&cls->mutex){--..}, at: [] class_device_add+0x140/0x240 Jan 3 10:45:15 darkstar kernel: Jan 3 10:45:15 darkstar kernel: but task is already holding lock: Jan 3 10:45:15 darkstar kernel: (&cls->mutex){--..}, at: [] class_interface_register+0x43/0xf0 Jan 3 10:45:15 darkstar kernel: Jan 3 10:45:15 darkstar kernel: other info that might help us debug this: Jan 3 10:45:15 darkstar kernel: 1 lock held by modprobe/2130: Jan 3 10:45:15 darkstar kernel: #0: (&cls->mutex){--..}, at: [] class_interface_register+0x43/0xf0 Jan 3 10:45:15 darkstar kernel: Jan 3 10:45:15 darkstar kernel: stack backtrace: Jan 3 10:45:15 darkstar kernel: Pid: 2130, comm: modprobe Not tainted 2.6.24-rc6-mm1-mutex #1 Jan 3 10:45:15 darkstar kernel: [] show_trace_log_lvl+0x1a/0x30 Jan 3 10:45:15 darkstar kernel: [] show_trace+0x12/0x20 Jan 3 10:45:15 darkstar kernel: [] dump_stack+0x6d/0x80 Jan 3 10:45:15 darkstar kernel: [] print_deadlock_bug+0xc7/0xe0 Jan 3 10:45:15 darkstar kernel: [] check_deadlock+0x6c/0x80 Jan 3 10:45:15 darkstar kernel: [] validate_chain+0x14c/0x370 Jan 3 10:45:15 darkstar kernel: [] __lock_acquire+0x1c0/0x7e0 Jan 3 10:45:15 darkstar kernel: [] lock_acquire+0x79/0xb0 Jan 3 10:45:15 darkstar kernel: [] mutex_lock_nested+0x8c/0x300 Jan 3 10:45:15 darkstar kernel: [] class_device_add+0x140/0x240 Jan 3 10:45:15 darkstar kernel: [] class_device_register+0x12/0x20 Jan 3 10:45:15 darkstar kernel: [] class_device_create+0x9a/0xb0 Jan 3 10:45:15 darkstar kernel: [] sg_add+0x12c/0x200 [sg] Jan 3 10:45:15 darkstar kernel: [] class_interface_register+0xd9/0xf0 Jan 3 10:45:15 darkstar kernel: [] scsi_register_interface+0xf/0x20 Jan 3 10:45:15 darkstar kernel: [] init_sg+0x82/0xbc [sg] Jan 3 10:45:15 darkstar kernel: [] sys_init_module+0xea/0x130 Jan 3 10:45:15 darkstar kernel: [] syscall_call+0x7/0xb Jan 3 10:45:15 darkstar kernel: ======================= If there's anything missed please help to point out, thanks. Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/