Received-SPF: pass (google.com: domain of linux-kernel+bounces-86013-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 28 Feb 2024 17:51:58 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paolo Abeni <pabeni@redhat.com>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org"
 <netdev@vger.kernel.org>, Charlie Jenkins <charlie@rivosinc.com>, Palmer
 Dabbelt <palmer@dabbelt.com>, Erhard Furtner <erhard_f@mailbox.org>,
 Christophe Leroy <christophe.leroy@csgroup.eu>, "David S. Miller"
 <davem@davemloft.net>
Subject: Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs
Message-ID: <20240228175158.04c0aa1b@kernel.org>
In-Reply-To: <f0eeaab76d6386e22b88d9526ec7a53ae7e98ef5.camel@redhat.com>
References: <73df3a9e95c2179119398ad1b4c84cdacbd8dfb6.1708684443.git.christophe.leroy@csgroup.eu>
	<c434b94a-2072-4b74-a222-0906579a351e@csgroup.eu>
	<f0eeaab76d6386e22b88d9526ec7a53ae7e98ef5.camel@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 27 Feb 2024 10:06:41 +0100 Paolo Abeni wrote:
> On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
> > Hi,
> >=20
> > Le 23/02/2024 =C3=A0 11:41, Christophe Leroy a =C3=A9crit=C2=A0: =20
> > > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
> > > fixed endianness issues with kunit checksum tests, but then
> > > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
> > > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
> > > are once again reflected by the warnings reported by sparse.
> > >=20
> > > So, fix them with the same approach, perform proper conversion in
> > > order to support both little and big endian CPUs. Once the conversions
> > > are properly done and the right types used, the sparse warnings are
> > > cleared as well.
> > >=20
> > > Reported-by: Erhard Furtner <erhard_f@mailbox.org>
> > > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fas=
t_csum")
> > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> =20
> >=20
> > netdev checkpatch complains about "1 blamed authors not CCed:=20
> > palmer@rivosinc.com; 1 maintainers not CCed: palmer@rivosinc.com "
> >=20
> > Palmer was copied but as Palmer Dabbelt <palmer@dabbelt.com>. Hope it i=
s=20
> > not a show stopper. =20
>=20
> No, it's not.
>=20
> Acked-by: Paolo Abeni <pabeni@redhat.com>
>=20
> I *think* this, despite the subject prefix, should go via Andrew's tree
> to avoid conflicts.
>=20
> @Andrew does the above fits you?

I don't see this in linux-next, so unless told otherwise I'll merge it
and ship to Linus tomorrow.