Received-SPF: pass (google.com: domain of linux-kernel+bounces-86019-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 28 Feb 2024 17:55:42 -0800 (PST)
Subject:     Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs
In-Reply-To: <20240228175158.04c0aa1b@kernel.org>
CC: akpm@linux-foundation.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
  netdev@vger.kernel.org, Charlie Jenkins <charlie@rivosinc.com>, erhard_f@mailbox.org,
  christophe.leroy@csgroup.eu, davem@davemloft.net
From: Palmer Dabbelt <palmer@dabbelt.com>
To: kuba@kernel.org
Message-ID: <mhng-27f419e8-9551-4a63-a74a-cede3f9d2614@palmer-ri-x1c9>
Precedence: bulk
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On Wed, 28 Feb 2024 17:51:58 PST (-0800), kuba@kernel.org wrote:
> On Tue, 27 Feb 2024 10:06:41 +0100 Paolo Abeni wrote:
>> On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
>> > Hi,
>> > 
>> > Le 23/02/2024 à 11:41, Christophe Leroy a écrit :  
>> > > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
>> > > fixed endianness issues with kunit checksum tests, but then
>> > > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
>> > > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
>> > > are once again reflected by the warnings reported by sparse.
>> > > 
>> > > So, fix them with the same approach, perform proper conversion in
>> > > order to support both little and big endian CPUs. Once the conversions
>> > > are properly done and the right types used, the sparse warnings are
>> > > cleared as well.
>> > > 
>> > > Reported-by: Erhard Furtner <erhard_f@mailbox.org>
>> > > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
>> > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>  
>> > 
>> > netdev checkpatch complains about "1 blamed authors not CCed: 
>> > palmer@rivosinc.com; 1 maintainers not CCed: palmer@rivosinc.com "
>> > 
>> > Palmer was copied but as Palmer Dabbelt <palmer@dabbelt.com>. Hope it is 
>> > not a show stopper.  
>> 
>> No, it's not.
>> 
>> Acked-by: Paolo Abeni <pabeni@redhat.com>
>> 
>> I *think* this, despite the subject prefix, should go via Andrew's tree
>> to avoid conflicts.
>> 
>> @Andrew does the above fits you?
>
> I don't see this in linux-next, so unless told otherwise I'll merge it
> and ship to Linus tomorrow.

Sorry, I thought I'd Ack'd this at some point -- I might have just 
gotten lost, though, as IIRC there were a few of these floating around.

I'm fine with anyone taking it, so

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!