Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp207032rbe; Wed, 28 Feb 2024 18:05:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUS4NPzvw23xPx0iaCXRumtOPfWIHcHNbjC4PL7QesOnVVEYSeCCKkQQ5sfSFQEfHZePcnzlJzDAapisdPOqBMR+/QoVtzwbI/FGmKvoA== X-Google-Smtp-Source: AGHT+IF7H/jau2A7JIymtc5WEl4NK0hbbJrqUw/sEAJ1ripo4PhHGEk4VrgDX+Eaui25sH4C2TXT X-Received: by 2002:a05:620a:1922:b0:787:a9af:d6b8 with SMTP id bj34-20020a05620a192200b00787a9afd6b8mr1028914qkb.8.1709172341651; Wed, 28 Feb 2024 18:05:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709172341; cv=pass; d=google.com; s=arc-20160816; b=YzKru+VGuBu/2D7o4I6KxoxRvPYiptgpjLTR4GltwCt7xcycW1SMawDqe4OzcqLLfu /H8Fu1oVT9CFF9bpSXXe1QcvQ7gRV1YlZ3l7g8x5IoZoIiTtQsfEhak5m3VvbdLG0IUB wXSAPcFpkTnSXyE2SfPVYTfOG4GqOXY1XaWUlS24oLnom+wWyDBxsxYquQ26UQ/9Dkgx gLtZA0TpUAobwBT5pe5+o7hxdnUVSTHBmPdAMJZNuL9JCVPqFAa0oBspOjRzsqkf9UpZ 7atnYy12GXOsl0koL8cbZxUjeiR7qyUCCs4ZYhLt+DqKYO0ZFmLNeNqaotAE/VABaq+P fqMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Qz2OOU/JdR6NK2MwPjRQUbtsaykdIHeja0HRk/LuJuY=; fh=jVGxO+cvy6s1OS4Ri+7kWpAdt0FD7qpGWBTfLS2Uslc=; b=0FNA5eUu6/tkQkJfLbRbnYfZkChxOnMH8OQK5hbACwGVWIEeQQNAWQPHKYiqJM4G0k 6ZHHiJAL1h327GWSn0KFchFpdqaubBHqQHyEwkyR9Cq8Av/XxTopwCKURsLARk9uP0S1 GGEYRenAbc/6eoH9NC1FFJpU7pLFeDp4ZHWZMc8Pm6Q7JZqx+r0IRRWJchs96lzkQdHk N5urlpvtH3jdvqFPVPAarQ2DWhT84DTxXU0JcPZnS66vfc9hTR3Jsaw2bB7eFPygRlLZ xVRnMUpQVULrIyCPLk6Zobo4XNErXJEB0pGhIEe9eSyTon0mLMq1uAgh405tEaY+VT/o DuiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HZcCEcbJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-86027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86027-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id de17-20020a05620a371100b00787c5bfbf05si512428qkb.784.2024.02.28.18.05.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 18:05:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HZcCEcbJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-86027-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86027-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0FF341C229A7 for ; Thu, 29 Feb 2024 02:05:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A937B36AF9; Thu, 29 Feb 2024 02:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HZcCEcbJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB29E2D638; Thu, 29 Feb 2024 02:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709172322; cv=none; b=JlQAQCJTkV+ZA+qfOhiS+BkUTOE6QINKqL78f5wlxmMXCJ/OmRyvHXCpohmlVOMGWv0VBVEc2v4UtctHE1GBA50UGU3juvOdCwR6JdlMw8wmfFVl68vMg+xzYBKeHYCrgKBR6+inxl83Pk+Kptqls4e90K5hww6gbR8ZZXzhTGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709172322; c=relaxed/simple; bh=fqsiv75ue6xl6cHe9uXd44i3iEeE5fdO87JHWHg3h/I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cdvh3oG3sIo50g1A8e8ZoLN5bokgfdjF1ljQEiuqVXqPbxFlTvtpDta4OKlWte8SeLtLxxOf0r+2RjljnaxFdHNcSMKx+CzRNVN1z0g85eeZyqfPW2U/bf9czEkX5Ra+NJUo7E4siSGkfshQtjuJPEHpOsPRHQjYrfF/phF+yuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HZcCEcbJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 673F9C433C7; Thu, 29 Feb 2024 02:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709172322; bh=fqsiv75ue6xl6cHe9uXd44i3iEeE5fdO87JHWHg3h/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HZcCEcbJAOOVBYRh7frp3IJCZBT+4Fjgw86FcTURFeVoVjRPckBU//4A3xSyu0Oyy 5gxKhzQpa0K/LZdp3OS18OTxc2GVqywAYK+XKC8zXv7blaFE0HbaRiAs9+lPF31hZy L2FW0ixCzn2NOXp1AWcgBm52OPgJHfZVq0IHVGSyys683h2w4QXQerkrbqbsHpxGFI 3OOJVnwpRvBHKakCT0WItju9r5KQW5yTzEE3RN5WHNIWy7fGNuddruXFaifTjAfYWR aOtTzVYfbBGlKTMprk1U/iEs0Zvl705TdIm+yJsrhW/hoGCW+gSsy5YGXDSOce2n0/ T4eRU3jMGDunA== Date: Wed, 28 Feb 2024 18:05:20 -0800 From: Jakub Kicinski To: Rahul Rameshbabu Cc: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Richard Cochran , Tariq Toukan , Gal Pressman , Vadim Fedorenko , Andrew Lunn , Heiner Kallweit , Przemek Kitszel , Ahmed Zaki , Alexander Lobakin , Hangbin Liu , Paul Greenwalt , Justin Stitt , Randy Dunlap , Maxime Chevallier , Kory Maincent , Wojciech Drewek , Vladimir Oltean , Jiri Pirko , Jacob Keller , Alexandre Torgue , Jose Abreu , Dragos Tatulea , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH RFC net-next v1 1/6] ethtool: add interface to read Tx hardware timestamping statistics Message-ID: <20240228180520.5cea0f8b@kernel.org> In-Reply-To: <20240223192658.45893-2-rrameshbabu@nvidia.com> References: <20240223192658.45893-1-rrameshbabu@nvidia.com> <20240223192658.45893-2-rrameshbabu@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Feb 2024 11:24:45 -0800 Rahul Rameshbabu wrote: > +/** > + * struct ethtool_ts_stats - HW timestamping statistics > + * @layer: input field denoting whether stats should be queried from the DMA or > + * PHY timestamping layer. Defaults to the active layer for packet > + * timestamping. I think we're better off attaching this to an existing message in the dump (using ETHTOOL_FLAG_STATS / ethtool -I), like we do for pause, fec, etc., rather than having to build a separate hierarchy and copy identifiers within ETHTOOL_MSG_STATS_GET. Sorry if I mis-directed you this way.