Received-SPF: pass (google.com: domain of linux-kernel+bounces-86030-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 29 Feb 2024 11:10:10 +0900
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] kconfig: add some Kconfig env variables to make help
Message-ID: <20240229021010.GM11972@google.com>
References: <20240222031801.GG11472@google.com>
 <20240222032559.496127-1-senozhatsky@chromium.org>
 <CAK7LNARo4L6qxoqRU-0dgABarukJKAaZpCRtfA3MyUHhSuDQxQ@mail.gmail.com>
 <20240222051621.GH11472@google.com>
 <20240228045652.GH11972@google.com>
 <CAK7LNAQ8OyNMeGzVoTRg-sHDZ4YK0EKY_eEWNepekaibO_ZKwg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAQ8OyNMeGzVoTRg-sHDZ4YK0EKY_eEWNepekaibO_ZKwg@mail.gmail.com>

On (24/02/29 11:03), Masahiro Yamada wrote:
> > > > > +++ b/scripts/kconfig/Makefile
> > > > > @@ -158,6 +158,10 @@ help:
> > > > >                 if help=$$(grep -m1 '^# Help: ' $(f)); then \
> > > > >                         printf '  %-25s - %s\n' '$(notdir $(f))' "$${help#*: }"; \
> > > > >                 fi;)
> > > > > +       @echo  ''
> > > > > +       @echo  'Configuration environment variables:'
> > > > > +       @echo  '  KCONFIG_WERROR                 - Turn some Kconfig warnings into error conditions'
> > > > > +       @echo  '  KCONFIG_WARN_UNKNOWN_SYMBOLS   - Make Kconfig warn about all unrecognized config symbols'
> > > > >
> > > > >  # ===========================================================================
> > > > >  # object files used by all kconfig flavours
> > > > > --
> > > > > 2.44.0.rc0.258.g7320e95886-goog
> > > > >
> > > > >
> > > >
> > > > Why only two, while Kconfig supports more env variables?
> > >
> > > Right.  I wanted to add only those that we use (and familiar with) for
> > > starters.  I'm not familiar with things like KCONFIG_PROBABILITY, for
> > > instance, and not sure how to document it (its Documentation/kbuild/kconfig.rst
> > > description is pretty lengthy).
> >
> > Masahiro, any opinion?
> 
> 
> I do not need this patch.

Do you agree that putting kconfig env knobs into help makes sense
in general?  Especially those add valuable sanity checks.