Received-SPF: pass (google.com: domain of linux-kernel+bounces-86109-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1709179304.522055-1-xuanzhuo@linux.alibaba.com>
Subject: Re: linux-next: build failure after merge of the vhost tree
Date: Thu, 29 Feb 2024 12:01:44 +0800
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Linux Next Mailing List <linux-next@vger.kernel.org>,
 "Michael S. Tsirkin" <mst@redhat.com>
References: <20240229145531.7f7369cb@canb.auug.org.au>
In-Reply-To: <20240229145531.7f7369cb@canb.auug.org.au>
Precedence: bulk

On Thu, 29 Feb 2024 14:55:31 +1100, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the vhost tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/virtio/virtio_pci_modern.c: In function 'vp_modern_create_avq':
> drivers/virtio/virtio_pci_modern.c:755:34: warning: passing argument 5 of 'vp_dev->setup_vq' makes integer from pointer without a cast [-Wint-conversion]
>   755 |                               avq->name, NULL, VIRTIO_MSI_NO_VECTOR);
>       |                               ~~~^~~~~~
>       |                                  |
>       |                                  char *
> drivers/virtio/virtio_pci_modern.c:755:34: note: expected 'u16' {aka 'short unsigned int'} but argument is of type 'char *'
> drivers/virtio/virtio_pci_modern.c:754:14: error: too many arguments to function 'vp_dev->setup_vq'
>   754 |         vq = vp_dev->setup_vq(vp_dev, &vp_dev->admin_vq.info, avq->vq_index, NULL,
>       |              ^~~~~~
>
> Caused by commit
>
>   4cceb2591a87 ("virtio: find_vqs: pass struct instead of multi parameters")
>
> I have used the vhost tree from next-20240228 for today.

I will post new version for powerpc soon.

Thanks.


>
> --
> Cheers,
> Stephen Rothwell
>