Received-SPF: pass (google.com: domain of linux-kernel+bounces-86110-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 28 Feb 2024 20:05:16 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: "=?UTF-8?B?U2FuanXDoW4gR2FyY8OtYSw=?= Jorge"
 <Jorge.SanjuanGarcia@duagon.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
 <edumazet@google.com>, "pabeni@redhat.com" <pabeni@redhat.com>,
 "s-vadapalli@ti.com" <s-vadapalli@ti.com>, "r-gunasekaran@ti.com"
 <r-gunasekaran@ti.com>, "rogerq@kernel.org" <rogerq@kernel.org>,
 "andrew@lunn.ch" <andrew@lunn.ch>, "f.fainelli@gmail.com"
 <f.fainelli@gmail.com>, "olteanv@gmail.com" <olteanv@gmail.com>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add
 IFF_UNICAST_FLT flag to port device
Message-ID: <20240228200516.1166a097@kernel.org>
In-Reply-To: <20240228111300.2516590-1-jorge.sanjuangarcia@duagon.com>
References: <20240228111300.2516590-1-jorge.sanjuangarcia@duagon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 28 Feb 2024 11:13:23 +0000 Sanju=C3=A1n Garc=C3=ADa, Jorge wrote:
> Since commit 8940e6b669ca ("net: dsa: avoid call to __dev_set_promiscuity=
()
> while rtnl_mutex isn't held") when conecting one of this switch's port
> to a DSA switch as the conduit interface, the network interface is set to
> promiscuous mode by default and cannot be set to not promiscuous mode aga=
in
> from userspace. The reason for this is that the cpsw ports net devices
> do not have the flag IFF_UNICAST_FLT set in their private flags.
>=20
> The cpsw switch should be able to set not promiscuous mode as otherwise
> a '1' is written to bit ALE_PORT_MACONLY_CAF which makes ethernet frames
> get an additional VLAN tag when entering the port connected to the DSA
> switch. Setting the IFF_UNICAST_FLT flag to all ports allows us to have
> the conduit interface on the DSA subsystem set as not promiscuous.

It doesn't look like am65-cpsw-nuss supports unicast filtering,=20
tho, does it? So we're lying about support to work around some=20
CPSW weirdness (additional VLAN tag thing)?