Received-SPF: pass (google.com: domain of linux-kernel+bounces-86119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <aec4481a-25d5-41db-9d6a-c9e8b9bce310@arm.com>
Date: Thu, 29 Feb 2024 10:10:00 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64/hw_breakpoint: Define an ISS code for watchpoint
 exception
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org,
 Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 linux-kernel@vger.kernel.org
References: <20240223094615.3977323-1-anshuman.khandual@arm.com>
 <Zd9RY68L8cJRRSzE@arm.com>
Content-Language: en-US
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <Zd9RY68L8cJRRSzE@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/28/24 20:59, Catalin Marinas wrote:
> On Fri, Feb 23, 2024 at 03:16:15PM +0530, Anshuman Khandual wrote:
>> diff --git a/arch/arm64/include/asm/esr.h b/arch/arm64/include/asm/esr.h
>> index 353fe08546cf..6c0a0b77fd2c 100644
>> --- a/arch/arm64/include/asm/esr.h
>> +++ b/arch/arm64/include/asm/esr.h
>> @@ -143,6 +143,10 @@
>>  #define ESR_ELx_CM_SHIFT	(8)
>>  #define ESR_ELx_CM 		(UL(1) << ESR_ELx_CM_SHIFT)
>>  
>> +/* ISS field definitions for Watchpoint exception */
>> +#define ESR_ELx_WnR_SHIFT	(6)
>> +#define ESR_ELx_WnR		(UL(1) << ESR_ELx_WnR_SHIFT)
> 
> We had ESR_ELx_WNR since about 2015, maybe even earlier in the form of
> EL1 or EL2. Only that the 'n' is uppercase. So please use that, don't
> add a new definition.

Right, reusing existing ESR_ELx_WNR makes sense, will respin the patch.