Received-SPF: pass (google.com: domain of linux-kernel+bounces-86127-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: <Raju.Lakkaraju@microchip.com>
To: <andrew@lunn.ch>
CC: <netdev@vger.kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
	<linux-kernel@vger.kernel.org>, <Bryan.Whitehead@microchip.com>,
	<richardcochran@gmail.com>, <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore
 full data path operation
Thread-Topic: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore
 full data path operation
Thread-Index: AQHaaIt4JiSb9wlTL0mxkmItOFoCmbEdakoAgANaEGA=
Date: Thu, 29 Feb 2024 04:57:05 +0000
Message-ID: <LV8PR11MB8700B74600C2FEC3687D2B379F5F2@LV8PR11MB8700.namprd11.prod.outlook.com>
References: <20240226080934.46003-1-Raju.Lakkaraju@microchip.com>
 <20240226080934.46003-2-Raju.Lakkaraju@microchip.com>
 <ff0cea8c-5aed-431c-a525-210fd8c10c31@lunn.ch>
In-Reply-To: <ff0cea8c-5aed-431c-a525-210fd8c10c31@lunn.ch>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FKREsHzOG7f/tBCcwxamKEXmgBjlnSmWG69EvovHHEf5MpdP/ndnPQwsRXBz?=
 =?us-ascii?Q?LXaFbNqphxUM5ub9cX6TsBuxTRPrxWE/Zm0SR/Ustm560c3gKvlDaBCwXhgp?=
 =?us-ascii?Q?ULAEIXkduZKrVMApu6ms5PUO3tXz+ojWwPs3KkYO/rYBuh2oFdPaX3Si9VNC?=
 =?us-ascii?Q?N/Jrd92sUz9XgxSBbBgU6d5JVvxC05f+n6F+W3f5lm53cPjO0aObZyx5S/AZ?=
 =?us-ascii?Q?qvOMCQQSwHQD32vXz/+WeNMadj7GB29Ah1+aggPRc6EGUHEbx3CCJ9piMvOx?=
 =?us-ascii?Q?JPF+sVo0m9zw/Petgra3sepxoUSJM1aYUGNk+OMKi1TFuY5/G7hSh7kRIhzk?=
 =?us-ascii?Q?isQ8rQD3rZ+6d0LxJpq65heQhLTXtiNepe4rHTUFPyHugCm+JPliz/5XOL2T?=
 =?us-ascii?Q?Ludz9pK3lWbJ9ESKd2MbkrLsIaTd1zpSPAN9TxTbwzSky9W7ux47YXg0gT86?=
 =?us-ascii?Q?Q9NJzEG6fsRRZ9i0p+Fr2e4NHYNHiPVg6W1BOqI3cUpC8OziNHTfCWO97MnZ?=
 =?us-ascii?Q?YyDnlgEMuvZvLJpIWAJaNNCgIqaY0CuM1EwEi2L8QyfIfDbnSoEYkSLZ2yaS?=
 =?us-ascii?Q?pclzw0o9v0jVXrDZ3JbwQF8OUXDlUVnaY0c97NJNYpX0Batj4XJBgPpo3cdI?=
 =?us-ascii?Q?Rz9u43vlJ23Y5pdZr9daWDTYKdACqpLVb9G2AejVITCh91haOG3z/R1E/xW4?=
 =?us-ascii?Q?mtr9m89E3XGHwG+OMIYq7n+XHZGpeFvzGR35S5Y1RykXct8WigENbjaLYYGr?=
 =?us-ascii?Q?wU3QGhzTu3LEgxdT3H2sSp/GJuWtCn/cqEkjEcLWaziHBA1LN2/0ksuvE2qq?=
 =?us-ascii?Q?0K+hFwG7Zy7cVBdviRySeRPfw4jJoJhzwQwxPD3PmAhbZ90TTyq+QMIPjrNs?=
 =?us-ascii?Q?fWSyZGBswi6z62TZPbmgIF1G+9/XApxwDTqbzKAirijk4kXcEqpG/50GNVmT?=
 =?us-ascii?Q?WEiCZtWcv7p/KjPoeC9uwZUaIirOqlzkwHtYiTvGUSH3lf0Zdvl9imaS3fPc?=
 =?us-ascii?Q?p2aVyTYE64VizuMgmCTwqiwBA0GKztuMTJvjJbedJuVYvmZzOBmtOimLk9eY?=
 =?us-ascii?Q?Zi9EviBdv84T/zBl2gwBUo1S9+5BvEg4yusTBZbbyet71c57gO2W3HaxqZcF?=
 =?us-ascii?Q?YixTq2N6SyBN72Uc/+0Ki7LkJbzHyWpjwpYf7WLVCJgsRC1/0wqYma1WVqJf?=
 =?us-ascii?Q?4/dCXZIjm3gZnpYmo4vGStt/LYa695Hhh43yw3TGBztyI6PMvReJGjIA1fV5?=
 =?us-ascii?Q?L6X60A0oV7+5IQ14a+165kOmW0+HTqTtOF7N0+FW2FmBoeqLpLrhMBbHZNHH?=
 =?us-ascii?Q?yTu+2cSb6gpn1gszzltZ1OxIsaN76TV83BjsMEalbZKEcEe37IjhAQiSgnTY?=
 =?us-ascii?Q?OLTEuiHwSPFIdsuVsmLu32pbKOMtSdglmZ43eZ6KfJ/5WK9CzgIwKoUJ2SvW?=
 =?us-ascii?Q?/wQGnAp/vi4FW+hFr+gBLpJJtzs/qRCVUAIXfVowMACgWUj9x0BsRk8IH85w?=
 =?us-ascii?Q?yUF6XMLq262kvVPVyWYPD02itt9rJNV95AVJRIoS27w/UfGA0lMwjbqsPtgP?=
 =?us-ascii?Q?FkyLOsYR+jN005jWSJO3jnikjyTPNLfubX11/+dvlZttq1pz3/0qxckrcaPU?=
 =?us-ascii?Q?DA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8700.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad2edc08-59cf-41a5-ffb4-08dc38e2e051
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 04:57:05.6930
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Sg93+32K9YRZgPcJrNa+QCq7urDSPkh0MQQ32krjPPGheWGTRDiY8w6UTcGI11wsEbZCXGSggtr77xUauGfsmucP3B8Ctw4882abqBEPKIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5873

Hi Andrew,

Thank you for review comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, February 27, 2024 7:09 AM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@microchip.com>
> Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; linux-
> kernel@vger.kernel.org; Bryan Whitehead - C21958
> <Bryan.Whitehead@microchip.com>; richardcochran@gmail.com;
> UNGLinuxDriver <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH net 1/3] net: lan743x: disable WOL upon resume to
> restore full data path operation
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Mon, Feb 26, 2024 at 01:39:32PM +0530, Raju Lakkaraju wrote:
> > In order for datapath to be restored to normal functionality after
> > resume we disable all wakeup events. Additionally we clear all W1C
> > status bits by writing 1's to them.
>=20
> Just to make sure i'm understanding this correctly, you are just clearing=
 that
> there was been a WoL wakeup. The WoL configuration is not cleared, so i
> could suspend the device again and wake it up with WoL. There is no need =
for
> me to use ethtool, the WoL configuration is preserved.

Yes. Your understanding is correct.
WoL configuration is not cleared.=20
This clean-up helps us when resume from sleep due to system events.
There is no need to use ethtool's configure WOL again.

>=20
>         Andrew

Thanks,
Raju