Received-SPF: pass (google.com: domain of linux-kernel+bounces-86144-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c1025094-d9aa-4f4c-bb8f-a486f9953bec@infradead.org>
Date: Wed, 28 Feb 2024 21:40:04 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] kconfig: menuconfig: Make hidden options show with
 different color
Content-Language: en-US
To: Tomasz Figa <tfiga@chromium.org>, linux-kbuild@vger.kernel.org
Cc: Nicolas Schier <n.schier@avm.de>, Masahiro Yamada <masahiroy@kernel.org>,
 linux-kernel@vger.kernel.org, Jesse Taube <Mr.Bossman075@gmail.com>
References: <20240228060006.13274-1-tfiga@chromium.org>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240228060006.13274-1-tfiga@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 2/27/24 22:00, Tomasz Figa wrote:
> When hidden options are toggled on (using 'z'), the number of options
> on the screen can be overwhelming and may make it hard to distinguish
> between available and hidden ones. Make them easier to distinguish by
> displaying the hidden one with a different color (COLOR_YELLOW for color
> themes and A_DIM for mono).


> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> ---
>  scripts/kconfig/lxdialog/dialog.h  |  5 +++++
>  scripts/kconfig/lxdialog/menubox.c | 12 ++++++++----
>  scripts/kconfig/lxdialog/util.c    | 19 +++++++++++++++++++
>  scripts/kconfig/mconf.c            | 18 ++++++++++++++++++
>  4 files changed, 50 insertions(+), 4 deletions(-)


> Changes from v1:
> (https://patchwork.kernel.org/project/linux-kbuild/patch/20231228054630.3595093-1-tfiga@chromium.org/)
>  * Replaced A_DIM for color themes with COLOR_YELLOW, because the former
>    has no effect to black text on some commonly used terminals, e.g.
>    gnome-terminal, foot. Reported by Masahiro Yamada and Nicolas Schier.
>    I ended up with COLOR_YELLOW, as it seems to look comparatively dim
>    with mutliple light and dark color themes in Chromium hterm and
>    gnome-terminal.

I guess COLOR_YELLOW is a relative thing, i.e., it depends on the term's
current color scheme in my testing.

With rxvt (with a beige/khaki background), I do see yellow.

With xfce4-terminal (with amber/orange foreground on black background,
i.e., my default from days of amber monochrome displays ;), the "yellow"
comes out as a faded/washed out/dim orange. But still readable.

Anyway, this looks useful to me.

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

thanks.
-- 
#Randy