Received-SPF: pass (google.com: domain of linux-kernel+bounces-86264-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <757d3977-4bac-47b8-a8b1-9bb84618895d@intel.com>
Date: Thu, 29 Feb 2024 09:06:34 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add an extra entry for the
 Chuwi Vi8 tablet
To: =?UTF-8?Q?Alban_Boy=C3=A9?= <alban.boye@protonmail.com>,
	<pierre-louis.bossart@linux.intel.com>, <broonie@kernel.org>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240228192807.15130-1-alban.boye@protonmail.com>
Content-Language: en-US
From: Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20240228192807.15130-1-alban.boye@protonmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REh2OXVLSkoyQ0VmelYrY0laS09ycTY1WFlUeGp2YkdPMWt5VzJJdy9tRjBI?=
 =?utf-8?B?L1gvUVVNTTA4cWFwNGFtVzA5UFd0Tm1MNkp5bDBXck84d1hQMmZJTmZSOUx3?=
 =?utf-8?B?RlpZeEZFUVJHelk2MEcvcE1GOUFTNWNCVFhaQ3MrZlVTRGh6cFhmemZEbEJp?=
 =?utf-8?B?QWRzbi80Q0YyVjcxVG1SYXBFRHM1UXh0cmdRWDJRekdiTjZLeno4dGJTc1FF?=
 =?utf-8?B?L0NLNlRMVkFVUXRGbEZlaFBvdVA5TVNjbFZrKzV6NkN3WnFjWWNRM2tnRVNv?=
 =?utf-8?B?d0ZkeEF5ejg1ZzR5SWVpV25XeFFXNHFyWWlldkRTZDdrSnducDhmS3Y1Wld0?=
 =?utf-8?B?aWZpdW56eHB6amNON3NUU0gzUmwwMXQvbEVnT2tNcWVnU2tNSjFvb21lN0wz?=
 =?utf-8?B?YXZkOEMwSWlMU2NjN0w1SjJMK0NZczMvZ2YvV3hGaGVPRkQ4VC9MNW5JbXVP?=
 =?utf-8?B?ZjFMc0JJNVRsWlVVOXhEbVVNSWN2dWdxbGUvRU9oSW9wTitPRU1JZlRJc2tE?=
 =?utf-8?B?dkRqdU9yQkM2TTFOMnIrQXRVVDAzaEZ4em1TeFRJL05keDNLRGhCQUxTeHg0?=
 =?utf-8?B?aTFMY3NYN1dMR2NFNFZZbmsyVmdKRG9TMkVyMm9JMjlJd2tBdUYvTXNNZFgx?=
 =?utf-8?B?Qm5hSnFzYUNYU1RIVzRVTzAxS2J3ZnV1MGZPb05lN3I2aHNxVXg3UWlyZzFV?=
 =?utf-8?B?Vis4UG5Mdy9nYnliZ01NRkRQRDVPRUNxNHdnTkp1b3FXWGhhVkNoNnh2Z0VO?=
 =?utf-8?B?d0g3L2kvTXErMjRRRG13MkJYcHV2OUc1RnhmVFF6dVE0cWxDZjJ3dzF4V2sv?=
 =?utf-8?B?VFlZUndBVkFRL0twby9NWGhXWE9tU3V1TVpXM0Frcy9kWVY5MXdzRnJqK3c5?=
 =?utf-8?B?Y21DaHBtQzBuczExbjlZaGx4ZWJacnJ3cWgvQU56YjJUSW9rS25nOXg4TDFB?=
 =?utf-8?B?Q0hjQUlvdE53MVhVdS9ZVGU0Z1pOWmZObm9tWExDVy9MM0NGZmtWdmtYQVhz?=
 =?utf-8?B?R013ZlV5RGYrR1hvYWJrQ0RCZ0MrTGFGOWNFeVNuL0xMVFdXYjFuT0xRV3Vh?=
 =?utf-8?B?QUt4TVZQdUhNcTJ0WC9oTUVRTEdPQ3k5UlE3cllTeHhDU0lCeFppSm1NMk56?=
 =?utf-8?B?cjR0aHBhNEFGN3V1eDNEc1pqVHpPUE9Zd0pPVnUzWEUwQmw5TWNheTBzTmZY?=
 =?utf-8?B?T1NKaVV3U2RvTkxJRzNQNHRXS2FlRFhhV2ZLc2taVkF0aHFHS3lUNXBIa2Fr?=
 =?utf-8?B?M0pVS21ta0tzNVpmenhOMDFuekE1a2NHc2E4b3krMUxnc1I0bzFHV1lkelZm?=
 =?utf-8?B?SmR4b3BtaWRBMGpha3JUM1Fkc3BNNlBKVjI0bUhvb0xMRVMxbXNhMmJBUVRt?=
 =?utf-8?B?S1ZhSFBLbThQaFhVMlFQSmpPakd5QTBmVS82RnJveGxDVGtsd1NDNnRRTEh2?=
 =?utf-8?B?ZytNQXc2V0tNc2loSUc3cEk2UlB1R0tpSW5Xank0RWVPUHZGa3dzdEZkcG84?=
 =?utf-8?B?a2ZmRFVDVUxNelhyeU5PQVBwQTZWbSt6TmJUampLUHNWSWQ3czR0V0pobW02?=
 =?utf-8?B?TFVPamphTGF3RzRpY2FZV0tSM25vNFFzMkJLaXNJT0xGRi9QZkhmMm1UV3VF?=
 =?utf-8?B?ZXVaVVZ4NE5hSEd6Rmk2QThaL2VQbTluSzMvdGRuMkFJdFZhVjFoVGVIVXhJ?=
 =?utf-8?B?bnFCWW5TeW0zWFRiNWtRRlFXejY2bDd5TGJnMDQwc2hVVFA4Wi84RWxhTHhr?=
 =?utf-8?B?MVlkWDlBNzJDaVFSaDNFR3BIazBMei9ZaG9HOExiTm5ZTWh2YVFYd3liSVlW?=
 =?utf-8?B?SjlFSmx6NkdISDVoamdkM0RMYnhFZy8yYitSOU1KY25ER015OUZsZFFWL2pI?=
 =?utf-8?B?R0VoTU9MLytLNzdtMGVxNlplektXWVpZWDRnWnhERENlSGVTU0QwQjJxUnk1?=
 =?utf-8?B?Tm1TanFHMTl5QkhraDFvRm15MjVHeWRPMUpiWEFZMUhpYzR2bC9qd0NSVk1T?=
 =?utf-8?B?WVRJdW1rSGlRUFJRL2dvMk1zdmpRNTBVQWlFelV3b2ZUUUtzQlhwUnkxRWE2?=
 =?utf-8?B?UmtHd3FERUVoWlViOWNGYkIxOURJVnd1eFBFODdFckM5a3YyLzJlRS96Z3d3?=
 =?utf-8?B?anB4cjFZMG95UjM0eXdYdkxtZTRDSVg4c0d4RURzcnZRUTRFSkRMcVhUNWt4?=
 =?utf-8?B?ZVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d770439-df4f-459d-332f-08dc38fd5afe
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 08:06:38.6319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zAUbdoeOgpuAXN/k7mk8CPAD5k/qksqfwgi2x/jYEM+Qm3OnoiCLFn2LJkbT3MyFIMvTgppHwmdKqE222yO/RfQkJbv7Miyd8y8KF72Fuis=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7207
X-OriginatorOrg: intel.com

On 2024-02-28 8:28 PM, Alban Boyé wrote:
> The bios version can differ depending if it is a dual-boot variant of the tablet.
> Therefore another DMI match is required.
> 
> Signed-off-by: Alban Boyé <alban.boye@protonmail.com>
> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 03be5e26ec4a..05f38d1f7d82 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_SSP0_AIF1 |
>   					BYT_RT5640_MCLK_EN),
>   	},
> +	{	/* Chuwi Vi8 dual-boot (CWI506) */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
> +			/* The above are too generic, also match BIOS info */
> +			DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
> +		},
> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> +					BYT_RT5640_MONO_SPEAKER |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{
>   		/* Chuwi Vi10 (CWI505) */
>   		.matches = {

Thank you for addressing the review comments.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>