Received-SPF: pass (google.com: domain of linux-kernel+bounces-86279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID:
 <KL1PR06MB69645ED79CED22F5BB1DE45C965F2@KL1PR06MB6964.apcprd06.prod.outlook.com>
Date: Thu, 29 Feb 2024 16:14:54 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v6 11/11] net: hisi_femac: add support for
 hisi_femac core on Hi3798MV200
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta
 <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240228-net-v6-0-6d78d3d598c1@outlook.com>
 <20240228-net-v6-11-6d78d3d598c1@outlook.com>
 <7c171041-30cd-41a1-8b8a-00168d112cc5@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <7c171041-30cd-41a1-8b8a-00168d112cc5@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: KL1PR06MB6964:EE_|JH0PR06MB7351:EE_
X-MS-Office365-Filtering-Correlation-Id: a1ebb8ec-c22e-4c19-bb3c-08dc38fe8567
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BS9QWZ6pUSC4qTzsnzeNX1qvzTqodTaSB6R1hRo1o5A6sI6IJ9mggIemHwcB2eJMT12aTfA2xFB2dSyboYpt1Gq5zQudW64NZV43xn4WnMDWDKoMLdakJ9S8MmqcqKS7I2fTXtNonccem95P7oiIUfvogvUSHDZsyWdOX47Oza2DSOeeMxmzGBzc4+o+zDtxb0Oa47G8ErVkcAq9j/hasMT0JHYIvGZiGtSCt0eyMzXZinji4+bTT06pBnsjIy0BzmCY7f+rZcFDmAw+ivyDVopwfeBPyqpbKMCm+FOmSMgIgOSeonY9xVujuEA+1R1cVlOEpJeTqjoP9YOkvfVLb95mSu1U86wl6+/NAc0C7bF39SXQZjZjQrH+cYRJ7dqKo8iZs4LHjd+s9oLBQn3yhK7kRVkeTgfFJR8A0nce16YeaBK4NeAIW5QWGi0ogeIncX9VmPSoMtXAaRBWkTPfeR9cVls2dTgKDsGXGa4AzvfpIbRq7K2DILEcjov2jTfPzIL+D1iSUcdUuJ/eMCjslsEDQIDFLgMl0BHHmac0SqQqUehnc0mRIGbZa/vKiz76
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QTQrSG1ydml6N0tXZFo1a0R3am4vNjE0dnJaZHF6SitKdzhjeHpEUE52OTFT?=
 =?utf-8?B?SCtJakN3US9MTW1McGNQQ2FLcXJPVU85cnFzMFZxaXhsSDVzZkxaS0QwemM0?=
 =?utf-8?B?L3ZaanIySDZDSkYwUVdJZ0ZhNTE2dkdvbG5TL0xPemlMTkdJUmhJcUQxQWwy?=
 =?utf-8?B?dWRYR2FsYmZXZ0lXQ3NUaGpLMzFGejNPYnF4b3BEdHhQVmtnQ1lhS2h1ZGk1?=
 =?utf-8?B?SU9QZWNEdEJMUDlDSUtOdzRYWjlCT0lkMjI5QlZQY21YdVA4V0UwK2F5M2h6?=
 =?utf-8?B?UlJQWnRKdGhTTGp0TkpqWU5LNS9jbGJiWm04UjhZUlpqR2dPcVppUXNBK2Mz?=
 =?utf-8?B?T1VCY0NINjNMbzNUYVAxUElqb1Z4Y1RZVmtQcGxmdlZqdFM2MjBkSWwwd3Yw?=
 =?utf-8?B?NTMycWZIaytyck5EM2ptZnlEL1dGMUUrelV3aklOTUFYVTE2YWIyRFN4N3hP?=
 =?utf-8?B?dkVIeXpRdHp1MUxUWWRDZ1dyL3N4aEJ6d1VyY1hXTmk5Nk9KNy80TlREUUJo?=
 =?utf-8?B?M3F4TU5ZN2pVWllGTURubVZ0cStycGF1d0dLZHlnbFlCN1lOUDBTZzJwVTly?=
 =?utf-8?B?YUREYjBaSWxiZ0JpVlExUnhnajZaM21mNzZHSlBSRVl6WHpNQXV5VVFLcm0x?=
 =?utf-8?B?Y2p5TlN2TDRCM2FKZWVMdHk4NFJ6Yyt2RldMZUxmbGE3SDZyVXE0VUJiOVVT?=
 =?utf-8?B?N2xKcUs3WUEwaUs5cGZLWVpndTkweFF4R05kWkZZOGU0dHd0a25kWGd6TXJp?=
 =?utf-8?B?citySzFOZkVOYitFOHpXOGhHaml5MHVxVU5rTjJlTjlua1lwYkNnUFBFaHJD?=
 =?utf-8?B?SkdEK2RMSm8zWThra1M4dlZYc0VCWlg1a2NoQWMxZUM5QjRJVFNRS2ZHbGk5?=
 =?utf-8?B?RGtaZlR3U3VZZEZZazUweU02cFp6RW5NUGZWN2xReTROZ3RiR1hpckx1anBs?=
 =?utf-8?B?ODBUdmpvaHkwWVlwK3dIcUtnMVZMTnBFWjNQMnNPTVoxTXIzbzJKanhvQXhx?=
 =?utf-8?B?U2ltYmtFdXhkZjBWSFdEU0svcTRURUJNWHl0ZGo4UEV3SHBVRlFrZzNHTURs?=
 =?utf-8?B?L1k3dzdmWTZMaVM2eFViZjR4VEdGMUpQM0NKVzFnQjg2dktFZEVkUkNUc0h3?=
 =?utf-8?B?dVo5NE1qZXFBYURRQ3Z3TERTNzhNN0did3VhNm1WQzRUMzdNZDJlSXdkZGpw?=
 =?utf-8?B?dS9QQUtvZW0va1BXSWpIeCtGS0pCRVdDbGJDWEZOMlhrTWNHalYvenoxM3I3?=
 =?utf-8?B?WGw4amx6OWwrOGp0bjRMUFVDcXVBVzNoU21Ud0xoems1bUpRZHhFVFpkaUxw?=
 =?utf-8?B?MDRRSmRzMW1Uemk0UU1Za1lvUDRvRzRFa3piNjhWQUNFUDMwbnJlanNKUkhO?=
 =?utf-8?B?dmt4ekYvenRFa3NKalZVekxqMS9QR3l2LzErRlc1S2lma29ENzlhY0VHOUFk?=
 =?utf-8?B?Q0NvMDhkaU9zd1NCMnd4UzB4V0VkUy80THFvcG5tWE05R3l0ekJ4am9MZDZx?=
 =?utf-8?B?bzNJZTZTU1pCTTNRRGxvNUUvNEs0ZHFvN3pzTDNCUFlNWFVKODNqVnlvL05z?=
 =?utf-8?B?emRERmR3WFRGQno3VzNpbCt5T1Zza2xoY3hvK1ZjUzNML2dobHU1RHB2V3ph?=
 =?utf-8?B?d1JVMHNhZ3pFNEFYcEdVT1ArSVhGc1hDazVMa2k5VkNkVXk5djl2RUxaNnRP?=
 =?utf-8?B?K0V0NEFMU01JR21MaXQzdlluQS9mbSsrZkRhalgrdkNsZy9rN3RTR1Y2ZzB6?=
 =?utf-8?Q?4i1L4YyFv+/pB/L45HEOHFWM5fvVs6OP0a365yQ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1ebb8ec-c22e-4c19-bb3c-08dc38fe8567
X-MS-Exchange-CrossTenant-AuthSource: KL1PR06MB6964.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 08:14:59.1968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7351

On 2/29/2024 4:10 PM, Krzysztof Kozlowski wrote:
> On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> Register the sub MDIO bus if it is found. Also implement the internal
>> PHY reset procedure as needed.
>>
> 
> 
>>  
>> @@ -947,6 +992,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
>>  static const struct of_device_id hisi_femac_match[] = {
>>  	{.compatible = "hisilicon,hisi-femac",},
>>  	{.compatible = "hisilicon,hi3516cv300-femac",},
>> +	{.compatible = "hisilicon,hi3798mv200-femac",},
> 
> No, it does not make any sense. Why do you keep growing this table?

So do I only have to keep the generic compatible "hisilicon,hisi-femac"
or the two SoC compatibles?

> 
> Best regards,
> Krzysztof
> 

-- 
Best regards,
Yang Xiwen