Received-SPF: pass (google.com: domain of linux-kernel+bounces-86412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 29 Feb 2024 10:25:57 +0100
From: Lukasz Majewski <lukma@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Stephen Hemminger <stephen@networkplumber.org>, Oleksij Rempel
 <o.rempel@pengutronix.de>, Eric Dumazet <edumazet@google.com>, Florian
 Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 netdev@vger.kernel.org, Tristram.Ha@microchip.com, Sebastian Andrzej
 Siewior <bigeasy@linutronix.de>, Paolo Abeni <pabeni@redhat.com>, Ravi
 Gunasekaran <r-gunasekaran@ti.com>, Simon Horman <horms@kernel.org>,
 Wojciech Drewek <wojciech.drewek@intel.com>, Nikita Zhandarovich
 <n.zhandarovich@fintech.ru>, Murali Karicheri <m-karicheri2@ti.com>, Dan
 Carpenter <dan.carpenter@linaro.org>, Ziyang Xuan
 <william.xuanziyang@huawei.com>, Kristian Overskeid <koverskeid@gmail.com>,
 Matthieu Baerts <matttbe@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: hsr: Provide RedBox support
Message-ID: <20240229102557.615c02f3@wsk>
In-Reply-To: <c3880444-3665-4a60-b6ec-f8ae8a9fbf8d@lunn.ch>
References: <20240228150735.3647892-1-lukma@denx.de>
	<20240228083115.01d4c93e@hermes.local>
	<c3880444-3665-4a60-b6ec-f8ae8a9fbf8d@lunn.ch>
Organization: denx.de
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/HXhiR.+AvKxAWKdncrkr5ru";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/HXhiR.+AvKxAWKdncrkr5ru
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Andrew,

> On Wed, Feb 28, 2024 at 08:31:15AM -0800, Stephen Hemminger wrote:
> > On Wed, 28 Feb 2024 16:07:35 +0100
> > Lukasz Majewski <lukma@denx.de> wrote:
> >  =20
> > > =20
> > > +/* hsr_proxy_node_table_show - Formats and prints proxy
> > > node_table entries */ +static int
> > > +hsr_proxy_node_table_show(struct seq_file *sfp, void *data)
> > > +{
> > > +	struct hsr_priv *priv =3D (struct hsr_priv *)sfp->private;
> > > +	struct hsr_node *node;
> > > +
> > > +	seq_printf(sfp, "Proxy Node Table entries for HSR
> > > device\n");
> > > +	seq_puts(sfp, "MAC-Address-SAN,        time_in\n");
> > > +	rcu_read_lock();
> > > +	list_for_each_entry_rcu(node, &priv->proxy_node_db,
> > > mac_list) {
> > > +		seq_printf(sfp, "%pM ", &node->macaddress_A[0]);
> > > +		seq_printf(sfp, "%10lx\n",
> > > node->time_in[HSR_PT_INTERLINK]);
> > > +	}
> > > +	rcu_read_unlock();
> > > +	return 0;
> > > +}
> > > +
> > >  DEFINE_SHOW_ATTRIBUTE(hsr_node_table);
> > > +DEFINE_SHOW_ATTRIBUTE(hsr_proxy_node_table); =20
> >=20
> > NAK
> > Do not abuse sysfs to be a debug proc style output. =20
>=20
> This is actually debugfs, not sysfs.
>=20
> However, i agree, we want information like this exported via netlink
> as the primary interface to the end user. debugfs is not suitable for
> that.

Am I correct, that recommended approach would be to:

1. Modify iproute2 to support for example:

ip addr show dev hsr1 nodes {proxy} ?

2. Shall the currently exported:

/sys/kernel/debug/hsr/hsrX/node_table be left as it is (for legacy
usage) or shall it be removed and replaced with netlink and iproute2 ?

>=20
> 	 Andrew


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/HXhiR.+AvKxAWKdncrkr5ru
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmXgTaUACgkQAR8vZIA0
zr166Qf+PtTfzrYXP7ThEPCaBT1z1kOq7J1fD6bGHn0jQAAafLG3Km5OkuNNObdL
/0mxgNb7JfaPlXuY4SQtR5i1s9BZoWLpLmNQ5tCfvaVjy+e/ac5ct2YrqHCnOPdA
IXBRCf2iZYG6Cvci4S2JJol9ssQea/jgqmHfz1ze8YqtEdwaDS91bwOZshoG1xSl
I3Z7v80GgGGQECIkkznT8xF/sbuFzRUKgh7n4t4ynkopzjDTp6rPTmSo4fXfP4L/
2f/zhXUbzzLsdH8/6rGLRGCcKlF2cmBZpKZbUd8LgCS5y5Rs56IayHv7Rr47FUiZ
VfC9XqFdu2FEhEEok2EDmyXD7sfhUA==
=3OGX
-----END PGP SIGNATURE-----

--Sig_/HXhiR.+AvKxAWKdncrkr5ru--