Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp360688rbe; Thu, 29 Feb 2024 01:29:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWafKZgZmjCQY5IsUuVR8zBue2aL+rTlDLubrY3x9LITiyPnYlBMA81rxK/33JPIkQxtNpQNJMhoX5zvHVP7bmLXDwp7p5CwER6C+Fh1Q== X-Google-Smtp-Source: AGHT+IFJw00V7tXMsB+lWtMcykI8vySCH1bPSyOOpP0qKJ3CVsn6Q5EEWhiqYIfUePj+NfpfN6Xq X-Received: by 2002:a17:906:af7a:b0:a44:51f9:3410 with SMTP id os26-20020a170906af7a00b00a4451f93410mr420822ejb.0.1709198957809; Thu, 29 Feb 2024 01:29:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709198957; cv=pass; d=google.com; s=arc-20160816; b=FQkT861PGejn7TPmQ3vwZr/2AqPDaZLg19fe3vlF0H3jgDtKsIPR+dcISU+UElWwgs iobbn2IXmT/HMraOtehx4CGh2n6+OhyX7hCfAfcTJMYoDgPeXh86fgE4Oed84g19LKlB hfkHp3f3Z6BwiRxyklcHghEAOVQw8JZWBQEskwBxqgSoS4GIiIpKpvzqXLt1OGduzi8j cNS/EFX0HgP+qRkt7ClcnKm+ch/u8nVh+LQp+kh1qdmdB+NBD4trJsdiGrroMg2Civ1m 7VuJSg3r2tE16WkzcJU8OlsF7/t/RfhZ9aoCdA9XU6sbxFZ3IEDiHG08AjDJKXnyavwc 1lCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=lpnwZXvO+GxSiHd0a/DytgyertWwHVGU4iyf7Q6jgRw=; fh=UCkSQAzaI4kYKO6azJFwOccVM9i+pIcDvQa2PF4cmVA=; b=sbhixBWRvAMFx+Fgl0z8v89b6RpLaGRMVjb0+0xWlYFSqQ+VdvWLP0YEXd+0nOledz CAGAoKBZo9X4GzbtJFO14E0A/B91sGfMt6hbGtXJY0TU873yaE5hWZ/sxh20U7BauzdL GffhtWm5qorT4UdAH0HSozMd71YaEYbU00Qd58JrMzZKGPPNb0zd5XcHE8ZVELXGxLvE xeaSPMpB9+xKs7qrCJrKe/jerUZigbZe9jKeBzpR3rPfEzWbD3xwCX5Ke3x7PyIeJs+0 /+LUYRyjp2CbQ4NFNRp/xwbG2EyhCyfJk5yHkTacu5ZaBwmG1jLVHnj8U5ly/OVTDtdC drYg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TYuNkIPj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z19-20020a17090655d300b00a43c12a823esi418964ejp.153.2024.02.29.01.29.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 01:29:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TYuNkIPj; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 91D3D1F23747 for ; Thu, 29 Feb 2024 09:29:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 697D85CDF3; Thu, 29 Feb 2024 09:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TYuNkIPj" Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127E45B697 for ; Thu, 29 Feb 2024 09:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709198938; cv=none; b=CKC6khdiv3hb4Vd9sQKJxglfg1mwVqMe0DEYfSmNxJXmnpFIvV0NALCPokY5d6mOcfy0Acaj27WN89pymq66p9/6T3n/mmA1kJY8osMpl8eZKR4sRn4DQ1azFANYFd2eiCRCawYuFkYgKqQH6imAY9ILb97+sa5mH6cuqKxj3qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709198938; c=relaxed/simple; bh=il/+MTSUB+hJ9/Qk/zhTY8kE7bR8Rhe3rQiBlSatDYc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=oKUgV+tX2olTaK30uKKqwJ8y4OSqwHy8i2Vx913OpDR2yFZQ3oosdmPGLa9IclUp2m2bV1KQv6pkuERGG4WydnRyHDdii8PN9eR9WXlREnCsJRxH8J6xjX74uziXI3lx0+zFhq3WdutAwjsuDwsl89+PkAqkp+jbaMxoASq34M4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TYuNkIPj; arc=none smtp.client-ip=209.85.219.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so670779276.1 for ; Thu, 29 Feb 2024 01:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709198936; x=1709803736; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lpnwZXvO+GxSiHd0a/DytgyertWwHVGU4iyf7Q6jgRw=; b=TYuNkIPjMwzDHQdknFcZap2VRp457jPMtJDlOKTrctAkBWLQi4bK2SGCP2BZEl1Rq+ E0gA3YYj58ti5Duzm8HbzOG4gRNfoCtzM16hKtF+9B2WPMJVjkepl0FSh7J62ze0SOmG LaLgb4IWlYioWh4MATdLMcmwEKWO9VRCoRUGooefg45aWtBJH/Y3Ny58TDlunKSijXAH v5lAuOy2zJL9QdgQpaPwR3geDDFbwQWlXt5+aDJR48UrUXJDpUnB4a3dNlkJPIpHELab P0WizjuSJk9yuwQ12ykZnqHygcaW2sNnQC/ojEmDgp0kdwLsR5zs9c9MUUC25j79wlIk MTaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709198936; x=1709803736; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpnwZXvO+GxSiHd0a/DytgyertWwHVGU4iyf7Q6jgRw=; b=HZHYRbDKl6HsFiTxjU49Zm8vJKhj83L13x53kzxUlTiQfIj2PlmakZw2RuseZxRCDD MafPyAG+iQvbMZYLmPkVsWOF214zIdxeEfwk2+NdFn1YSBhtr4SDyBQonWg5bGTafrCt UZ14LGHX30O9BCRAzv8aAHpBf9gdXf/SFNxsKoM16uGWxSWwy4NcQ8SVqp4hVDBzftkw tcSkIH9YLEAcB9U3T+fWrM2NEp7gSzcroPLSBCbuY+Zx19DXjxM6s9FX6GE//3zgm0sn OCH31DTBDuJ9ZD2cS66BUMRo4tk5lBWMyOTn5jGuLKvSXAtEN2wQgHSUokkV3QkayJdS BVFA== X-Forwarded-Encrypted: i=1; AJvYcCWxHyLtQdKoOKpeMeoxqG0fcOIQEcrkkWv/z8uXCrPpOeaxb1FzP8Xf5bl9EdOY1pnIZ3vn+vxRmf/i/o/zs0TM24F5b4cflAgia13V X-Gm-Message-State: AOJu0Yz4uz9myJX2s9xDvIbAvNTApD9Jx0gcgHlZG6JXpoaDw20qKMMI ue/bK2sljdcMaVLDiYx960DJqq4ZMpFmd91/TXbgL8GL4htsoiax9th35TZGXq3UYyoCs1cjs15 XrbCkRSPvrNjHMRFjO4gtX10GcXgE1NRB/UlloA== X-Received: by 2002:a5b:445:0:b0:dcb:bff0:72b with SMTP id s5-20020a5b0445000000b00dcbbff0072bmr1559369ybp.31.1709198936052; Thu, 29 Feb 2024 01:28:56 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240228-mbly-gpio-v2-0-3ba757474006@bootlin.com> <20240228-mbly-gpio-v2-13-3ba757474006@bootlin.com> In-Reply-To: <20240228-mbly-gpio-v2-13-3ba757474006@bootlin.com> From: Linus Walleij Date: Thu, 29 Feb 2024 10:28:45 +0100 Message-ID: Subject: Re: [PATCH v2 13/30] pinctrl: nomadik: follow conditional kernel coding conventions To: =?UTF-8?B?VGjDqW8gTGVicnVu?= Cc: Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Thomas Bogendoerfer , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Gregory CLEMENT , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 28, 2024 at 12:28=E2=80=AFPM Th=C3=A9o Lebrun wrote: > Fix strict checkpatch warnings relative to if-else blocks and bool > expressions. Message types addressed: > > CHECK: Comparison to NULL could be written "!nmk_cfg_params[index].cho= ice" > CHECK: Unbalanced braces around else statement > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > CHECK: braces {} should be used on all arms of this statement > > Before: 0 errors, 1 warnings, 16 checks. > After: 0 errors, 1 warnings, 7 checks. > > Signed-off-by: Th=C3=A9o Lebrun Patch applied! Yours, Linus Walleij