Received-SPF: pass (google.com: domain of linux-kernel+bounces-86496-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240229052813.GA23899@didi-ThinkCentre-M920t-N000>
 <CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com> <CABbqxmdM+zbn+78rcB_amqfwFKXCTwyj2MPt2GVioQpR0Tj1Tg@mail.gmail.com>
In-Reply-To: <CABbqxmdM+zbn+78rcB_amqfwFKXCTwyj2MPt2GVioQpR0Tj1Tg@mail.gmail.com>
From: yuanli fu <fuyuanli0722@gmail.com>
Date: Thu, 29 Feb 2024 18:02:35 +0800
Message-ID: <CABbqxmcG1ZApeKLS5yfE7Bb-tgBwOLEn1-ixp89n3mKVJbmm6g@mail.gmail.com>
Subject: Fwd: [PATCH] tcp: Add skb addr and sock addr to arguments of
 tracepoint tcp_probe.
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

---------- Forwarded message ---------
=E5=8F=91=E4=BB=B6=E4=BA=BA=EF=BC=9A yuanli fu <fuyuanli0722@gmail.com>
Date: 2024=E5=B9=B42=E6=9C=8829=E6=97=A5=E5=91=A8=E5=9B=9B 16:27
Subject: Re: [PATCH] tcp: Add skb addr and sock addr to arguments of
tracepoint tcp_probe.
To: Jason Xing <kerneljasonxing@gmail.com>


Jason Xing <kerneljasonxing@gmail.com> =E4=BA=8E2024=E5=B9=B42=E6=9C=8829=
=E6=97=A5=E5=91=A8=E5=9B=9B 15:30=E5=86=99=E9=81=93=EF=BC=9A
>
> On Thu, Feb 29, 2024 at 1:33=E2=80=AFPM fuyuanli <fuyuanli@didiglobal.com=
> wrote:
> >
> > It is useful to expose skb addr and sock addr to user in tracepoint
> > tcp_probe, so that we can get more information while monitoring
> > receiving of tcp data, by ebpf or other ways.
> >
> > For example, we need to identify a packet by seq and end_seq when
> > calculate transmit latency between lay 2 and lay 4 by ebpf, but which i=
s
> > not available in tcp_probe, so we can only use kprobe hooking
> > tcp_rcv_esatblised to get them. But we can use tcp_probe directly if sk=
b
> > addr and sock addr are available, which is more efficient.
> >
> > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>
>
> Please target 'net-next' in the title of your v2 patch.
Got it, thanks.
>
> > ---
> >  include/trace/events/tcp.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> > index 7b1ddffa3dfc..096c15f64b92 100644
> > --- a/include/trace/events/tcp.h
> > +++ b/include/trace/events/tcp.h
> > @@ -258,6 +258,8 @@ TRACE_EVENT(tcp_probe,
> >                 __field(__u32, srtt)
> >                 __field(__u32, rcv_wnd)
> >                 __field(__u64, sock_cookie)
> > +               __field(const void *, skbaddr)
> > +               __field(const void *, skaddr)
> >         ),
> >
> >         TP_fast_assign(
> > @@ -285,6 +287,9 @@ TRACE_EVENT(tcp_probe,
> >                 __entry->ssthresh =3D tcp_current_ssthresh(sk);
> >                 __entry->srtt =3D tp->srtt_us >> 3;
> >                 __entry->sock_cookie =3D sock_gen_cookie(sk);
> > +
> > +               __entry->skbaddr =3D skb;
> > +               __entry->skaddr =3D sk;
> >         ),
> >
> >         TP_printk("family=3D%s src=3D%pISpc dest=3D%pISpc mark=3D%#x da=
ta_len=3D%d snd_nxt=3D%#x snd_una=3D%#x snd_cwnd=3D%u ssthresh=3D%u snd_wnd=
=3D%u srtt=3D%u rcv_wnd=3D%u sock_cookie=3D%llx",
>
> If they are useful, at least you should printk those two addresses
> like what trace_kfree_skb() does.
>
Got it, I will add to printk
> May I ask how it could be useful if there is no more function printing
> such information in the receive path?
We can get seq and end_seq by skbaddr in netif_receive_skb, so latency
between l2->l4 can be calculated.
>
> Thanks,
> Jason
> > --
> > 2.17.1
> >
> >
>
thanks
fuyuanli