Received-SPF: pass (google.com: domain of linux-kernel+bounces-86522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>, Tejun Heo <tj@kernel.org>,
        Tom Hromatka <tom.hromatka@oracle.com>, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] cgroup/cpuset: Fix retval in update_cpumask()
Date: Thu, 29 Feb 2024 15:41:14 +0530
Message-ID: <20240229101116.60043-1-kamalesh.babulal@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ghXwvXWZJu3Ji3idirpruk433/0ksErGqFvsuE8HrqNkIoqQ/ifqzqLyr9zU?=
 =?us-ascii?Q?r3Fy8tn7R/eqBy2VSEARVAajI42z/AHdhdOR8+cdIOjJArYqL/Mze7NunON2?=
 =?us-ascii?Q?P4PN3v1NhzCENHQEgZpNEi3wOQ6XJiJlizTyNNJumWIK75OajTv6sl48xhnH?=
 =?us-ascii?Q?MijpjbX2tGwiuKQfMhMOaq5BgUf6XE6vGnEgTHVv4VihbYxIOOV2xmler0fe?=
 =?us-ascii?Q?4coSHe7o1cXKSFk0OYczFtwRWpUEDKbKN/oWY8kvvN0qhs9M21hJazytZOUR?=
 =?us-ascii?Q?mPrtf1fv3aa9Kz+uvhJm4QdRYB8spfl22M9O0M1XlbOoN6FltcrQes2S55A/?=
 =?us-ascii?Q?v6AwLiLtWS105r180VRyCZUWXc60XThr6qXDbWY4jDcnEPlm5jyrKwlwZsLO?=
 =?us-ascii?Q?93Lu9wuZ4o0Q+bK7EWhnFClLAJ0SM2rd3UKYC8e/hCODd7lwTrcl9J/tQ6Jm?=
 =?us-ascii?Q?01SRJ/w/GBsLQB+aCadFQaZYzMK1vgQf5S5O6ZmRG6ME0cj/CYsc+3Q9trzR?=
 =?us-ascii?Q?4hCQRRjJb4Wcst636wuE4zmu2jx6mtXbYc4dwHtaZ0uJSoyoozILWBXPtqSr?=
 =?us-ascii?Q?EuUcDwdGWXZktrG6gufjHVL791wAXZTKweI0KDxcSDYeOnLcXJqSKmdsbxPy?=
 =?us-ascii?Q?bq6RfrxW5IMRiWKrKsgs5IX7RF1pCvtp+T6dr3VxScxcsTQWZyHrroHDIN7T?=
 =?us-ascii?Q?bgaIqrnwMXsbdJawCok/7va83kxN4QibnSizMo9Dc2mMvTFgfgCTmyi3R4Yy?=
 =?us-ascii?Q?uMhmEBXNetjkwnixnYAQkFQ9eUNUzcP/NfKhIGYs6i2P3x0Ng0QP0dKriehc?=
 =?us-ascii?Q?KUTK84bv6Ke+k+ZnJge+v6CeNWJHVzhsghmqtDSJ0NRFDoKNmLMw1HDFcEln?=
 =?us-ascii?Q?v6n1Dw/Lt39Y2aj+rLqB+ChszDhF/uulVjR2VcvKlfLQFleLECsNhFY3tDWJ?=
 =?us-ascii?Q?vB+y0Q6EP/LV+oyw8HHS+L3JvNLoLkNU65FgKpgdjCWNQ4v/h9gxkk6ATxO+?=
 =?us-ascii?Q?npX/YzUv9b0IQpMgy+W+L1JkRK/DFBrsApw2VnpUcFlZ58FuFZbnosOVsens?=
 =?us-ascii?Q?hwyUZ1VTi9BXALYpJDcjYz+PbQjrXlRu1T+ziCfYcwAleQkC2rJhxjDaZ6pR?=
 =?us-ascii?Q?CQPkQCEbTzn51fNhDIUhHXQYrlY5rjwmh4DwR7TTvXyHxJOdxrz1HZPo2ys9?=
 =?us-ascii?Q?P0XrxqmiERdCSMzDzJWPC3kBb3RSbWXckck3tcrvOps/lzeseUYJwINKRI8q?=
 =?us-ascii?Q?5IMGNUX+lVAKGr7p2qmtRoG8sVdxej0Q/2axrZD29EuMPns8Fbwix4E+TS3h?=
 =?us-ascii?Q?u7WCND3h/4q0aTGG19ztvaA/hBlJxbCV0Hr4gGLfwCop3Z1V7pA4RZbsCpjb?=
 =?us-ascii?Q?LibH2eCsvZyXqKrgD/LfHNugwzKUxG5DeZchzPC3fjatWuDgLlWX0yuzrFrf?=
 =?us-ascii?Q?Z0XsH92CPxAIwKA1u4zE59vIpXA+shw2m+OCU0KLNhAEqHWpfIHNMgCa/NeT?=
 =?us-ascii?Q?WAWkwqN/HwyZPYODZ9mhWCgRv+nVJggGWN5DxYHuiXmNOZy+kBDUBsXfmWiu?=
 =?us-ascii?Q?IyJ3iHKyKZZxjOSbnR00xMrq8f17YhYtqu8jMXBhrAYWniWhYoCVb8iIun1l?=
 =?us-ascii?Q?ZQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	F5/0b/MRNH2y4MjW6IJmpwTikagAQZdi22uzc9vAOEQMG6aZa7c9Cm5MV2FWT+sXgwF05Non5/ZSXPvf9bFfBJ+k+4t7FM44fH0XMLSo6Nn8L6qjawXd0z3q4YyfQ598UujaKT7B4lCfyv79QsgF1wwSXp8QdxDLsuaJo9CWA23MiYfzKOUXKkcYcSpZPDad3DPeQ5iAQDrfpS6zYnQ3jcF0sJhPekCy95I5zXCxbiVVLUAlHwfoTp6pNHS2tFsNInaMq8KBj5Y3SWFzjae5Dmu+5qpVsYSGzm/Kfv6ccAVSeNmMyfT8oU+Tokuip0fabxb/de1rfjYm1IYv5LG6FbCQIDz070IqO3eV9F5p0Nn9neti/OGJAzgdQeb2sk47N0ONjrEDgHShkgC0otqfgeWCXa8Obbrd2H1ZQ/6CHMBb6yUX5b1J7IPqhuFXDF3KnxxYA8Oy2bc2L1EO/FqT/YbQ4/KR8SmXEy8zxO2gmSHTHljEMmzgBDEaHxTVMpS9p49JnneUhLzg845S1wJoI1YnnUw61WMq8xinJNnnNPWF6VYqDgaSgbJ0Ivd3j08vM55cAzwOLn7OZVxiJ+QF5MtVqY2ERxm/cHvRmEpFXJM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 607de5c7-6777-448c-b4d2-08dc390edfc1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB7080.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 10:12:02.6917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8RjP8noqipW4hpaYfdXGpz3OepJghLbczsnT9SWYt//DAY1v71encV6MmGmIeuh10lMN4e1vlFUxdVZzQWb8LWqCHa0cqYAML6/QwDbXhdg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4591
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-29_02,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402290077
X-Proofpoint-ORIG-GUID: jIAC-M-2iJgC4AFT_gMs7pdgGrOsSu21
X-Proofpoint-GUID: jIAC-M-2iJgC4AFT_gMs7pdgGrOsSu21

The update_cpumask(), checks for newly requested cpumask by calling
validate_change(), which returns an error on passing an invalid set
of cpu(s). Independent of the error returned, update_cpumask() always
returns zero, suppressing the error and returning success to the user
on writing an invalid cpu range for a cpuset. Fix it by returning
retval instead, which is returned by validate_change().

Fixes: 99fe36ba6fc1 ("cgroup/cpuset: Improve temporary cpumasks handling")
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
---
 kernel/cgroup/cpuset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index ba36c073304a..2ddbfaa4efa9 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2562,7 +2562,7 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs,
 		update_partition_sd_lb(cs, old_prs);
 out_free:
 	free_cpumasks(NULL, &tmp);
-	return 0;
+	return retval;
 }
 
 /**

base-commit: cf1182944c7cc9f1c21a8a44e0d29abe12527412
-- 
2.44.0