Received-SPF: pass (google.com: domain of linux-kernel+bounces-86552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: Will Deacon <will@kernel.org>
CC: Frank Li <frank.li@nxp.com>, "mark.rutland@arm.com"
	<mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, "john.g.garry@oracle.com" <john.g.garry@oracle.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>, "namhyung@kernel.org"
	<namhyung@kernel.org>, "irogers@google.com" <irogers@google.com>,
	dl-linux-imx <linux-imx@nxp.com>, "mike.leach@linaro.org"
	<mike.leach@linaro.org>, "leo.yan@linaro.org" <leo.yan@linaro.org>,
	"peterz@infradead.org" <peterz@infradead.org>, "mingo@redhat.com"
	<mingo@redhat.com>, "acme@kernel.org" <acme@kernel.org>,
	"alexander.shishkin@linux.intel.com" <alexander.shishkin@linux.intel.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v4 5/6] perf: imx_perf: limit counter ID from
 user space and optimize counter usage
Thread-Topic: [EXT] Re: [PATCH v4 5/6] perf: imx_perf: limit counter ID from
 user space and optimize counter usage
Thread-Index: AQHaVAmkRsOhJRfPykqMZw2ffn1WI7EWbCEAgArgIJA=
Date: Thu, 29 Feb 2024 10:29:45 +0000
Message-ID:
 <DU2PR04MB8822DF3B4A9251F18C4E3FD38C5F2@DU2PR04MB8822.eurprd04.prod.outlook.com>
References: <20240131055811.3035741-1-xu.yang_2@nxp.com>
 <20240131055811.3035741-5-xu.yang_2@nxp.com>
 <20240222122438.GD8308@willie-the-truck>
In-Reply-To: <20240222122438.GD8308@willie-the-truck>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?IhXKK23eF4qIU6BiJcnRBLF/w5lq7OLTERfybdf2hRKctGyC/FAZay/mxG3d?=
 =?us-ascii?Q?93w3+Qf6PC4NxwYAAVC37rQCFEP49aQxED0NBEis68/2pCNWA2BUMbjAoJeb?=
 =?us-ascii?Q?Y0o+9Udbj/Z54NS/85Vy5w8YJUP/FrJd8JQTGWHSWmtx9HeHYbwhMdDc8LZ9?=
 =?us-ascii?Q?LMBzN9QZvDCz37Qe+dVrBkf3feYsEfV0RCuRMemDmnsMZI6syefZ/agjGQ6+?=
 =?us-ascii?Q?agcgx/F4N7THH81bIsmcFgITKhYq6wzg6MlpDlHk/KDm2NgAMxrlcb0bOoSS?=
 =?us-ascii?Q?nYhtIJhtQpyy5DiEbGiv6OpFtssWn8xlQBvh0gO3SteZld9azsxQjf4gpbIS?=
 =?us-ascii?Q?eOoi+9Yp4XmygTCF+kqs8LnlOOvL1Pnoab9rnqezw9lV7j0CIYGjJNX18xaz?=
 =?us-ascii?Q?AKOap1lr0revWWJ+HkGXdkVfktQC7ZrcvTmo9GvUjxcUnq3UiyvT/IOA7vYq?=
 =?us-ascii?Q?qlW4afpxg/Hne5ZtpxAZ3ydNvfUBR8+YvJ4qUffGCuDT4DqhM5S/fDg2Opdi?=
 =?us-ascii?Q?S/SWUw8DcK8qS1vLoiY+3MJmDl68CVNWQPmKVkdLiNjVTVf7KJk4hysHYFu9?=
 =?us-ascii?Q?zEaywrMUwcABug5+hyVdpXTgSV2WElgitN8VB0iT8zMG8GTQI9xK8f3YkrmS?=
 =?us-ascii?Q?KRG3j0K7UeX9Js/nhIaa5IfVYnFdz0ygpGhcGUxJmt5ZyQA+A/C568fUdazQ?=
 =?us-ascii?Q?wt0TJJAZI6yl6W4minFmFiaPwc7lnClEAT2jseIOFjhxPoZOk9L87CN/In7Z?=
 =?us-ascii?Q?0pWgbF/t9LFnbbhDqYvlE1yV/yZJQ1TudkRIgJs4OmARyjJFv5EyYxkQYBXf?=
 =?us-ascii?Q?o9OUe0gd5F/AALuGl+JNkuoENsbDGpmuFZVSY+7F0u1j5jTTFoYTB4zX1n7L?=
 =?us-ascii?Q?1WNJnRg4pIWTFL2V94IfB10laFO9P8fQFYnuJnCX7Me7ZDb2fdOEY6ZIMfQY?=
 =?us-ascii?Q?KD0JxwKuVfEsDR4UdXomExmHXvZAdxlJUPatg7s0RPIdgLTV4SPR7XqRaziK?=
 =?us-ascii?Q?+ZesKLuNZyZKKbu+tU88vKPklatUq8UpNyB5gba/YiKaC5kutaBONBhd5gC9?=
 =?us-ascii?Q?bKWbXpojnziW3EuORTEjgxsxZn5Kl0lFq2GgweeEADBsvmeAHVDWjMwD9Qy7?=
 =?us-ascii?Q?x4bMuI7jydfgoq+z5+pHup8KMQdRWTgH2pf2KnHJwWJoTaQvm28AMpEG5u2r?=
 =?us-ascii?Q?1/vvdsfb05TNSBBdif9CGGs9/jSqbTqK8YMF/N32ERrUyfsPaXLh9OtUPQ1O?=
 =?us-ascii?Q?IdceLaU86LVeZGeyqcNkdypyxYzwsgvT+TmVQxVivmCr9eIpK7XuwCPu1Sgq?=
 =?us-ascii?Q?aFJt8XtXFIUXSzd0xNLZUHAgaRqhLndQC6oO5eD+vPLt69kzXTIBV9fEZX6Z?=
 =?us-ascii?Q?R5j5a/fULnfW7RPdA0cJNQLG5uYfK4UPxbtdlERoWRrY5CdjKL6sGy2IBVGh?=
 =?us-ascii?Q?Mlu88FigdEm1nkw9yss3QahAtE9wD8pnIv4wlJxArEiM65Lhv6HTjWSPshs3?=
 =?us-ascii?Q?JO0W2iNJ3//uvPAri+0G5n5GwuIYhdplIlCBgs/6hFLbrBrjS9+2KvSs0QGB?=
 =?us-ascii?Q?SAymaVkS88fh8THjJd4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 271a7a2d-562a-4987-c97b-08dc39115989
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 10:29:45.9114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rXJUDqPZNi+RSPm5ky/eZc09EnDoPOKOmS0w1pck8sl8AmQBwXs1ysk+axtDkTJwpm+NUhdr7vAr3HZlw+QtdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9361


>=20
> On Wed, Jan 31, 2024 at 01:58:10PM +0800, Xu Yang wrote:
> > The user can pass any counter ID to perf app. However, current pmu driv=
er
> > doesn't judge the validity of the counter ID. This will add necessary
> > check for counter ID from user space. Besides, this pmu has 10 counters
> > except cycle counter which can be used to count reference events and
> > counter specific evnets. This will also add supports to auto allocate
> > counter if the user doesn't pass it the perf. Then, the usage of counte=
r
> > will be optimized.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> >  - limit counter ID from user to 0-10
> >  - combine dynamic and static allocation of counter
> > Changes in v3:
> >  - no changes
> > Changes in v4:
> >  - rename ddr_perf_is_specific_event()
> >  - use macro definitions to parse config attr
> > ---
> >  drivers/perf/fsl_imx9_ddr_perf.c | 72 +++++++++++++++++++++++++++++++-
> >  1 file changed, 71 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_d=
dr_perf.c
> > index 94041f06c152..e71496809c52 100644
> > --- a/drivers/perf/fsl_imx9_ddr_perf.c
> > +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> > @@ -51,6 +51,7 @@
> >
> >  #define NUM_COUNTERS         11
> >  #define CYCLES_COUNTER               0
> > +#define CYCLES_EVENT_ID              0
> >
> >  #define CONFIG_EVENT_MASK    0x00FF
> >  #define CONFIG_EVENT_OFFSET  0
> > @@ -240,6 +241,19 @@ static struct attribute *ddr_perf_events_attrs[] =
=3D {
> >       NULL,
> >  };
> >
> > +/*
> > + * An event is either reference evnet or counter specific event.
> > + * For counter specific event, the event count will only be incremente=
d
> > + * on the corresponding counter.
> > + */
> > +static bool ddr_perf_is_counter_specific_event(int event)
> > +{
> > +     if (event >=3D 64 && event <=3D 73)
> > +             return true;
> > +     else
> > +             return false;
>=20
> Just collapse this to 'return event >=3D 64 && event <=3D 73;'

Okay.

Thanks,
Xu Yang

>=20
> Will