Received-SPF: pass (google.com: domain of linux-kernel+bounces-86585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b5bdc455-c0f2-409f-85fb-046ee0406467@nvidia.com>
Date: Thu, 29 Feb 2024 10:53:28 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmaengine: tegra186: Fix residual calculation
Content-Language: en-US
To: Akhil R <akhilrajeev@nvidia.com>, ldewangan@nvidia.com, vkoul@kernel.org,
 thierry.reding@gmail.com, digetx@gmail.com, dmaengine@vger.kernel.org,
 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240229065223.7295-1-akhilrajeev@nvidia.com>
From: Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20240229065223.7295-1-akhilrajeev@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3JaM0Iyc29iYVVKMkpBbmF5VW9mM1RHeEovK082MHBRNkI4V05Wb3Vva3VX?=
 =?utf-8?B?WEpVMDVNbWg2M2dkdlZVZnNWa0htM3o0OXFXT1o2Qm5uZlpjOTlzTDlXOGxl?=
 =?utf-8?B?Sms3aHJ6U21VRE81cGQvVzFVZTlQV21EWFd1azNNUEtyRlRjeHZEaS9ZVEJa?=
 =?utf-8?B?RU1JTkRrM21hZHhOV0FZM2tWZlZwZ0s5MFJBcEtyb0gzcW9DN0pwK3JnOSta?=
 =?utf-8?B?WTh5T3IwQ1ZObGRHczRkM29GYzBlNnh2UGp2VmZwMjYyMnB0UndOUytpVHJq?=
 =?utf-8?B?cWt2ekZGWmR4UmhHYU9ZTEgvRmJvRmJPYnFCVGZaSDI5S056SFdxcHpKMHFt?=
 =?utf-8?B?NU1xNUI2amFqajRtam9UeU9Gbko4aUJEMUJIb2tMRk41UEs3NUJkQ29aUDFH?=
 =?utf-8?B?OUNNbWxEdTYwSkpNUHlCb2xYRlJvVmxVZmUrR0hjaElzc3hZVjc0MXA1cHZN?=
 =?utf-8?B?QVlSUGhEOFJVS2RERGRjR0VYajBVaWMxaUZJazZHYXlBOEs3cEZUcXZDMzdX?=
 =?utf-8?B?Uy9xVExFdkhaMTlUUWtnblY5OHowMXlvS1Myelhzdlp0cU41UHcrdkhlS0c1?=
 =?utf-8?B?R3IwMmNPOFhlK0tJeFh3VWJXRE5MSlV2WU02MlZLUkJ0SDUxNzJBbHVPNjh3?=
 =?utf-8?B?UXJBNVRlZUZMa01LQTN6TjljOURFeVREMFRnZnZLZHNFRGMwOUpKYmJ5Wklx?=
 =?utf-8?B?QTkwSDAzSXMyUmk3VEorOWcyNzBjNHJzbld5NktQL3ZINWJRQzI2bWVpdVY0?=
 =?utf-8?B?Sk9qTmlRUWllK3JyK1V6eTE2Z1hNZm1RcXhJTDg4aWM2Sy9McU1rWHFtRVVN?=
 =?utf-8?B?NFhPNVVvbFRKMHdwRmRsZndqOXJxR3hOOXRlQVdxUGFlVG44SnREajNWenBF?=
 =?utf-8?B?SzJuUDdldDhTRUcrY3ZQZndnb2ZuSjdKbHFMQXdDVGp6NytCVGNnbVMxTjlC?=
 =?utf-8?B?UjdSVllrTU1TZFdDc1JaaDJSOE1hSW1vR3pzd0dSc1EvTXMvenl2MkY2OWhl?=
 =?utf-8?B?NnRPT01xS3JMdzI3ZkRDaWFFZWZkeHJjQ2lsVHJtaGRRWEVLMG5qN2JOVnNY?=
 =?utf-8?B?ZUdRL3NLbHh2WGJvQlgzMjRmVnMvM3I5UXRHUnVOTXBnMXY3M3ZkU2xyWWNZ?=
 =?utf-8?B?bHZZZzgzb2t6c0JFaHVYNGVUZnNXdzRtR1lBRW1mWUpZVkNoam1mbVdEK1I4?=
 =?utf-8?B?WHNHTk4zeW1VVmpsUlI4R0pNRFhnK2ZxVUdkQkRTNDR4QjhUNFRoUnJFV2RK?=
 =?utf-8?B?KzZoY0gyY1NaeHZ6eGg2MnVVN2N2SFJHMG1oTWJTV2s0ejQwalkyQWdJYStv?=
 =?utf-8?B?dHhVWnFrOG8rakpKY0RtMjVuaXN3eCtzV2Nhd1VvZzhIM0dOQUxaRmJQMU9a?=
 =?utf-8?B?cEVPUnIxeXp1MHljWmtHOTFmaTIwdTJFR0VMUXJSNUVLU0h3U0ZvNUJEQ3Uw?=
 =?utf-8?B?L1NMeUNDMGlwa09HWXZVMnRHY2twdmM3QUxTK2luMGRBQ0NLOFd4SlhCRmpH?=
 =?utf-8?B?SWpHYVhKUHFCNTZLa3I0TTFabzR1dFZ4VDQvU2FiNTd4WjBTSVhWTjJxam45?=
 =?utf-8?B?VWVsaStvbk5BMGh0QTRsSlNFeXBrMkpDaHNidHJ4dHB3cHVtdkFRVkVHQ2pL?=
 =?utf-8?B?L2tiYWRrWlZNVW8wY2ZhM3lWZzhRTWp2S04vbTJvSDhCK2lDMkFqOU43UEVW?=
 =?utf-8?B?TVVCd2NNRkMyclJhSUdZazF4LzNobGovMlZzV1RwSzAzVUphT1hacy9BSzM1?=
 =?utf-8?B?KzFpa25ldGpzMHdTQ2JUTitJaXFmLytrY3drNmd4c09HRVhTMHJxOEFuQ0ho?=
 =?utf-8?B?MmIrdExmL05OOUJvSm9YdWx3L0hMWTlsRjJPcTRmQi8rUm9sQUQxT0R3TE5F?=
 =?utf-8?B?VU5Cc09hb3Z0QWdKb21uQ3U0ZEdVZDFmajJ2b2poN085eHYybXFRckJkbzBL?=
 =?utf-8?B?WTNiT1dBS3lTUGxQSHlTVlNPMHRtSFJzZmJMc3hJYlN2TkloUEkwWVo5T3ly?=
 =?utf-8?B?aGdGdjFJS3gydU1seXNQRXNqQXp0aG9maE43NU1BbHVlQmVVNmZmaXE1WE5i?=
 =?utf-8?B?bjNYUEFnT3FTMUNnZnAySnVCVUJrVW9MakZFM1hxUTAvZGtwWWgxQUNRUmFw?=
 =?utf-8?Q?7+3xbTNLFin4T271l7NtSQrWe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4125689d-9139-4e2b-8aee-08dc3914ac41
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 10:53:33.4417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FGq/jJNFUSUqQ6jPwZNQlJpHTsQkr0vr94RwNyWyV0nzYj2RnELHxZH2ttmb+6+OsTQQnhDvkIkJU7AF7x/lSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7602


On 29/02/2024 06:52, Akhil R wrote:
> The exisiting residual calculation returns an incorrect value when

s/exisiting/existing/

> bytes_xfer == bytes_req. This scenario occurs particularly with
> drivers like UART where DMA is scheduled for maximum number of bytes and
> is terminated when the bytes inflow stops. At higher baud rates, it
> could request the tx_status while there is no bytes left to transfer.
> This will lead to incorrect residual being set. Hence return residual as
> '0' when bytes transferred equals to the bytes requested.
> 
> Fixes: ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>   drivers/dma/tegra186-gpc-dma.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
> index 88547a23825b..3642508e88bb 100644
> --- a/drivers/dma/tegra186-gpc-dma.c
> +++ b/drivers/dma/tegra186-gpc-dma.c
> @@ -746,6 +746,9 @@ static int tegra_dma_get_residual(struct tegra_dma_channel *tdc)
>   	bytes_xfer = dma_desc->bytes_xfer +
>   		     sg_req[dma_desc->sg_idx].len - (wcount * 4);
>   
> +	if (dma_desc->bytes_req == bytes_xfer)
> +		return 0;
> +
>   	residual = dma_desc->bytes_req - (bytes_xfer % dma_desc->bytes_req);
>   
>   	return residual;


Thanks! Apart from the typo, looks good to me ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic