Received-SPF: pass (google.com: domain of linux-kernel+bounces-86644-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <14aca96c-7525-486c-8f7c-accaddd41456@oracle.com>
Date: Thu, 29 Feb 2024 12:44:03 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Content-Language: en-US
To: Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Leon Romanovsky <leonro@nvidia.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
        Itay Avraham <itayavr@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
        Saeed Mahameed <saeedm@nvidia.com>, David Ahern <dsahern@kernel.org>,
        Aron Silverton <aron.silverton@oracle.com>,
        Christoph Hellwig <hch@infradead.org>, andrew.gospodarek@broadcom.com,
        linux-kernel@vger.kernel.org
References: <20240207072435.14182-1-saeed@kernel.org>
 <20240207072435.14182-3-saeed@kernel.org>
From: Vegard Nossum <vegard.nossum@oracle.com>
Autocrypt: addr=vegard.nossum@oracle.com; keydata=
 xsFNBE4DTU8BEADTtNncvO6rZdvTSILZHHhUnJr9Vd7N/MSx8U9z0UkAtrcgP6HPsVdsvHeU
 C6IW7L629z7CSffCXNeF8xBYnGFhCh9L9fyX/nZ2gVw/0cVDCVMwVgeXo3m8AR1iSFYvO9vC
 Rcd1fN2y+vGsJaD4JoxhKBygUtPWqUKks88NYvqyIMKgIVNQ964Qh7M+qDGY+e/BaId1OK2Z
 92jfTNE7EaIhJfHX8hW1yJKXWS54qBMqBstgLHPx8rv8AmRunsehso5nKxjtlYa/Zw5J1Uyw
 tSl+e3g/8bmCj+9+7Gj2swFlmZQwBVpVVrAR38jjEnjbKe9dQZ7c8mHHSFDflcAJlqRB2RT1
 2JA3iX/XZ0AmcOvrk62S7B4I00+kOiY6fAERPptrA19n452Non7PD5VTe2iKsOIARIkf7LvD
 q2bjzB3r41A8twtB7DUEH8Db5tbiztwy2TGLD9ga+aJJwGdy9kR5kRORNLWvqMM6Bfe9+qbw
 cJ1NXTM1RFsgCgq7U6BMEXZNcsSg9Hbs6fqDPbbZXXxn7iA4TmOhyAqgY5KCa0wm68GxMhyG
 5Q5dWfwX42/U/Zx5foyiORvEFxDBWNWc6iP1h+w8wDiiEO/UM7eH06bxRaxoMEYmcYNeEjk6
 U6qnvjUiK8A35zDOoK67t9QD35aWlNBNQ2becGk9i8fuNJKqNQARAQABzShWZWdhcmQgTm9z
 c3VtIDx2ZWdhcmQubm9zc3VtQG9yYWNsZS5jb20+wsF4BBMBAgAiBQJX+8E+AhsDBgsJCAcD
 AgYVCAIJCgsEFgIDAQIeAQIXgAAKCRALzvTY/pi6WOTDD/46kJZT/yJsYVT44e+MWvWXnzi9
 G7Tcqo1yNS5guN0d49B8ei9VvRzYpRsziaj1nAQJ8bgGJeXjNsMLMOZgx4b5OTsn8t2zIm2h
 midgIE8b3nS73uNs+9E1ktJPnHClGtTECEIIwQibpdCPYCS3lpmoAagezfcnkOqtTdgSvBg9
 FxrxKpAclgoQFTKpUoI121tvYBHmaW9K5mBM3Ty16t7IPghnndgxab+liUUZQY0TZqDG8PPW
 SuRpiVJ9buszWQvm1MUJB/MNtj1rWHivsc1Xu559PYShvJiqJF1+NCNVUx3hfXEm3evTZ9Fm
 TQJBNaeROqCToGJHjdbOdtxeSdMhaiExuSnxghqcWN+76JNXAQLlVvYhHjQwzr4me4Efo1AN
 jinz1STmmeeAMYBfHPmBNjbyNMmYBH4ETbK9XKmtkLlEPuwTXu++7zKECgsgJJJ+kvAM1OOP
 VSOKCFouq1NiuJTDwIXQf/zc1ZB8ILoY/WljE+TO/ZNmRCZl8uj03FTUzLYhR7iWdyfG5gJ/
 UfNDs/LBk596rEAtlwn0qlFUmj01B1MVeevV8JJ711S1jiRrPCXg90P3wmUUQzO0apfk1Np6
 jZVlvsnbdK/1QZaYo1kdDPEVG+TQKOgdj4wbLMBV0rh82SYM1nc6YinoXWS3EuEfRLYTf8ad
 hbkmGzrwcc7BTQROA01PARAA5+ySdsvX2RzUF6aBwtohoGYV6m2P77wn4u9uNDMD9vfcqZxj
 y9QBMKGVADLY/zoL3TJx8CYS71YNz2AsFysTdfJjNgruZW7+j2ODTrHVTNWNSpMt5yRVW426
 vN12gYjqK95c5uKNWGreP9W99T7Tj8yJe2CcoXYb6kO8hGvAHFlSYpJe+Plph5oD9llnYWpO
 XOzzuICFi4jfm0I0lvneQGd2aPK47JGHWewHn1Xk9/IwZW2InPYZat0kLlSDdiQmy/1Kv1UL
 PfzSjc9lkZqUJEXunpE0Mdp8LqowlL3rmgdoi1u4MNXurqWwPTXf1MSH537exgjqMp6tddfw
 cLAIcReIrKnN9g1+rdHfAUiHJYhEVbJACQSy9a4Z+CzUgb4RcwOQznGuzDXxnuTSuwMRxvyz
 XpDvuZazsAqB4e4p/m+42hAjE5lKBfE/p/WWewNzRRxRKvscoLcWCLg1qZ6N1pNJAh7BQdDK
 pvLaUv6zQkrlsvK2bicGXqzPVhjwX+rTghSuG3Sbsn2XdzABROgHd7ImsqzV6QQGw7eIlTD2
 MT2b9gf0f76TaTgi0kZlLpQiAGVgjNhU2Aq3xIqOFTuiGnIQN0LV9/g6KqklzOGMBYf80Pgs
 kiObHTTzSvPIT+JcdIjPcKj2+HCbgbhmrYLtGJW8Bqp/I8w2aj2nVBa7l7UAEQEAAcLBXwQY
 AQIACQUCTgNNTwIbDAAKCRALzvTY/pi6WEWzD/4rWDeWc3P0DfOv23vWgx1qboMuFLxetair
 Utae7i60PQFIVj44xG997aMjohdxxzO9oBCTxUekn31aXzTBpUbRhStq78d1hQA5Rk7nJRS6
 Nl6UtIcuLTE6Zznrq3QdQHtqwQCm1OM2F5w0ezOxbhHgt9WTrjJHact4AsN/8Aa2jmxJYrup
 aKmHqPxCVwxrrSTnx8ljisPaZWdzLQF5qmgmAqIRvX57xAuCu8O15XyZ054u73dIEYb2MBBl
 aUYwDv/4So2e2MEUymx7BF8rKDJ1LvwxKYT+X1gSdeiSambCzuEZ3SQWsVv3gn5TTCn3fHDt
 KTUL3zejji3s2V/gBXoHX7NnTNx6ZDP7It259tvWXKlUDd+spxUCF4i5fbkoQ9A0PNCwe01i
 N71y5pRS0WlFS06cvPs9lZbkAj4lDFgnOVQwmg6Smqi8gjD8rjP0GWKY24tDqd6sptX5cTDH
 pcH+LjiY61m43d8Rx+tqiUGJNUfXE/sEB+nkpL1PFWzdI1XZp4tlG6R7T9VLLf01SfeA2wgo
 9BLDRko6MK5UxPwoYDHpYiyzzAdO24dlfTphNxNcDfspLCgOW1IQ3kGoTghU7CwDtV44x4rA
 jtz7znL1XTlXp6YJQ/FWWIJfsyFvr01kTmv+/QpnAG5/iLJ+0upU1blkWmVwaEo82BU6MrS2 8A==
In-Reply-To: <20240207072435.14182-3-saeed@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Z3doc1VQcDI0RUtGcGlTWTF0UW8yYzkraFpZb1lNOWZDR2NFY3oyNFBiR2hs?=
 =?utf-8?B?ZjM3S3pzN0xFK25nblAzNkFMbFhRc09YRy9tZlNJSmtWUTR3UDR6cFZHcVg2?=
 =?utf-8?B?cE4vN1Y3czBFV3VpWUs4L3FUNHVMOHpQcGVKSmhZcGFiY0JtTVROd0tSakhx?=
 =?utf-8?B?ajByZEp3a0ZJbUpXL3dudk9KVG9UaHU3KzNQVkpaTUZRZXFHbkcwdkU1R2Jp?=
 =?utf-8?B?b3lBWGFoZitRenMyK1VRZ28yTDdRaHlLWGlsSkJhRk03d0JjeHh1dGVDQjJV?=
 =?utf-8?B?ZnRsRmwwVUZ1RmlxcWMzeWFLemFKZUFOeGxWRmhhYjUyOXNSdU5PaStPN3B2?=
 =?utf-8?B?QTE5K2d6Z2t3bmhGLzY5VE9CTS92Wk9oTlBuazhRbUkxSmc2Qnd3SFdjM1B4?=
 =?utf-8?B?eFh2NWxudXBKaHBjTnFBUUlEdlFJaDFiM21lZ2dXd2xJMER0SEtub0hENzAx?=
 =?utf-8?B?Y3o0WnhpMitzMUlsZjZRWFZDRGJiVEJrTXRtSk5YNU1OYmFwZXFLOWxHc0NS?=
 =?utf-8?B?Y0tjN2FYY0xlK1Q3aHFtaWtHK0lwOC9iM3NMWjRhd3ZsVk1CMkJWbkJVakFy?=
 =?utf-8?B?SVRzTERzOFdkQXc2dERGT2lJb3JqczR4SDA2SVNhUmJOdmNLM0hlS0xvaE93?=
 =?utf-8?B?TGdsMkJ5b3BBa3FPNDRBYmJ2L2hiZ2ZnWFBKalRReGZKK0xMN2JwNUhVYU5v?=
 =?utf-8?B?MUxjMWVoTDV5aUgwdklqMGJMRDh0NE9oaVFRclNnSEREU25XS2xWUE1EQ0hx?=
 =?utf-8?B?N0xEM3FiRk5GMHd5emVmcmpxalMzbjlIYzRyYmRVUFNkajdFbWhPb1BlQjJQ?=
 =?utf-8?B?cGpPbUZabmVCTTZvRnBEUjdmWEpqbStPNTZQTEtKcXBSSVlyOGplWThYTXRI?=
 =?utf-8?B?OC82UjdKMU9zbFJqZXVLRndrRE8rcTliN3lsam81L3hoa1Z3a0trdTdHZklI?=
 =?utf-8?B?Y010elpLZUppWGRKS1NPRDhLUTduNERhVmtGSmhzeDZxK1NwaThMTllpSXEy?=
 =?utf-8?B?akZuQ2d6cTNidE5ONTlBbjBWK0RUWThMNDQ1amw5TklQZGVvMHBsdk9pRGhw?=
 =?utf-8?B?NlBnMlU1WDlXc280Q3ZMZ1Z5OUZPSloxYWFFQWtlSmJXb0RPQ1ZOSmExUno1?=
 =?utf-8?B?TVNReG0wOFhvN2hqRkJXNVBDM2ovVG91dGJDYzIwcEtWNHcyVWU3S0phVjRH?=
 =?utf-8?B?Q0dvTnMra0tCYTVDREZHeWxQZWdzeExUVDloWUtkaXpSZ3d4V0xJd05OYWEw?=
 =?utf-8?B?bmFoVHFacWZpOThPSjRBQzgxV0xGeU9lZ0U3OHM2NER1b3hGQlRVVEFzakpW?=
 =?utf-8?B?TXNUekVXUHBCaytPOThSSDRGeitHSnZ5MXhDTGc4M0RIVVRsSlZzM2RnT3Zo?=
 =?utf-8?B?WXpsZkJVMmVZdVdvQXliWHRiN0Q2ZWNodjdabWlSUXBtZTNQd1AzVnBCcXRV?=
 =?utf-8?B?YllDS0RKb3JMU0JxOS9sdG5YSEsvZmJoR3RoUGU0cEhzanNyUUpOaGNPVEhQ?=
 =?utf-8?B?anRBZE9KMjJ4Z0xIQUxQOVV2NjJ5cU5Wb2UzOVVJbTBTR2NZQlBhYkVuWWky?=
 =?utf-8?B?a0o2ZjVuaEI4bE05bTUwNmtTMlZwSk9RU2kyUjh1NTlNTS9zdGM3dkJhMXZP?=
 =?utf-8?B?Rm9jeEptaGc1SHZIeTNmaU9yV0E1UFNVUFppQU1ZdmVLaklPb0NGWGZyWXRE?=
 =?utf-8?B?WEd1RWhnN2w2U2lDblh1OExpYWlMdG43US9CVDZDTW0zNWh1Nk9LT01kaklm?=
 =?utf-8?B?YzduZEFrc1V6WDJiWGJuTlBPa1pIdGNOOVRGUHcxMElZYWRHUU5CQm4xanhX?=
 =?utf-8?B?UmhwSEZjM3dleldSMFR2UnByZ01xTU9wNllOSDcyK2E5bzZvMytxamlEQ211?=
 =?utf-8?B?WVdZTWxjRWNlMDVTOUZUUGU2NHhSQ216aTFlM1pXRERSRVRjQjFWQzJ3NXYw?=
 =?utf-8?B?dW9OemxmVjJXZk1aWGtoaThCUU4wY2o3WlUrazlhZFQ5SDdLSWlJSDZoZXcr?=
 =?utf-8?B?N2dFYVhQUDgybjU3eTdCTjRuTjAyamhCbDZFcUtQMVFUYnhaSEJLWWI3cnRj?=
 =?utf-8?B?ZTd0RXRpY0xuMFEwRnlLcXloMldNcXJTNzcrejJPcU1qeWt0bjh5Q3c2SlZH?=
 =?utf-8?B?RkNDL3c3WkFPOFNuendUTHczUjRJejV0Q0dScjkrcHFmSStQbDVRMFBCbXI4?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	G4S0Lp+9ZncGwFleOS0/fwtJzSlgePeDtTDJtZzF1PdnhGp3MlMXeYfvcfM/Csb1+YZs8RuyxGXsdTAqYapEEmr/po9yZ2eziN2Ng6xHq46YMuxCSO6fCoBraI6m+LryBMB+VzvNe92rBSVfD2l2oPN2AcnH2JQGAkXD1z/oChIvn5F4J758LahY2Sl2cY6pCCnMEpivyzc/fNRMNiioHLXD7PUJ2Q63K6rBNpuLq+TxCn+iI1JzvP4IVeH8N9umEl9cJS5CYQ0FS7piGmEJms2iiDNU2lsi56gUlLjh0p3uEwUu77LDGESjJQY8Ebj9iMt0HCY8hD/GTM7+u2HVzDmDpUARaBx3gpPnAIJ/X1Vq2l0QGJTuGRvRMtrS8aKmc6Ts58T6nCnut2ejkFKOtGRFtoF4aAxlPyDOI/vWCxDIA6p6GfxnrDV4U9GqNVJyNBy9Nxln38cfL5VwNyQRk5eZy09/sHcfx5AJqwzPNH5hs6Rj5VaO7mgL+vuW7g4uVOHGv6sQMtKu5mhwPPLvKgecfB6O5PMIRQsuf0lDIyp0SdQtIj1Izpv0iMoTgAe7WN9MHbTV8tXOX3c+DfGk1iQEhzv6fZ3HsDy2LCcG3Io=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5645f898-91d4-470f-7edf-08dc391bbf5f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 11:44:12.0215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6JXUDL2p/RPSB16w6kliWUEHZu7qJJtrhJY5FZVRnRVcx9IcsIQ9MbBHluzdBtgJ5/XP/VxdN+PbgZCGcpKrez46pXg+8DjNO6w/Ct/Je0Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7242
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-29_02,2024-02-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0
 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402290090
X-Proofpoint-ORIG-GUID: jebsG2lefmG5ilHVkXJmIDWkEVOoEkEJ
X-Proofpoint-GUID: jebsG2lefmG5ilHVkXJmIDWkEVOoEkEJ


On 07/02/2024 08:24, Saeed Mahameed wrote:
> +static int mlx5ctl_open(struct inode *inode, struct file *file)
> +{
> +	struct mlx5_core_dev *mdev;
> +	struct mlx5ctl_dev *mcdev;
> +	struct mlx5ctl_fd *mfd;
> +	int err = 0;
> +
> +	mcdev = container_of(file->private_data, struct mlx5ctl_dev, miscdev);
> +	mcdev_get(mcdev);
> +	down_read(&mcdev->rw_lock);
> +	mdev = mcdev->mdev;
> +	if (!mdev) {
> +		err = -ENODEV;
> +		goto unlock;
> +	}
> +
> +	mfd = kzalloc(sizeof(*mfd), GFP_KERNEL_ACCOUNT);
> +	if (!mfd)
> +		return -ENOMEM;

goto unlock?

Or why not reorder so you always allocate this before doing anything else?

> +
> +	mfd->mcdev = mcdev;
> +	err = mlx5ctl_open_mfd(mfd);
> +	if (err)
> +		goto unlock;
> +
> +	spin_lock(&mcdev->fd_list_lock);
> +	list_add_tail(&mfd->list, &mcdev->fd_list);
> +	spin_unlock(&mcdev->fd_list_lock);
> +
> +	file->private_data = mfd;
> +
> +unlock:
> +	up_read(&mcdev->rw_lock);
> +	if (err) {
> +		mcdev_put(mcdev);
> +		kfree(mfd);
> +	}
> +	return err;
> +}


Vegard