Received-SPF: pass (google.com: domain of linux-kernel+bounces-86696-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com>
Date: Thu, 29 Feb 2024 14:23:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are
 reset
Content-Language: en-US
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de,
 andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240229084555.43701-2-arturas.moskvinas@gmail.com>
 <CAMRc=MfTo7MnfMhRQsjeFsLv3yjEtP0C3ytqACN+nuGw0Sr-Bg@mail.gmail.com>
From: Arturas Moskvinas <arturas.moskvinas@gmail.com>
In-Reply-To: <CAMRc=MfTo7MnfMhRQsjeFsLv3yjEtP0C3ytqACN+nuGw0Sr-Bg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2/29/24 10:54, Bartosz Golaszewski wrote:
> On Thu, Feb 29, 2024 at 9:47 AM Arturas Moskvinas
> <arturas.moskvinas@gmail.com> wrote:
>> Chip outputs are enabled[1] before actual reset is performed[2] which might
>> cause pin output value to flip flop if previous pin value was set to 1 in chip.
>> Change fixes that behavior by making sure chip is fully reset before all outputs
>> are enabled.
>>
> Use imperative mood in commit messages - make it: "Fix that behavior
> by making sure ...".
Chip outputs are enabled[1] before actual reset is performed[2] which might
cause pin output value to flip flop if previous pin value was set to 1 
in chip.
Fix that behavior by making sure chip is fully reset before all outputs are
enabled.

Bartosz, does this look better?

Arturas Moskvinas