Received-SPF: pass (google.com: domain of linux-kernel+bounces-86751-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240229084555.43701-2-arturas.moskvinas@gmail.com>
 <CAMRc=MfTo7MnfMhRQsjeFsLv3yjEtP0C3ytqACN+nuGw0Sr-Bg@mail.gmail.com> <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com>
In-Reply-To: <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Thu, 29 Feb 2024 14:25:48 +0100
Message-ID: <CAMRc=Mf__-sbAV0xuC2hsxm_-kQWqgxSLRYLKqt9-ce+8_Kf_w@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset
To: Arturas Moskvinas <arturas.moskvinas@gmail.com>
Cc: linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de, 
	andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 1:23=E2=80=AFPM Arturas Moskvinas
<arturas.moskvinas@gmail.com> wrote:
>
>
>
> On 2/29/24 10:54, Bartosz Golaszewski wrote:
> > On Thu, Feb 29, 2024 at 9:47=E2=80=AFAM Arturas Moskvinas
> > <arturas.moskvinas@gmail.com> wrote:
> >> Chip outputs are enabled[1] before actual reset is performed[2] which =
might
> >> cause pin output value to flip flop if previous pin value was set to 1=
 in chip.
> >> Change fixes that behavior by making sure chip is fully reset before a=
ll outputs
> >> are enabled.
> >>
> > Use imperative mood in commit messages - make it: "Fix that behavior
> > by making sure ...".
> Chip outputs are enabled[1] before actual reset is performed[2] which mig=
ht
> cause pin output value to flip flop if previous pin value was set to 1
> in chip.
> Fix that behavior by making sure chip is fully reset before all outputs a=
re
> enabled.
>
> Bartosz, does this look better?

.. if previous pin value was set to 1 period

Bart

>
> Arturas Moskvinas