Received: by 2002:ab2:2997:0:b0:1ec:cbc4:63fb with SMTP id n23csp435023lqb; Thu, 29 Feb 2024 05:34:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXPaI7ymXmvYHZNpwDI0BdiAUpRCFXvhDTE/8ANA+l95QIzHBOclyKUC0TXlZGg6gtlmIf+xSTBnlqE73tYMT8hFPH1x+FfhgnQdMQ9aw== X-Google-Smtp-Source: AGHT+IFsIkqh/aMc9DSqrLHmGfbmBEyzIPhfctBrgi9VPIWmtavldDf/QNNRFP1Dixscs2uAEms3 X-Received: by 2002:a67:cd87:0:b0:472:7511:5076 with SMTP id r7-20020a67cd87000000b0047275115076mr1625289vsl.20.1709213697709; Thu, 29 Feb 2024 05:34:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709213697; cv=pass; d=google.com; s=arc-20160816; b=hvAmciLJTwn39buviy30hFKsdRwiUMU3konvSUOZ2pfqi+sCU8MWL0xuVLU/tyxuOA gtHY4MGpeb+z/eNEI8qQ2+YKw3NXXwp1/qfNGyp6iD/wGS2ZZ72CmAagTyf1HLLCzzbn ogdF0d0H9BHKlSZDV1BYLxByjypmwlsCwcwXlvYUSCpjFSZ+JbHyWCinxOLO1SNWmBX+ AlkeYvdIhpcDTvLIXSMpOLrK94gIGU8C5b4jaDhAykR8GLMctVawqG+2JG64brST/1SJ PYdc2Toy1RnyIu9gC2AD4DSNSVr/LOa7kRF1PnAAofLx/KB2MxpnRgGBY3lMEpmlD53q 6noQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=eTfLJyTcpdwpsuN8unpr2XZZEd0IJSDdAW3OCgpy0zE=; fh=0WbZblER/gGlQr/aKcMEMxgI1f6RoshLH3byXwyvnpU=; b=Up6iSpNFEDdEp6xCOwgGd+OSI27WLCB3+lTySHZBHXztpdX8FYkIeFIUB7xt7w8Xqi Imeq6sZ7e/0DnGGWcyR30vK7B7WdSREmyHuh5B/XF7d2xbJDqpbyqpdTScXDNmIWeCLs 2BSapE6NJW0CbgYq5y0LKz8HTJxcvzFyHHbLutuGG6GBJ4a1MqeVQla/T+7yQQjp5ajn cVZ2xRUgAFpgc+CG9WDwPUw5+CN3/A+nfPUoHX7riDSoaecwUcGL8cMhj2jFacdZGMtv 6zsRQIOx4OxM+jBFIzymNdg72D4ayTnP+bsuN5sVYqRahtd73mSyTn46WBnuEVvdzPRy LPLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rYTHdjbe; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id z10-20020a67ec4a000000b0046d67d868f6si128286vso.664.2024.02.29.05.34.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:34:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rYTHdjbe; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86758-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6E3D91C219E9 for ; Thu, 29 Feb 2024 13:34:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F22382D92; Thu, 29 Feb 2024 13:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rYTHdjbe" Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB4F17E566 for ; Thu, 29 Feb 2024 13:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213690; cv=none; b=I+53rmFVn8T1GRmikGTb3BaYEihpOOHO2SElvm9g5PJV8fkSmMQv8ybPsleubYQsfc82/XsrvNiuiWVrTxj6UyO8t0inVDPMioG2MdN4i1wyFpKUwc9JdOAu7Ud56Mh6vMGOJv/fg0mAirQj11AUsIe6yFJdFYbx5xsGUOFAfD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213690; c=relaxed/simple; bh=eTfLJyTcpdwpsuN8unpr2XZZEd0IJSDdAW3OCgpy0zE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bFBjSXwau+YzBC7wdM8I5SSe+FNEWyy5PxUpFH0tc+ne05J6a5gh+mtVsRXGoW5B+2Wkv75wxy4EdBhGnfMKgh+b8ZbvbmtEp3/9PBO1FvkDe4wX66QdQSqdOqEsjnrSogo3bVDEU7/iQK3bd8StOcda7JkrX1fMNtofzH4x+Ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rYTHdjbe; arc=none smtp.client-ip=209.85.219.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dcbef31a9dbso712581276.1 for ; Thu, 29 Feb 2024 05:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709213687; x=1709818487; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eTfLJyTcpdwpsuN8unpr2XZZEd0IJSDdAW3OCgpy0zE=; b=rYTHdjbepJHMdVjx9Imtk329wSoXnJZBxYtV726m28GV/V7gkGQXPfFJS2NlI0S+Z3 pXj8RmkMOPs3Jb8OVqphW3Napgbwm1MIUNERMqYj4NC7ltvi8pWlz+H7gayZ6OINuFIs 2OVx+oS+NV3eE2ZEX02/Rm9ABRCLur7+SmPKQ9hKv4p7d2wFX/CJXyoayu9c+vgIBTzW 8wK5fPlhwVYHyYN2E86WCIwXywoAeodSrA5Fseo5fERoN2K9XEyGZOQw5KPl57WMELqa EfxraAKLsT0oNEysbw6hjhZJblor543ZwdklXGAAb1Tl4oYZgENGAgeCEVQK+lmfcI54 1h2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709213687; x=1709818487; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eTfLJyTcpdwpsuN8unpr2XZZEd0IJSDdAW3OCgpy0zE=; b=vrVfYHCFqx7Go4hO7jkUZMCZAlMRxTZOQDQcRstK5lw8nwsKLDBMviCcyjVp2Ec1KX QPQ7I4pShGhk3AUx7BYde7r4ukdy3UgbwpBfn0fg6kuoCxooNRt9wBTTwKkSZ72ZUng9 6bHVJ7PAICoukrgpVlKcdqDgOnOLsELA3lQ6SsQ8WvmAq9Swcc8VNTshkaijD0KDMegL +c3JEKyNQU7R3qqVta9ZW9cyke1F4BIHqfhrmxATpdm3uSzUgYQx89cbIcwLQzDWhhb3 p8cx8EyvfwsI8/9mlt/qxSX+faPGImviuH7fBwijVkYt4C7F+daksQGEbdh5OcZwLpza HfoA== X-Forwarded-Encrypted: i=1; AJvYcCWZXVa2Nfubs8CfhjXMDFN+PJI36O+9tyHL6bpqJmsYvH9RP6hqRaX8OBt+KN0GL+buF58y261zoWPdGcZpbfNt6m8DCMFTFW3dwyBO X-Gm-Message-State: AOJu0YwbsFfh1tru0nheLMynyDNlbRV3QnJjGcnHvNisfdmILvsh97+r B8u98hDI3G6K9a2RZk9lbA4VUdFrwRmQOFt7468mC4aOX3TgmtLrtyd+56PJaZuWxFru5EX8xOy rJhpOP7FSot+SG8OfTtHvt2mPwk0nSiQ7xs2SMw== X-Received: by 2002:a25:a347:0:b0:dcf:b5ba:1403 with SMTP id d65-20020a25a347000000b00dcfb5ba1403mr2165256ybi.6.1709213686916; Thu, 29 Feb 2024 05:34:46 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240131055159.2506-1-yan.y.zhao@intel.com> <20240131055740.2579-1-yan.y.zhao@intel.com> In-Reply-To: <20240131055740.2579-1-yan.y.zhao@intel.com> From: Linus Walleij Date: Thu, 29 Feb 2024 14:34:35 +0100 Message-ID: Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead of VA in pfn_to_virt To: Yan Zhao Cc: arnd@arndb.de, guoren@kernel.org, bcain@quicinc.com, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 31, 2024 at 7:27=E2=80=AFAM Yan Zhao wro= te: > Apply the page shift to PFN to get physical address for final VA. > The macro __va should take physical address instead of PFN as input. > > Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlin= es") > Signed-off-by: Yan Zhao My bug, obviously. :( Reviewed-by: Linus Walleij I thought this was already applied with the other fixes, but maybe it was missed? Yours, Linus Walleij