Received: by 2002:ab2:2997:0:b0:1ec:cbc4:63fb with SMTP id n23csp436633lqb; Thu, 29 Feb 2024 05:37:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXDMKvzG5RUfPngnKG6YC7VDbq2Q/PY2Bb8P/w8W2ktWrh5LsJ1Dv6E7EHfzEFnT+PWR4s/hR1pq+owaEkYjF7/Il7/GXi0Y0DOz5dDpA== X-Google-Smtp-Source: AGHT+IG6W70DprIGJpqU7NfrkythorCmz8PDbqN3TQ80iPC5yrBSCgFGrv4IsayAHQ9qcFZ3Tma9 X-Received: by 2002:ad4:4d52:0:b0:68f:8bff:f0bc with SMTP id m18-20020ad44d52000000b0068f8bfff0bcmr1918118qvm.63.1709213854223; Thu, 29 Feb 2024 05:37:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709213854; cv=pass; d=google.com; s=arc-20160816; b=uaJsC+TQBd/GClgZOk87Nd9/TFZL0kMZpCyw7lnSiZneqi2lsKWZuGf42yQKdjxORr adN+HP1mKhr7qMMxTmMiUlA/VTcnJ015Nkp/RVJNA49s0KjAj56x1tT+wtFTOQ1jpbdr 0hXuZUJVxGQRNbezwh12YBRJhbshGz7Pk/CP1nnVTGaOM3PzvuRw/hsZzv9Faexqdvh3 mhqxz/lJrM+TPmllJQu1j8f9Igcqj+S1sv3pN+JWXNkAgEMmvC5oJmOqVedmkpcLPrGv 8qwgpFHtcJ2dNw4M7jBklqxjzwCptDABwO+3jQdPl9CiWmjgnvTTBPururRvfQnA+62Q 68ng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=jRIC3inpQYVl05aLG7u0tOU2SIStN8WcCQsGMVDW6OE=; fh=1grQpHNAwRfzTPOmFm6DJGm/B9YEODGXo88b3ar6jOA=; b=nM4Uif5TOxVPJoiMDaZl+CVVeUDpNhRiOrM5Qe2rMeVa95kxMyW5BVNCUGZIJPPLC0 LNSniaWtukNL14hWNJ8I6FP0NTeyCSzmCh/2cgbq7m6d4fzZZgeDKAYDiqIaFVsYp4is zKvbBlQoI0FVDAX7l2kfYrFmvXVJrmwvAZw1ag8C1zFmtRYBBz4Yctqs7wOu1S2uhzHX HU/fyzns7bYfH3WJfOSV3gbUdK+Z1tm25NwEAQPAqh3khMnvabTEVjonGormAn6Quc/I LkvVDVkMTXiEc5fzBkwgBWsSwUPw8flVq4RStgRgC/xDUz0JxX5LgMUt1Gtmdc3zrPER yNaA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F7PLT07C; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id qo9-20020a056214590900b0068f8c14f14esi1304408qvb.570.2024.02.29.05.37.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:37:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-86763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F7PLT07C; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-86763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-86763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E3E431C20B1F for ; Thu, 29 Feb 2024 13:37:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1EC486245; Thu, 29 Feb 2024 13:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F7PLT07C" Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E5137E599 for ; Thu, 29 Feb 2024 13:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213848; cv=none; b=ZCTveTBpItXne2ZtZZ7AVOijsVzvJJwPd1ctivfDJSsG2tIAuoct83GF+GS1Vd1jDsV8uM1hd34poKZVn9cS9cVE9D9DHpjOQiCDy+xPcRcMhmcByeN9alRF2bw7CbszsGoB2k4/lI2PhoMVmsPiHn2Q0k+ddmQoRE34FOC2llw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709213848; c=relaxed/simple; bh=jRIC3inpQYVl05aLG7u0tOU2SIStN8WcCQsGMVDW6OE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bwW36ylA0z3J0bjUCCxrKZBvKbmT/sLGNw461ngHdgahAN31MCo5/ERHFb4xyEf4BWEiUNwGTmP4zw/XGp2PpMEjBJU4s3DBqMxDgKqp+IdoabzML5ecpLkSfAvRZbPyLpJhxWNLrmXKTsx9gXm+hH7ynyglBZ43vCWMmhIM0L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F7PLT07C; arc=none smtp.client-ip=209.85.219.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dc238cb1b17so1011726276.0 for ; Thu, 29 Feb 2024 05:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709213845; x=1709818645; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jRIC3inpQYVl05aLG7u0tOU2SIStN8WcCQsGMVDW6OE=; b=F7PLT07CUmWk4tyrAfO1wpH6n1+QyJLoTISpZvypmFcFhldNT9lXL5ldbg2s5xOG7V Prm7i+RozSXzpoGxtlScnCDCGOh/K+JDpzOkQMxK/K/WiIY88gplfgzdodXTHHZ89lvu SZj68SX21GntFy8YZKPbZEgrevekkjVAYa2g7CpBv0LHOj3Ni8viSKpOn+aTPBjW1qI4 moMnk7fldk3XUrfDU08zsQSmdIkWydaEOHZH0Czy6kPIbMwr16JjuBFGNhjTGQw/iEgi dR/OndMhh8MvweWVYdvbOQvA/hwt7KwIanTDUnrqqIWaMY3T8Ci4YXW4IMVUYLOJ9wEy 0lNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709213845; x=1709818645; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRIC3inpQYVl05aLG7u0tOU2SIStN8WcCQsGMVDW6OE=; b=wy2mIZ/I0CD3RoUu2E2CHxloDqy7FeRfbm3fai5fTMG5rI3ZK57cBVFt6po5px8noS 6e47ZFph6jouGEixOPqL05wAY1k324zt1FbHXZpaTpATSMKK00GyZ05MhBxWCOsqr55u CLCM2rlAVjp2AS/SPNjPW0RPJTUyifaPzzryi0NxQuKlAT7SDXNBvFxvZnLUdE+O0wfs vCTDhtnUbWfX86SeAiR4EfDfTrR0GZcKQoPwXZ3KbsLOgeNARU1nPPqlaMQ4qAKYfaBy cYxMNzOdL7+OPppTynEXe7vwN/+nsrRAx158mlCO0FcUMYiKUJlIWtflel2wxiB3fDJR De0Q== X-Forwarded-Encrypted: i=1; AJvYcCXX6rTi1Wk2ZfNELarD1/m4a/Xotsroks7uFUFS1ByJQbhpyQpLlmXGVWRoIW/3b5FNlkJV0Kpe/tMtkir/H+vYexkwmaUCi4ri79+/ X-Gm-Message-State: AOJu0Yza2NZPHLtoFCY3QbeWxU3tc3wZwyMFzSn0uoe84pGalfxXsJIQ kuN8yIkhwDdIqpPHIQKGdBHqSgOfKFQXHrioBGGNy9SxCeeYnUOuwIWEoYbS+bg9v6v2oI1tMIa Roa6e2SCr5AB1M9QLbT4E7NksKDLaSa6JRIb9rw== X-Received: by 2002:a25:8701:0:b0:dc6:c510:447a with SMTP id a1-20020a258701000000b00dc6c510447amr2201760ybl.58.1709213845284; Thu, 29 Feb 2024 05:37:25 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240223123214.288181-1-brgl@bgdev.pl> In-Reply-To: <20240223123214.288181-1-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 29 Feb 2024 14:37:14 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: don't put the reference to GPIO device in pinctrl_pins_show() To: Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , David Arcari Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 1:32=E2=80=AFPM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > The call to gpiod_to_gpio_device() does not increase the reference count > of the GPIO device struct so it must not be decreased. Remove the buggy > __free() decorator. > > Fixes: 524fc108b895 ("pinctrl: stop using gpiod_to_chip()") > Reported-by: David Arcari > Signed-off-by: Bartosz Golaszewski Patch applied for fixes! Yours, Linus Walleij