Received-SPF: pass (google.com: domain of linux-kernel+bounces-86790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 29 Feb 2024 13:58:54 +0000
From: Mark Brown <broonie@kernel.org>
To: Bhargav Raviprakash <bhargav.r@ltts.com>
Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, lee@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, jpanis@baylibre.com,
	devicetree@vger.kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com,
	linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com,
	kristo@kernel.org
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224
 PMIC regulators
Message-ID: <a71bda52-524d-4493-aede-786aae7ff468@sirena.org.uk>
References: <20240223093701.66034-1-bhargav.r@ltts.com>
 <20240223093701.66034-13-bhargav.r@ltts.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IdImxeBF2jIMpiDu"
Content-Disposition: inline
In-Reply-To: <20240223093701.66034-13-bhargav.r@ltts.com>


--IdImxeBF2jIMpiDu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Feb 23, 2024 at 03:06:59PM +0530, Bhargav Raviprakash wrote:

> +static struct tps6594_regulator_irq_type tps65224_ext_regulator_irq_types[] = {
> +	{ TPS65224_IRQ_NAME_VCCA_UVOV, "VCCA", "voltage out of range",
> +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> +	{ TPS65224_IRQ_NAME_VMON1_UVOV, "VMON1", "voltage out of range",
> +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> +	{ TPS65224_IRQ_NAME_VMON2_UVOV, "VMON2", "voltage out of range",
> +	  REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> +};

These should be REGULATOR_EVENT_REGULATION_OUT I think - they look like
they could be warning on either under or over voltage.

--IdImxeBF2jIMpiDu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXgjZ0ACgkQJNaLcl1U
h9AZpQgAgDQxpopqbu9eOrm5DijPH7ZT6wXrVVYNezNC+Eo52wB2uNqWIvL6rbuW
BE+mbJjmilSzxKjZkLEKfsNbw74icUaCCACGQqrRU130tlKusqpMRkyTneWA4EK0
9/tADo8fW6nwb1DhPt36Q+2VZDPX6pi+wV/7/aiZDYg8tbAx6jJodg0/aP8BPdwz
HyaWu31XqjZgGJiJ8UcmXym3roLM9B+9UNlTYp7UCQnW1j3lglsf79sFK88zIv2C
DKEWRIMqPJcKMaoCciRNrM5kq5+XJZxi+jEOiJvAltB9INy+j+DfoZRTn2cAuCXo
CaCBx2UtVmnGkvyv8s1fYpBUE9XdWg==
=6Vo6
-----END PGP SIGNATURE-----

--IdImxeBF2jIMpiDu--