Received-SPF: pass (google.com: domain of linux-kernel+bounces-86848-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240228-ad7944-mainline-v3-0-781b922334af@baylibre.com>
 <20240228-ad7944-mainline-v3-1-781b922334af@baylibre.com> <06235b66-6948-49b3-b881-198443a421df@linaro.org>
In-Reply-To: <06235b66-6948-49b3-b881-198443a421df@linaro.org>
From: David Lechner <dlechner@baylibre.com>
Date: Thu, 29 Feb 2024 08:35:47 -0600
Message-ID: <CAMknhBHhrNc-6qggSD1pt8djc9cv93dyNON8c_np6RwqT3yzig@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: add ad7944 ADCs
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-iio@vger.kernel.org, 
	Michael Hennerich <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	=?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 3:40=E2=80=AFAM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 28/02/2024 19:10, David Lechner wrote:
> > This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, an=
d
> > AD7986 ADCs.
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> >  .../devicetree/bindings/iio/adc/adi,ad7944.yaml    | 213 +++++++++++++=
++++++++
> >  MAINTAINERS                                        |   8 +
> >  2 files changed, 221 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml =
b/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml
> > new file mode 100644
> > index 000000000000..2564ef4f58cc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml
> > @@ -0,0 +1,213 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> >
> > v2 changes:
> > - Removed default 'multi' value from adi,spi-mode property. This simpli=
fies
> >   things a bit by not having to check for two possible conditions (abse=
nce of
> >   property or explicit default value). Now, only absence of property is=
 valid to
> >   indicate the default mode. Constraints that depend on this property a=
re
> >   updated accordingly.
> > - Fixed spelling of 'conventional'.
> > - Expanded description to call out potential confusion of '3-wire' mode=
 being
> >   unrelated to the standard spi-3wire property.
> > - Added standard '#daisy-chained-devices' property for chain mode.
> > - Relaxed requirement of cnv-gpios since it was determined that an acti=
ve high
> >   CS could actually be used in chain mode.
>
> ? Please don't edit patches manually... Use git or git+b4. Or quilt?
>
> Best regards,
> Krzysztof
>

Oh geez, yeah really dumb mistake. Will resend. I do use b4 but it
doesn't handle per-patch changelogs that I know of.