DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=Ui3WGMARFV+s5XiptDMnJ5/VwsK02bAaUEKBpbC5UTQEQB6OhUutBkVDQjJw1ScxCFvLziovk/sYCes+2SuABRYq4w+cOzXMKNfAnjQlCi3dqwwpoA1NeEQ/bGEIE8e9ZjLZq7ira21QxnsJ/5Qy8cDerqAOxgt5bcUU0t2Al64=
Message-ID: <84144f020801030320y2bfb0b25v19587a1835da2242@mail.gmail.com>
Date: Thu, 3 Jan 2008 13:20:17 +0200
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Arjan van de Ven" <arjan@linux.intel.com>
Subject: Re: [patch 1/3] move WARN_ON() out of line
Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@elte.hu>,
       "Andrew Morton" <akpm@linux-foundation.org>
In-Reply-To: <477C32DA.5060905@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <477C32DA.5060905@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 688
Lines: 16

Hi Arjan,

On Jan 3, 2008 2:56 AM, Arjan van de Ven <arjan@linux.intel.com> wrote:
> +int do_warn_on(const unsigned long condition, const char *file,
> +                       const int line, const char *function)
> +{
> +       if (unlikely(condition)) {
> +               printk(KERN_WARNING "WARNING: at %s:%d %s()\n",
> +                       __FILE__, __LINE__, __FUNCTION__);

I don't think you want to use __FILE__ and friends here...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/