Received-SPF: pass (google.com: domain of linux-kernel+bounces-86871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 29 Feb 2024 14:49:16 +0000
From: Mark Brown <broonie@kernel.org>
To: Esteban Blanc <eblanc@baylibre.com>
Cc: Bhargav Raviprakash <bhargav.r@ltts.com>, linux-kernel@vger.kernel.org,
	m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com,
	linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com,
	kristo@kernel.org
Subject: Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224
 PMIC regulators
Message-ID: <6fa04f9a-2904-4955-a219-d4962b8fe41b@sirena.org.uk>
References: <20240223093701.66034-1-bhargav.r@ltts.com>
 <20240223093701.66034-13-bhargav.r@ltts.com>
 <CZHN4S2QW6MY.KKKHHRPPY4ZG@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="C3RoV1h1koPrEpV2"
Content-Disposition: inline
In-Reply-To: <CZHN4S2QW6MY.KKKHHRPPY4ZG@baylibre.com>


--C3RoV1h1koPrEpV2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote:
> On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote:

> > +	/* Number of interrupts supported by each voltage source */
> > +	interrupt_cnt = (tps->chip_id == TPS6594) ?
> > +			 ARRAY_SIZE(tps6594_buck1_irq_types) :
> > +			 ARRAY_SIZE(tps65224_buck1_irq_types);

> The comment is not adding anything, the name is clear and ARRAY_SIZE is
> quite explicit.

Also please don't abuse the ternery operator like this, write normal
conditionals or for a case like this where we may get more options in
future use switch statements.

--C3RoV1h1koPrEpV2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXgmWwACgkQJNaLcl1U
h9A7fQf+P2ZRUxZ1OFuQHOH8xAkdPC++bb/AEXvafquTsQ66dbQL5g71d50MIspZ
IX+GgMjYnGvg2778K7NWelmOo8+rFfrTcICsI2FnZUHBqUj6kXJoNHXbX6Tojwj6
D+cbrt3TaG4fcH1T74uAvm4KKx3eY/MTFcQj7z1yx53Hw1YkaWKtI0RgTlw1H7Xw
32T/R5x/YQRm9S0iY4on0N/uT8h9fx7uUiu4F0sRw3nNpF/A6TlFA+kpLomxcZPm
zf76GFUrrhZx9l/04KHjyHL9JDli6hIJV59GKFCKlFLT+yW3aAxnOteoKXjJmezk
yx4zUcarBxQbkemGxR9n6H/h44ALBg==
=FOEF
-----END PGP SIGNATURE-----

--C3RoV1h1koPrEpV2--