Received-SPF: pass (google.com: domain of linux-kernel+bounces-86895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <43840914-cb4a-4758-9691-0ebd8fb97681@gmail.com>
Date: Thu, 29 Feb 2024 17:08:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for
 additional models
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, David Lechner <dlechner@baylibre.com>,
 Ceclan Dumitru <dumitru.ceclan@analog.com>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240228135532.30761-1-mitrutzceclan@gmail.com>
 <20240228135532.30761-2-mitrutzceclan@gmail.com>
 <9f3e461a-0b79-470f-b599-bba45cda006a@linaro.org>
From: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>
In-Reply-To: <9f3e461a-0b79-470f-b599-bba45cda006a@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/02/2024 16:49, Krzysztof Kozlowski wrote:
> On 28/02/2024 14:54, Dumitru Ceclan wrote:
>> Add support for: AD7172-2, AD7175-8, AD7177-2.
>> AD7172-4 does not feature an internal reference, check for external
>>  reference presence.

..

>> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> 
> There is no such file in next-20240229.
> 

It's not yet accepted
https://lore.kernel.org/all/20240228110622.25114-1-mitrutzceclan@gmail.com/

..

>> +  # Model ad7172-4 does not support internal reference
>> +  #  mandatory to have an external reference
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: adi,ad7172-4
>> +    then:
>> +      patternProperties:
>> +        "^channel@[0-9a-f]$":
>> +          properties:
>> +            adi,reference-select:
>> +              enum:
>> +                - vref
>> +                - vref2
>> +                - avdd
>> +          required:
>> +            - adi,reference-select
> 
> Are you defining properties here? I cannot verify because this file does
> not exist in next.
> 

No, just constraining reference-select to be required and exclude
"refout-avss".

> 
> 
> Best regards,
> Krzysztof
>