Received-SPF: pass (google.com: domain of linux-kernel+bounces-86909-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240229120541.219429-1-colin.i.king@gmail.com> <f7b36055-a710-4d57-b952-33431876e221@ieee.org>
In-Reply-To: <f7b36055-a710-4d57-b952-33431876e221@ieee.org>
From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Date: Thu, 29 Feb 2024 20:45:17 +0530
Message-ID: <CAAs3649g_nr5-6PLnGL31ouo5GMhn7o0zuDOjSO+HmG6vUnkXQ@mail.gmail.com>
Subject: Re: [PATCH][next] staging: greybus: Remove redundant variable 'mask'
To: Alex Elder <elder@ieee.org>
Cc: Colin Ian King <colin.i.king@gmail.com>, Mark Greer <mgreer@animalcreek.com>, 
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, greybus-dev@lists.linaro.org, 
	linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 6:51=E2=80=AFPM Alex Elder <elder@ieee.org> wrote:
>
> On 2/29/24 6:05 AM, Colin Ian King wrote:
> > The variable mask is being assigned and bit-set but it is never
> > being used apart from this. The variable is redundant and can
> > be removed.
> >
> > Cleans up clang scan build warning:
> > drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mas=
k'
> > set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks Colin for sharing this patch.

>
>
> This is a reasonable change, but I don't know this code that
> well and would like to hear from Vaibhav (if possible) or
> someone else whether they think the mask value *should* have
> been used in this spot.  It doesn't look like it to me, but
> I'd like you to get a second opinion...

The original intent was use the mask field while maintaining regmap entries=
.
However, I could not push changes on "maintain regmap" during ARA days :(
Anyways, for now it makes sense to drop the unused mask variable.

>
>                                         -Alex
>
> > ---
> >   drivers/staging/greybus/audio_topology.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging=
/greybus/audio_topology.c
> > index 08e6a807c132..5dc4721105d4 100644
> > --- a/drivers/staging/greybus/audio_topology.c
> > +++ b/drivers/staging/greybus/audio_topology.c
> > @@ -761,7 +761,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kco=
ntrol *kcontrol,
> >   {
> >       int ret, wi, ctl_id;
> >       unsigned int val, mux, change;
> > -     unsigned int mask;
> >       struct snd_soc_dapm_widget_list *wlist =3D snd_kcontrol_chip(kcon=
trol);
> >       struct snd_soc_dapm_widget *widget =3D wlist->widgets[0];
> >       struct gb_audio_ctl_elem_value gbvalue;
> > @@ -802,7 +801,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kco=
ntrol *kcontrol,
> >
> >       mux =3D ucontrol->value.enumerated.item[0];
> >       val =3D mux << e->shift_l;
> > -     mask =3D e->mask << e->shift_l;
> >
> >       if (le32_to_cpu(gbvalue.value.enumerated_item[0]) !=3D
> >           ucontrol->value.enumerated.item[0]) {
> > @@ -815,7 +813,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kco=
ntrol *kcontrol,
> >               if (ucontrol->value.enumerated.item[1] > e->items - 1)
> >                       return -EINVAL;
> >               val |=3D ucontrol->value.enumerated.item[1] << e->shift_r=
;
> > -             mask |=3D e->mask << e->shift_r;
> >               if (le32_to_cpu(gbvalue.value.enumerated_item[1]) !=3D
> >                   ucontrol->value.enumerated.item[1]) {
> >                       change =3D 1;
>

Acked-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>