Received-SPF: pass (google.com: domain of linux-kernel+bounces-86926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
 Barry Song <v-songbaohua@oppo.com>, Vishal Moola <vishal.moola@gmail.com>,
 Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH v1] mm: convert folio_estimated_sharers() to
 folio_likely_mapped_shared()
Date: Thu, 29 Feb 2024 10:28:50 -0500
Message-ID: <B10F7140-A4B2-403A-9333-4A7FAF198949@nvidia.com>
In-Reply-To: <20240227201548.857831-1-david@redhat.com>
References: <20240227201548.857831-1-david@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qlLgK5gx7QUb/CGVWDAQGVwGakw4wHLYPP5mhTISAZI2qYwcmh8dvDBQ0ECU?=
 =?us-ascii?Q?n2ksrizuqrrvqn0sDPIdsRbq65HFKJDNEIpWgPj0r79EXPEiSIc0gmjJoLrq?=
 =?us-ascii?Q?v9DIq+qubKL/uvmCVW2Fw0BiMaz+rOwK4VNibYgzAu7ZwtAhYVvwqLGbaNEj?=
 =?us-ascii?Q?387fYTq7Cj3L9S1k9gSixmEN1elEOF2lHvt94FYBzH9ZG3w9HdbbaoPXetHt?=
 =?us-ascii?Q?8wq1Qw59erUfZgHE7x0yeje3lPfMVw4GUMgvvycdLwURavmJxKUSNpoO3YQg?=
 =?us-ascii?Q?SlX3fNF4EEzHT1YaHzDyk+/b2PJXunZq/YcWSTyFYeNd70pvHEoVFid4HKew?=
 =?us-ascii?Q?XXdcRhM1KBrgpoYEKYFuxxSfCriluVuXEdJBM+RehOEYu+D9YiwQjytDz0Ix?=
 =?us-ascii?Q?8BSYisbF1BtxHsJ0oq5LXVbCE+MVYIOZRJlp0BiPqnDWMV8GpTCXm1aYjmBC?=
 =?us-ascii?Q?WnPf5xXgCZNgt6w8ql5ODMX9BjzOr0DBEy2DkA0lOrDUsLGB0rvcyqf/Pyo0?=
 =?us-ascii?Q?K6xhgB6QDe3snoehXIyY3I6WKbjyRGhZfgEgwDYZhaShOPZnkohulXheftMv?=
 =?us-ascii?Q?4QnXWJMEbkE3R3JOrZuNP1fqpViqUcLz0e62Cz5PZ/gLHwfmN/2dlblplq86?=
 =?us-ascii?Q?i7J+DBtbCYWEHN0qvZftUK9v7axmAiLRjO98q77HM1sLfs825LCnvi5CqB9h?=
 =?us-ascii?Q?XqI761Ahq2FPYExvJ27/usDxItMsLfMOvrml6RAFIh55/HyqvYLaK7i8JjWF?=
 =?us-ascii?Q?4Meb+LGz0Daq0IFqY8WyW6RoNW23rvmfN9ESfY7CzhrN+9z+/BY1NUDGDUUW?=
 =?us-ascii?Q?Ztog1/W3dk+9pq+mbmaqkXXXcnGXCjDvZ4lxEIylONpiQl+70a4OPPhbEKxp?=
 =?us-ascii?Q?h6tLmdTQMnWRcjTDrpaBKoJTkqErvP9rucl6ef7T9zxeiLw4b2khhyyUFg8T?=
 =?us-ascii?Q?uhX6BN+/YqHxhrG+1d7780UOfHqGlhefgg9pkk1yyGmi+3iz05FoosyWDY9D?=
 =?us-ascii?Q?JkWvIChf4apoaKYCCSfMt2iDVHyWLd0ZfI6eHzXGMBCo71fZ/6enOfMCdfqw?=
 =?us-ascii?Q?jGEwcpAwwvAVjjm8vpVBgaijcMud4wZpZEzsmnk3tFV1e5mMwOO/k3H9DJN6?=
 =?us-ascii?Q?unECvrZKFwribzv6pjTb3mOLoewiC/yLcaafA49GJxK94aeHUuCwkQIefGRS?=
 =?us-ascii?Q?DDMUi/ctzi91DJiMA0b8Jxl18e5k7jnsiIl1R090XEnc9Hr8B1Is/brETMBb?=
 =?us-ascii?Q?UwLiKeluLYxcHEpXUjiTevyIhBX14Hid/XRimuaxLVy0VfzigjPRuD2cGbAp?=
 =?us-ascii?Q?dtkk4FY64tCxLvPD4nzCUONFG3fnaPeMqi/7etNvbdjhMIBxNZYSRWQnfHMV?=
 =?us-ascii?Q?sWEIh0zBncP+wgXa/N42+F4tGXigFxBXGVq3pSthHZdShFdtRSxEFSZI/ADI?=
 =?us-ascii?Q?lLE98vUl8yEIxtMSQ2+lIRZlMiZ/5yaJW4RbhhIY2P2AtyHusdFBqwgwrxTJ?=
 =?us-ascii?Q?s8aqfpYGUlnNQx3bA9WvBCdUMNt3MgRMOtJOEaJkyZS086KrQBNpozXDu7u5?=
 =?us-ascii?Q?WW2nTJ+WdYNqUsUmSKo=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1310d8a4-b4ad-4592-4b16-08dc393b23c2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 15:28:54.6777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ycLrllGdlsh0NrdJtEt1YQXmEqbjHbTCK1CNLOOjsWDSQfxuTvKa4S0uq/1O4Udn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8930

--=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_=
Content-Type: text/plain

On 27 Feb 2024, at 15:15, David Hildenbrand wrote:

> Callers of folio_estimated_sharers() only care about "mapped shared vs.
> mapped exclusively", not the exact estimate of sharers. Let's consolidate
> and unify the condition users are checking. While at it clarify the
> semantics and extend the discussion on the fuzziness.
>
> Use the "likely mapped shared" terminology to better express what the
> (adjusted) function actually checks.
>
> Whether a partially-mappable folio is more likely to not be partially
> mapped than partially mapped is debatable. In the future, we might be able
> to improve our estimate for partially-mappable folios, though.
>
> Note that we will now consistently detect "mapped shared" only if the
> first subpage is actually mapped multiple times. When the first subpage
> is not mapped, we will consistently detect it as "mapped exclusively".
> This change should currently only affect the usage in
> madvise_free_pte_range() and queue_folios_pte_range() for large folios: if
> the first page was already unmapped, we would have skipped the folio.
>
> Cc: Barry Song <v-songbaohua@oppo.com>
> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
LGTM. Thanks for the documentation. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXgorMPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUBwcP/Rt+az4MmAVLI8VgjNUHug5Fxl1LwkFz5aA9
5V0G2fnC2A/v8ndncu+C3RowNn1G6deDMEth9skQ1BvY5pIWMxLK6nwuwS10HQCN
aBgXhKU0uXhxnKqMHLl/8SnbccvsxCu139nPEgo8mh8UOuLJG9mxh2wW59CsEL/A
GrpseM47kUwLIVU6G7uvMywy7tJvggje71dF+Fn877pvPQY24kGVxZVIonezuOSm
oWyuiARJ8RuRA2qN+X0/jHtJ5wqOsAHpGEZKCApeKW1HrlPLfT3KsPimSzx1BQ3l
nG6VMM+qZVIfN39H1S7mil1xBnE+G5i7ZhIuA8io0IpqCzxzhakxZrexGs/Q3ho8
afzfgF2ctuVI6jqWJJfFI12P7mtl2fr7+ArKRzm4TOptV6dP0RfoPZUNnz55l1kZ
JSf1in3v1aiJRynpYs/Llr/FA1mUUUhN68e1sNqkTzsCxJBRfo2IVbvB+vHqcs8t
oGPrn30uOUxCHFE5B3LRqlA4PvaRX60maHwyVRjjGJTsNmJ3J1+g7tvfN2konnT2
rZpb55usPIbcs+J66xUwZo+aZhbbI9ZinFdBS57XOHQNB4t3QcMyU7IcvTpuvZIc
Bw3JIl3wyNe0209ovdQ4SFR9aRq69Fef4Wqc2/MtaUn7WhqAyV4YTBRCVUcteYYH
BxAk5e5I
=kz5u
-----END PGP SIGNATURE-----

--=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_=--