Received-SPF: pass (google.com: domain of linux-kernel+bounces-87032-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 29 Feb 2024 10:54:08 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Joy Zou <joy.zou@nxp.com>
Subject: Re: [PATCH 4/5] dt-bindings: fsl-dma: fsl-edma: add fsl,imx8ulp-edma
 compatible string
Message-ID: <ZeCooFQtOK9MuuJn@lizhi-Precision-Tower-5810>
References: <20240227-8ulp_edma-v1-0-7fcfe1e265c2@nxp.com>
 <20240227-8ulp_edma-v1-4-7fcfe1e265c2@nxp.com>
 <bb3b61b6-4f39-4123-be50-0e2c8f07eb99@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bb3b61b6-4f39-4123-be50-0e2c8f07eb99@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?31TNdK0YK49uEw+h6vnbw0LOpn6G+BeYl3L5a36Hhv5S5oEPc5tL63srC2/3?=
 =?us-ascii?Q?TTcP1YNhtlEIbeihoHVnYTYzDLfvJpQ+dHawJ+kqf+CnLECuZDjOUBIhLnyl?=
 =?us-ascii?Q?l5UmwwcXAbbLkypHeLm5B0vr4wVLQ9QcMASUoJ+IzDn9YN1IvMB5+PDtdGk9?=
 =?us-ascii?Q?C8zQL2tKfCpdg7U3dYuGKMlCm5xkDTAyN3VlRzVRrTDls0Rg+Vgh/WlQc7oJ?=
 =?us-ascii?Q?YNV7PGRZfU57RnDP+ilMAaJODTFKl768+oGyyk5h71qHPvhv71lJJmyj2gew?=
 =?us-ascii?Q?+DjTa9nIaK60/OjgXxL3uoO7THXOuPhfBjn3TV1DSNiasAXveiLfgov4lKWg?=
 =?us-ascii?Q?XHUidw6+sKY+l0xudJgo9oZHc4kF6jHKMKkaJq0WoVa7d4g2ILgzTfnb3PY6?=
 =?us-ascii?Q?B/7ZWOhqCE3kVMiHo+w3YDg81Nqm1bFRVdzgPKJhZRw03mhyAS4p9338QMSZ?=
 =?us-ascii?Q?mmMZ93X1fBLe3T3BKeN9ksf/vZ6zYFyROEIyNXaju0xCw56lcOl/iIrsIoj6?=
 =?us-ascii?Q?8nZjTSycZwQn6np4CaRPmQfA38QesU8ml1EkdjGtLYKo8K/5RRM2GNAC4v23?=
 =?us-ascii?Q?ep7CW/2Db+NsqextYi5+pJF70H1TntwlYaMW+IJmEsIDgayzBaWsDdh4Y/K+?=
 =?us-ascii?Q?yTiwnHAqRqNSrR/i/Y+j2Cb4ksyquD0c1WqPT1xHDgLOXe9Mn+VcJB0Fm2iX?=
 =?us-ascii?Q?jqL2ST33gGv4CTLaTRwsnxz22tAB+dy+YDJUwsKTX34qY0k222DYMbRYBdyo?=
 =?us-ascii?Q?A/C91Nyk/0255CmMLBu54y72drgcdt2omVBWcktoL8WZwBceo8bX+ya8CEPg?=
 =?us-ascii?Q?MZ17sS3hFFHJvEFc7wmq5j0S9UWXygQHDEYO2kZYnzk/POHI02gImDxH5z+5?=
 =?us-ascii?Q?Muy67iY2pBGGiCOoCfrMNZTt1LEJqRVmdB0UozOMYcXJwJrtx3Y9nrDwsQMk?=
 =?us-ascii?Q?nLywM7bEtKgjJ3Ja4vsWez4OBUy0hsFXtLKxj4phug+9acLrSq1iUQoX6M7k?=
 =?us-ascii?Q?v2G34jPbmq/zVpHGPfr5n8LK7xRpSfVRbKWji4FW93vIaIIKIBw6MdpMAEuJ?=
 =?us-ascii?Q?EPVJmhpbSSNnb5EtCHpG/vaaKwYX984KGfZ9WTStPBKzZ2rBV1CWMhtjbqKI?=
 =?us-ascii?Q?zfgT83hvHk/Eux07SJauDoWk5z6D52tI/+kxsUwmGUzfAbZ8BJCttsuaDCup?=
 =?us-ascii?Q?1FlJBWAeA25SEDT+lpp4kxH8WmrDbvybezI1vR3oG0otI/ObiccpfzPKXrsI?=
 =?us-ascii?Q?mCHm6JFIcT/NphskGJLDL7JEERv55DKUMiN81jCxyqZgYKyoeMeux8RZCbXz?=
 =?us-ascii?Q?yPJAKNUnG/9+pNYH1b4J4jDZwc476zR6J29TFYOUYgOCySjnqqaiqvKKCaWS?=
 =?us-ascii?Q?woj2Mxo3tf6QqVUaJ/sj68T4Lj9esZi237Q8v3ue8CrnmQaCre300QGaogVr?=
 =?us-ascii?Q?9SYincF3sf7KvD4G3rp8zSegv3nLTHbCm6WRlKonRu7juaWWeXAh4hbDUyh1?=
 =?us-ascii?Q?T69Vu2RsCRndIGbcunJ0C7IhIN3DiBghsusIbj45aKoRKpKokCrP+pXWs35x?=
 =?us-ascii?Q?cYMDhP0HRZOgaVmBGi6zx1WdcHJoLGZUd5vxtyGx?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02ab7109-ebe9-4077-80d2-08dc393eaec9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 15:54:16.4495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2g/Z6KKlTZP4FEo2mJLdnjlz2Jyvx7hfWN6DkNPbHWzkG8wMdsAay2yaptpf0VgxecMNQVOO5hbwwcc0DQELBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9641

On Thu, Feb 29, 2024 at 10:49:43AM +0100, Krzysztof Kozlowski wrote:
> On 27/02/2024 18:21, Frank Li wrote:
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8ulp-edma
> > +    then:
> > +      properties:
> > +        clock:
> > +          maxItems: 33
> > +        clock-names:
> > +          items:
> > +            - const: dma
> > +            - pattern: "^CH[0-31]-clk$"
> > +        interrupt-names: false
> > +        interrupts:
> > +          maxItems: 32
> > +        "#dma-cells":
> > +          const: 3
> 
> Why suddenly fsl,vf610-edma can have from 2 to 33 clocks? Constrain
> properly the variants.

Suppose you talk about 'fsl,imx8ulp-edma' instead 'fsl,vf610-edma'.

imx8ulp each channel have one clk, there are 32 channel. 1 channel for core
controller. So max became 32.

I can add above information in commit message.

> 
> Best regards,
> Krzysztof
>