Received-SPF: pass (google.com: domain of linux-kernel+bounces-87181-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 29 Feb 2024 18:36:08 +0100 (CET)
From: Jiri Kosina <jikos@kernel.org>
To: Sasha Levin <sashal@kernel.org>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Michal Hocko <mhocko@suse.com>, Kees Cook <keescook@chromium.org>, 
    cve@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: CVE-2023-52451: powerpc/pseries/memhp: Fix access beyond end of
 drmem array
In-Reply-To: <nycvar.YFH.7.76.2402291754020.13421@cbobk.fhfr.pm>
Message-ID: <nycvar.YFH.7.76.2402291824020.13421@cbobk.fhfr.pm>
References: <2024022639-wronged-grafted-6777@gregkh> <ZdytVTOgfvKBBvtn@tiehlicka> <202402271029.FD67395@keescook> <Zd8hPpP_6q_o8uQW@tiehlicka> <202402280906.D6D5590DB@keescook> <ZeA-281OudkWBhd_@tiehlicka> <2024022915-dissuade-grandson-ebd4@gregkh>
 <ZeBRZqJd5HAKaOfC@tiehlicka> <2024022913-borrower-resource-ecc9@gregkh> <nycvar.YFH.7.76.2402291605370.4159@cbobk.fhfr.pm> <ZeCsKGwU96sKi_S_@sashalap> <nycvar.YFH.7.76.2402291754020.13421@cbobk.fhfr.pm>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 29 Feb 2024, Jiri Kosina wrote:

> - you pointed to a fix for UAF in BPF, which definitely is a good fix to 
>   have, I don't even dispute that CVE is justified in this particular 
>   case. What I haven't yet seen though how this connects to in my view 
>   rather serious 'trivial to get root' statement

To elaborate on this a little bit more -- I completely agree that this fix 
is completely in-line with what Kees is, in my view, quite nicely 
describing at [1]. You pointed to a weakness (for which a fix *is* in our 
queue), sure.

But I see a HUGE leap from "fixes a weakness" to bold, aggressive and in 
my view exaggerating statements a-la "I am able to trivially pwn any 
kernel which is not -stable".

[1] https://lore.kernel.org/all/D06F40E5-0DBC-4FF2-BAF5-2373BDF3815C@kernel.org/

-- 
Jiri Kosina
SUSE Labs