Received-SPF: pass (google.com: domain of linux-kernel+bounces-87203-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 29 Feb 2024 12:43:29 -0500
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: imx@lists.linux.dev, conor@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
	linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	helgaas@kernel.org, bhelgaas@google.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: pci: layerscape-pci: Convert to yaml
 format
Message-ID: <ZeDCQezI2zj8bWBP@lizhi-Precision-Tower-5810>
References: <20240228190321.580846-1-Frank.Li@nxp.com>
 <20240228190321.580846-2-Frank.Li@nxp.com>
 <170915420970.759733.12998246565079147606.robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <170915420970.759733.12998246565079147606.robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/u4Ledh7U+0H7dVOhMuY/waTD9OFUKOgLgbTVYXsAv2FE2nD1hiEVvB4dBfG?=
 =?us-ascii?Q?N3Edtx7BkUiuHlBfvfN0i0YfP+GF3e+cJx9oPbOaCaRbVGJ7qEXy8R0ldytg?=
 =?us-ascii?Q?L4iLmuZ3TBZ79tmw01fW6Aka2TBb/ls4VAD2T3ANIi6w0ZsquWz7orOcQMon?=
 =?us-ascii?Q?qu7GYuxFji2CFA1eG1cWqfm6ASH9SA23MSE7dc9cAf0Xe1tGPJ/+eMoMQTyI?=
 =?us-ascii?Q?ZW4AWIMeH12IApRFQ5t7PZ9Yl+qZJaExEOBHuWVu6EUnINw49uQ58PXxVlxI?=
 =?us-ascii?Q?7ZNhuWR0ZM4c6fij/KhOcFZynNqjfR5WfWUOgqLCbWATh8OTawns5a3ag5Nn?=
 =?us-ascii?Q?PBVVL+6UvTW/EBruyabmydFFh2H1dmPLptV6MWEiCU/FkdA6aMxn3NkSGBzY?=
 =?us-ascii?Q?UJr1X6kzG9U/5H3bnG32XQlt7cBpU+AH+qNfSQAFIWq18OZSQ2Xjh5AobDPc?=
 =?us-ascii?Q?VL9tks/RPHJjF+tBkxjHVwIn8onYpS6Vmfm8GCyHML3JtpbTB1tF1y2BMIqw?=
 =?us-ascii?Q?ImWC7pflmCD9iS0t83ks8H9ZFhowlKuDgoG/EuVlnUZ7cFJwxsIKNavjse0d?=
 =?us-ascii?Q?Lq2TmQIvRGrYfWCy3MMkIm8KJBQq1aW5a1AMLXH85Jn/TmlcirfUIG/bdkJR?=
 =?us-ascii?Q?q7xvJvtRhCJ8IvdDy/YNATONRmUYXMhLBY7VbXq09GhT82s8gofHszJu1nTd?=
 =?us-ascii?Q?/B7nGO5fNsXJs4ZBG/0feXWipehTGlTeenyNOCtcVP+RBEbkSuuIhPXF1AO4?=
 =?us-ascii?Q?zrLfIPSfYl+1fQnZSz0qCd6mODm97tpA6Fx3hWf6H/56n1c8dQuyN163xKv5?=
 =?us-ascii?Q?jEBoFmUTjAZuxX20GEJYxnzJQ9C5QVbbkS8TczB7Me0++cG5wIHLD+WneFmG?=
 =?us-ascii?Q?Qz9NZ56Q1H0fZ3D9Vu1cwFInPDXAWg7joMPlYGrE8EV/neU4IDqYrGBHHiC9?=
 =?us-ascii?Q?sp8j9qXELggm4xAcEqrWgIghJH9t3QL4LdaTFcdolWqyKWsK1tC1PBeWmIlA?=
 =?us-ascii?Q?tAZQeEHuh1nsdvNDdgpN9NG40s5bKX5hLUUehP3EHVCCH5KHY+uExRzDBHNb?=
 =?us-ascii?Q?ltol2xaIbImR1CH1E6KewQ6pmWTWVPKEl05KcZ9MSinS4YGoh1m5vMxQ9FX/?=
 =?us-ascii?Q?Ppe8p2+3azXVo/fELnSbz+AbyFXvL6WGpX1D0fRGejbBLUQdeXyxksFFO/7d?=
 =?us-ascii?Q?uZVvTo238WFqIiiu0sOgkCMEi69SWyRteHoRUudePpQa98W0OQvyDSd8G5Kf?=
 =?us-ascii?Q?Aa2OWxTLBfrMTlKLfr/7QdPWCdmBKlNBeW64zvZ9aTUR4OmVcY90Tp2ViBQr?=
 =?us-ascii?Q?QeEqPlwi1xk/hxCVLYnH7FtNM7Rrs3YCXuWOIvxmF7lmAEqoTxjDlHyPUd3t?=
 =?us-ascii?Q?y8mAH+7B38FdUG03K+XSJNdSqj7p/YOYosh5TlKu742zZiFnboCXD2mh2C3f?=
 =?us-ascii?Q?bVgHk/xJGnTO++EnjM9lH9v44LotHM9mvt6CHg3eWRoaPqnqoSS6mQCHsxiY?=
 =?us-ascii?Q?Zva99E5p4LRH/d2j4Wt8jZXEbjC7TP3Yi5r+L/oeMQ9IDs4gyNIhXhje4nL2?=
 =?us-ascii?Q?ArY5J8+5GWaxa9cufJ8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fead627-d32d-4e24-d0c5-08dc394df596
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 17:43:37.7877
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3JbJg255O4DxxkfBwhICIY80OUXOLJF9+1DUkByDyvuVBJqMtZunSWRfF7clED9s6ZcyvIUl2cPnmuXhrxXd6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9431

On Wed, Feb 28, 2024 at 03:03:31PM -0600, Rob Herring wrote:
> 
> On Wed, 28 Feb 2024 14:03:17 -0500, Frank Li wrote:
> > Split layerscape-pci.txt into two yaml files: fsl,layerscape-pcie-ep.yaml
> > and fsl,layerscape-pcie.yaml.
> > yaml files contain the same content as the original txt file.
> > 
> > The subsequent commit will fix DTB_CHECK failure.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../bindings/pci/fsl,layerscape-pcie-ep.yaml  |  89 +++++++++++++
> >  .../bindings/pci/fsl,layerscape-pcie.yaml     | 123 ++++++++++++++++++
> >  .../bindings/pci/layerscape-pci.txt           |  79 -----------
> >  3 files changed, 212 insertions(+), 79 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> >  create mode 100644 Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):

Please omit these errors. Bjorn require create a identical version as
old txt file.

Origial txt will cause DTB_CHECK error. The problem will be fixed at next
patches.

> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: Unevaluated properties are not allowed ('#address-cells', '#interrupt-cells', '#size-cells', 'bus-range', 'device_type', 'interrupt-map', 'interrupt-map-mask', 'iommu-map', 'msi-parent', 'ranges', 'reg-names' were unexpected)
> 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: 'fsl,pcie-scfg' is a required property
> 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: 'dma-coherence' is a required property
> 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240228190321.580846-2-Frank.Li@nxp.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>