Received-SPF: pass (google.com: domain of linux-kernel+bounces-87197-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240226013208.2389246-1-chao@kernel.org> <20240226013208.2389246-2-chao@kernel.org>
In-Reply-To: <20240226013208.2389246-2-chao@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Thu, 29 Feb 2024 09:41:42 -0800
Message-ID: <CACOAw_wG_6OVMFC1OKEvc_Y0YanZTcVgum6VL=bh-nqJgg=uZg@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 2/4] f2fs: relocate f2fs_precache_extents() in f2fs_swap_activate()
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Daeho Jeong <daehojeong@google.com>

Thanks,

On Sun, Feb 25, 2024 at 5:33=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> This patch exchangs position of f2fs_precache_extents() and
> filemap_fdatawrite(), so that f2fs_precache_extents() can load
> extent info after physical addresses of all data are fixed.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>  fs/f2fs/data.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 0c728e82d936..bd8674bf1d84 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -4045,12 +4045,12 @@ static int f2fs_swap_activate(struct swap_info_st=
ruct *sis, struct file *file,
>         if (!f2fs_disable_compressed_file(inode))
>                 return -EINVAL;
>
> -       f2fs_precache_extents(inode);
> -
>         ret =3D filemap_fdatawrite(inode->i_mapping);
>         if (ret < 0)
>                 return ret;
>
> +       f2fs_precache_extents(inode);
> +
>         ret =3D check_swap_activate(sis, file, span);
>         if (ret < 0)
>                 return ret;
> --
> 2.40.1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel