Received-SPF: pass (google.com: domain of linux-kernel+bounces-87196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240226013208.2389246-1-chao@kernel.org> <2b81aa6f-db51-4a7c-97ab-2af2c2fea056@kernel.org>
In-Reply-To: <2b81aa6f-db51-4a7c-97ab-2af2c2fea056@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Thu, 29 Feb 2024 09:41:33 -0800
Message-ID: <CACOAw_yn4m+nEGMEX8RL1xFEaZpzXvjUhUdSoo9d2EeGfzPrAA@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 1/4] f2fs: fix blkofs_end correctly in f2fs_migrate_blocks()
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, Daeho Jeong <daehojeong@google.com>, linux-kernel@vger.kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 2:11=E2=80=AFAM Chao Yu <chao@kernel.org> wrote:
>
> Jaegeuk, Daeho,
>
> Any comments on this serials?
>
> Thanks,

No functional difference here, since start_blk is always aligned with
the section address.
However, this is more clear in itself.

Reviewed-by: Daeho Jeong <daehojeong@google.com>

Thanks,

>
> On 2024/2/26 9:32, Chao Yu wrote:
> > In f2fs_migrate_blocks(), when traversing blocks in last section,
> > blkofs_end should be (start_blk + blkcnt - 1) % blk_per_sec, fix it.
> >
> > Signed-off-by: Chao Yu <chao@kernel.org>
> > ---
> >   fs/f2fs/data.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index c21b92f18463..0c728e82d936 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -3841,13 +3841,14 @@ static int f2fs_migrate_blocks(struct inode *in=
ode, block_t start_blk,
> >       struct f2fs_sb_info *sbi =3D F2FS_I_SB(inode);
> >       unsigned int blkofs;
> >       unsigned int blk_per_sec =3D BLKS_PER_SEC(sbi);
> > +     unsigned int end_blk =3D start_blk + blkcnt - 1;
> >       unsigned int secidx =3D start_blk / blk_per_sec;
> >       unsigned int end_sec;
> >       int ret =3D 0;
> >
> >       if (!blkcnt)
> >               return 0;
> > -     end_sec =3D secidx + (blkcnt - 1) / blk_per_sec;
> > +     end_sec =3D end_blk / blk_per_sec;
> >
> >       f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> >       filemap_invalidate_lock(inode->i_mapping);
> > @@ -3857,7 +3858,7 @@ static int f2fs_migrate_blocks(struct inode *inod=
e, block_t start_blk,
> >
> >       for (; secidx <=3D end_sec; secidx++) {
> >               unsigned int blkofs_end =3D secidx =3D=3D end_sec ?
> > -                     (blkcnt - 1) % blk_per_sec : blk_per_sec - 1;
> > +                             end_blk % blk_per_sec : blk_per_sec - 1;
> >
> >               f2fs_down_write(&sbi->pin_sem);
> >
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel