Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp55091lqc; Thu, 29 Feb 2024 10:07:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUBNRg6mpQimBA3CuPD+25/JzJKtGCtjcRI/WSdRBALkKnGJNMmqKYV/kkYcA5eJyj6aasTCqJybuDMaHnFoyx8nMYuObR1JYHJYOoDBQ== X-Google-Smtp-Source: AGHT+IEqWTdr1oVIjb7EIcOszquLKKu6v0Om0PhBtSaOkyB+6tRLNoJF9jrXPsDrRieU6dfJ3Tpp X-Received: by 2002:a05:6a20:9588:b0:1a0:ef1e:9faf with SMTP id iu8-20020a056a20958800b001a0ef1e9fafmr3508168pzb.11.1709230029639; Thu, 29 Feb 2024 10:07:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709230029; cv=pass; d=google.com; s=arc-20160816; b=uOa1aNuptKjN4lTGHHrPtSJbqzkm7g7XYpDblJffKgonGeH03MfEi2U5y9PGe2m6Hd YarI1L+RSKT3lMsKURbVWgD8ge6FEt3y986+TXPdLOL40N3Pqknv/YEOdJemzaSB1SpX agu6DMZtJSSCfeh8J8XgDQzl4fsQgCrOGFYqTHW6mcK4rYDJzLHrD7SGp6A0nCTPj17R OrwXsWdtMtdwrRoNSCcrMHHv56X1kgZiZQIPO+L6Atu25bQ1hYOLkbrjyV4a5a4DlHOf lwgA7aKdMNlCYBaElNxPyvM68HREaq+JYNlkkSzrxr0dJckWnBYFYcHX9SYTRoRi4FNS hWPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=lr1wEABKOdZQ64LYBwfhFywOCQhDSlOkOKbatO29LGg=; fh=ezDJribWQValXNwqvlIln4BcOPmBpEFLMvg9GAfnQHY=; b=ed6KgYGFSeRMY5tiQyeSN+eJ+Ls7jMS0MA56NurOIocuSL+0mIOmkPnms1otHC2dd9 QEtZfNAVL90BdMLPHGRjgUiA0q7T80QvtoCBF429e2pYm6QbnKpilblMQ2C+nQgdgXIy z4bC2b4tA8vBNqWV3h8fMNSilvWkdnMTVDloYhncoPdV9+GVEk1bl+xh5RRDtKPmBWvJ GIpUuGF5hmHE78wGVOUKMTChHAuWEzqbcOcip7SDeTwNe5V46hg1oPyJ2vOykyS2UoQA IDpBXX6uJb/0d9K9pX9vQJ5lUB2qr0HHO/x31lxJdNeyVG+61UaB3u+s+oCg7uKmYmrw KCDQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uEf56g/y"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87200-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i23-20020a63cd17000000b005dc5069298fsi1815735pgg.711.2024.02.29.10.07.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 10:07:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uEf56g/y"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87200-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AF85EB23390 for ; Thu, 29 Feb 2024 17:43:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81997757E9; Thu, 29 Feb 2024 17:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uEf56g/y" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7761EB42; Thu, 29 Feb 2024 17:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709228599; cv=none; b=nIXet25/oG+vmiaPlyBqa8ha43EBT/ZFmjlJeAp+3S6JCPh3lPtwY+jLXZDhIrGLxjBpFhUd8LQzGX6wnSxt5LUnMMiQPmBdZg0ax/y0o7fSN55/LfokU1eYfTVC8jPJgaMiYLWBUjuka1LogQ2hznfZoGwgeOGxuPiL02O8fp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709228599; c=relaxed/simple; bh=Q6nxWcrxn7KzNs1FvujT6UGXcJ8SR7fy+oVrqz+kTRg=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=TJmXBv00SrO88u4hIalWg9osVnsp+4pq1r61PXJuWa5aRHIOYB/i4yTZZ29j4X7bg1AzB/6nW6FIY7EmDZ57STboG9F2p/B+GPpifr/FT0rtKm5f2qUbSeVKe1cZtQ6EjHihMZUm4GGoiv2ficSyjD1uECnQ7wfCQ2kZMMc6Ebs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uEf56g/y; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EF7AC433C7; Thu, 29 Feb 2024 17:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709228599; bh=Q6nxWcrxn7KzNs1FvujT6UGXcJ8SR7fy+oVrqz+kTRg=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=uEf56g/y0NEunY+Z9giAExLkZZkYuxInd0/k3kb04EAvxU2MNPmBnZ82ZaZAigAWx TFeZECdMLyLAq7db17nRSyogMyKY3CPcasimkaSFCkdzNtQ/guq5qaII+HvNsiSXkS 5y8vSysB/yYcbDa3Sl26RjOu8UN5qTGm8Xswxbjp6+QrohwNegghXaFo3GE+NHbe++ 8crKR4a4dChtkRQrsTPnBl7cGLisRGz+tLFrZiHua2IJOH/AxRWj1PyJL69Bq+8F05 a/zqyW70Qwxs+zlO6uipD3rmxwlDiXEa6KEVxDVJzPyyX4fw5K8Ov22FHVFtTjTyMW YVxtTird2F/9Q== From: Lee Jones To: Pavel Machek , Arnd Bergmann Cc: Arnd Bergmann , Andrew Lunn , Christian Marangi , "David S. Miller" , Jacek Anaszewski , Hans de Goede , Jean-Jacques Hiblot , Heiner Kallweit , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240228093834.2230004-1-arnd@kernel.org> References: <20240228093834.2230004-1-arnd@kernel.org> Subject: Re: (subset) [PATCH] leds: fix ifdef check for gpio_led_register_device() Message-Id: <170922859684.1626996.4061581947298770912.b4-ty@kernel.org> Date: Thu, 29 Feb 2024 17:43:16 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Wed, 28 Feb 2024 10:38:26 +0100, Arnd Bergmann wrote: > gpio_led_register_device() is built whenever CONFIG_LEDS_GPIO_REGISTER is > enabled, and this may be used even when CONFIG_NEW_LEDS is turned off. > > However, the stub declaration in the header is provided for all configs > without CONFIG_NEW_LEDS, resulting in a build failure: > > drivers/leds/leds-gpio-register.c:24:1: error: redefinition of 'gpio_led_register_device' > 24 | gpio_led_register_device(int id, const struct gpio_led_platform_data *pdata) > | ^ > include/linux/leds.h:646:39: note: previous definition is here > > [...] Applied, thanks! [1/1] leds: fix ifdef check for gpio_led_register_device() commit: 71c65d0ff79e3b21cb3eba67d87159533daaadbc -- Lee Jones [李琼斯]