Received-SPF: pass (google.com: domain of linux-kernel+bounces-87230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 29 Feb 2024 18:07:17 +0000
From: Conor Dooley <conor@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "antoniu.miclaus@analog.com" <antoniu.miclaus@analog.com>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v8 2/2] dt-bindings: rtc: add max313xx RTCs
Message-ID: <20240229-skeletal-ultimatum-27cd91e8d8a8@spud>
References: <20240227010312.3305966-1-chris.packham@alliedtelesis.co.nz>
 <20240227010312.3305966-3-chris.packham@alliedtelesis.co.nz>
 <20240228-embark-rimmed-d81bab3d42b8@spud>
 <bd43a198-6287-40b2-be15-2734c5d2742d@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="iR98pNhTE57Kvx2v"
Content-Disposition: inline
In-Reply-To: <bd43a198-6287-40b2-be15-2734c5d2742d@alliedtelesis.co.nz>


--iR98pNhTE57Kvx2v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024 at 08:21:35PM +0000, Chris Packham wrote:
>=20
> On 29/02/24 00:58, Conor Dooley wrote:
> > On Tue, Feb 27, 2024 at 02:03:10PM +1300, Chris Packham wrote:
> >
> >>     interrupts:
> >> +    description:
> >> +      Alarm1 interrupt line of the RTC. Some of the RTCs have two int=
errupt
> >> +      lines and alarm1 interrupt muxing depends on the clockin/clocko=
ut
> >> +      configuration.
> >>       maxItems: 1
> > The maxItems: 1 looks odd here when you state "some of the RTCs have two
> > interrupt lines", which makes it sound as if there are actually two
> > interrupts that should be exposed here. If those two interrupts get
> > muxed to the same pin for output I'd suggest that you clarify that here.
>=20
> This may end up changing if I can come up with something that Alexandre=
=20
> is happy with. Basically (some of) the chips have a configurable pin=20
> that can either be dedicated to the ALARM1 output (annoyingly labelled=20
> as INTB) or to a clock output. There is an INTA line that has other=20
> interrupts and if the clock output option is used then it also has=20
> ALARM1. The driver doesn't currently do anything with the other=20
> interrupt sources so as written this needs to correspond to whichever=20
> interrupt output is asserted for ALARM1.

So you're saying that depending on whether or not the clock output is
used, there could be two interrupts?

Without looking further, it sounds like you should be setting maxItems
to 1 if #clock-cells is present and to 2 if it is not. Then if there are
two interrupts provided, the driver is free to configure whatever way it
wants. If there aren't, send everything to INTA.

Am I missing something?

Cheers,
Conor.

--iR98pNhTE57Kvx2v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeDH1QAKCRB4tDGHoIJi
0mgUAP968MrAUrLc4/ZPgIL2M9ot1CbzwNP1m69CXgjSTaqhBAEAzgOl8/WsPk83
fJ+Eot7rs9erOG9XK/haG0oYOJlUBww=
=znc+
-----END PGP SIGNATURE-----

--iR98pNhTE57Kvx2v--