Received-SPF: pass (google.com: domain of linux-kernel+bounces-87231-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240226013208.2389246-1-chao@kernel.org> <20240226013208.2389246-4-chao@kernel.org>
In-Reply-To: <20240226013208.2389246-4-chao@kernel.org>
From: Daeho Jeong <daeho43@gmail.com>
Date: Thu, 29 Feb 2024 10:07:16 -0800
Message-ID: <CACOAw_zMrGQp4oX1x559jrOVkcmj54gS0bHepMhYgFPCQKFcOg@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: fix to reset fields for unloaded curseg
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Daeho Jeong <daehojeong@google.com>

Thanks,

On Sun, Feb 25, 2024 at 5:33=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> In f2fs_allocate_data_block(), before skip allocating new segment
> for DATA_PINNED log header, it needs to tag log header as unloaded
> one to avoid skipping logic in locate_dirty_segment() and
> __f2fs_save_inmem_curseg().
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>  fs/f2fs/segment.c | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c159b0985596..5e45afd69f3f 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3101,12 +3101,16 @@ static int __allocate_new_segment(struct f2fs_sb_=
info *sbi, int type,
>         struct curseg_info *curseg =3D CURSEG_I(sbi, type);
>         unsigned int old_segno;
>
> +       if (type =3D=3D CURSEG_COLD_DATA_PINNED && !curseg->inited)
> +               goto allocate;
> +
>         if (!force && curseg->inited &&
>             !curseg->next_blkoff &&
>             !get_valid_blocks(sbi, curseg->segno, new_sec) &&
>             !get_ckpt_valid_blocks(sbi, curseg->segno, new_sec))
>                 return 0;
>
> +allocate:
>         old_segno =3D curseg->segno;
>         if (new_curseg(sbi, type, true))
>                 return -EAGAIN;
> @@ -3451,6 +3455,13 @@ static void f2fs_randomize_chunk(struct f2fs_sb_in=
fo *sbi,
>                 get_random_u32_inclusive(1, sbi->max_fragment_hole);
>  }
>
> +static void reset_curseg_fields(struct curseg_info *curseg)
> +{
> +       curseg->inited =3D false;
> +       curseg->segno =3D NULL_SEGNO;
> +       curseg->next_segno =3D 0;
> +}
> +
>  int f2fs_allocate_data_block(struct f2fs_sb_info *sbi, struct page *page=
,
>                 block_t old_blkaddr, block_t *new_blkaddr,
>                 struct f2fs_summary *sum, int type,
> @@ -3516,8 +3527,10 @@ int f2fs_allocate_data_block(struct f2fs_sb_info *=
sbi, struct page *page,
>          */
>         if (segment_full) {
>                 if (type =3D=3D CURSEG_COLD_DATA_PINNED &&
> -                   !((curseg->segno + 1) % sbi->segs_per_sec))
> +                   !((curseg->segno + 1) % sbi->segs_per_sec)) {
> +                       reset_curseg_fields(curseg);
>                         goto skip_new_segment;
> +               }
>
>                 if (from_gc) {
>                         get_atssr_segment(sbi, type, se->type,
> @@ -4595,9 +4608,7 @@ static int build_curseg(struct f2fs_sb_info *sbi)
>                         array[i].seg_type =3D CURSEG_COLD_DATA;
>                 else if (i =3D=3D CURSEG_ALL_DATA_ATGC)
>                         array[i].seg_type =3D CURSEG_COLD_DATA;
> -               array[i].segno =3D NULL_SEGNO;
> -               array[i].next_blkoff =3D 0;
> -               array[i].inited =3D false;
> +               reset_curseg_fields(&array[i]);
>         }
>         return restore_curseg_summaries(sbi);
>  }
> --
> 2.40.1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel